From patchwork Fri Mar 10 15:34:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 66229 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1646438582BE for ; Fri, 10 Mar 2023 15:35:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1646438582BE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678462529; bh=R5tCwEFF6e097Vnsv3cdRmQZa8jLpwqA6EXzPzjsFxY=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=tqcbjTpGJ8jarjgRGlX25ZIeUjrXniWqINa6fKYaxEeqhNeWH5a128SlvRKVKmjPY C7Mr0QH8HB6dU5RR+jja6PzEOv5UJ9e+HjZwD3gW5pT1iNlGPXtU2y4G4iry9eOpj+ EaPcJ3teBxsaBuaRaUKgSTEW3+6h7tFpis0GzW50= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 55D913858C1F for ; Fri, 10 Mar 2023 15:34:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 55D913858C1F Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8D08B2065D for ; Fri, 10 Mar 2023 15:34:35 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7AC5F134F7 for ; Fri, 10 Mar 2023 15:34:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YIn0HAtOC2SxBwAAMHmgww (envelope-from ) for ; Fri, 10 Mar 2023 15:34:35 +0000 To: gdb-patches@sourceware.org Subject: [pushed 4/4] [gdb/testsuite] Fix gdb.python/py-completion.exp Date: Fri, 10 Mar 2023 16:34:33 +0100 Message-Id: <20230310153433.6265-4-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230310153433.6265-1-tdevries@suse.de> References: <20230310153433.6265-1-tdevries@suse.de> MIME-Version: 1.0 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom de Vries via Gdb-patches From: Tom de Vries Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" With test-case gdb.python/py-completion.exp and target board native-extended-gdbserver I get this warning: ... (gdb) PASS: gdb.python/py-completion.exp: discard #2 completefilecommandcond $outputs/gdb.python/py-completion/py-completion-t^G\ PASS: gdb.python/py-completion.exp: completefilecommandcond completion Remote debugging from host ::1, port 53346^M monitor exit^M not implemented^M (gdb) WARNING: Timed out waiting for EOF in server after monitor exit ... Fix this by adding the missing "discard #3", such that we have instead: ... (gdb) PASS: gdb.python/py-completion.exp: discard #2 completefilecommandcond $outputs/gdb.python/py-completion/py-completion-t^G\ PASS: gdb.python/py-completion.exp: completefilecommandcond completion ^M not implemented^M (gdb) PASS: gdb.python/py-completion.exp: discard #3 Remote debugging from host ::1, port 36278^M monitor exit^M (gdb) ... Tested on x86_64-linux. --- gdb/testsuite/gdb.python/py-completion.exp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gdb/testsuite/gdb.python/py-completion.exp b/gdb/testsuite/gdb.python/py-completion.exp index b3acebf66a1..23f981e944a 100644 --- a/gdb/testsuite/gdb.python/py-completion.exp +++ b/gdb/testsuite/gdb.python/py-completion.exp @@ -72,6 +72,8 @@ if { [readline_is_used] && ![is_remote host] } { } } + # Discarding again + gdb_test " " ".*" "discard #[incr discard]" } # Start gdb over again to clear out current state. This can interfere