From patchwork Tue Mar 7 18:27:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 66093 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 70EE1385559E for ; Tue, 7 Mar 2023 18:27:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 70EE1385559E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678213661; bh=IQ6lYZkgo/Yaoq+5x26Q4/PeeS5HHhZhfKCrIj01DzQ=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=HtZrIY/+KZGA8b9Ie5nfnllCWWJ5ETVRzOYUHDjQn785TmLZ23vnvWs7xZ6rpwh2i 0/IF/7Yh00D7Jp1YuR5oeVbfmlonEN7gaHEzU0CSg222gDBmdKp2qsTfBwRU8lNu0z XOPjPkyKFeM/V4y4eDc3nUiH0cBBvVyobYOMRDyw= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id 17C593851C20 for ; Tue, 7 Mar 2023 18:27:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 17C593851C20 Received: by mail-il1-x135.google.com with SMTP id w4so4697792ilv.0 for ; Tue, 07 Mar 2023 10:27:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678213638; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IQ6lYZkgo/Yaoq+5x26Q4/PeeS5HHhZhfKCrIj01DzQ=; b=xVLXYlmRjAMkTM0PdIyKQY0iWIrsrekPlVD6ySVSqfoUAGfMGeJudRO6glT9UC39f1 LzJ9DiakXlZFtpHFDSNbcovg2Tzw9khPoyYLBkHO6Sj6zu5a53e7k0aJtXwdz9Wwf+Vh nDRLmzh66mUuFVF/Egb90nMLrGIKOFppt0g+ueMJtzVzISlec8pQNZE/uD9jpo0LuqQb 9mp1pPCvEfPgO945gpI0eBG8kXNtlac+MWui3JH12uNGhKpv51WkDjqYlbvKXb8559Wy UIfK4aErDegmDra3z9WIqD7G9btnom5XPkSJtTSk8tsFK9CfnGsiiejbGBtckDAt8Qal 16XA== X-Gm-Message-State: AO0yUKUCaEotRi6vlOO5ikZ6ttDya1E+lvbejId+VJV/m/efNKdB50+h lOfIt1l8wWzVyWOYO2YPXeGDEnrbHAIKCtIPd9I= X-Google-Smtp-Source: AK7set/RGCQYhN81ui7vNFlE85hCQINIVi394SOeTTFpcZuLKQbfwji2BVyjy0UWY6TMz9lvuuRLDw== X-Received: by 2002:a92:ca0d:0:b0:319:4494:15b0 with SMTP id j13-20020a92ca0d000000b00319449415b0mr13048631ils.30.1678213638271; Tue, 07 Mar 2023 10:27:18 -0800 (PST) Received: from localhost.localdomain (75-166-130-93.hlrn.qwest.net. [75.166.130.93]) by smtp.gmail.com with ESMTPSA id g19-20020a02c553000000b003a2a167e7d9sm4309109jaj.96.2023.03.07.10.27.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 10:27:18 -0800 (PST) To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [pushed] Fix selfcheck regression due to new maint command Date: Tue, 7 Mar 2023 11:27:08 -0700 Message-Id: <20230307182708.3125328-1-tromey@adacore.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom Tromey via Gdb-patches From: Tom Tromey Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Simon points out that the new maint command, intended to fix a regression, also introduces a new regression in "maint selftest". This patch fixes the error. I did a full regression test on x86-64 Fedora 36. --- gdb/dwarf2/cooked-index.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/dwarf2/cooked-index.c b/gdb/dwarf2/cooked-index.c index d09faed268d..3a907690906 100644 --- a/gdb/dwarf2/cooked-index.c +++ b/gdb/dwarf2/cooked-index.c @@ -659,8 +659,8 @@ _initialize_cooked_index () add_cmd ("wait-for-index-cache", class_maintenance, maintenance_wait_for_index_cache, _("\ -Usage: maintenance wait-for-index-cache\n\ -Wait until all pending writes to the index cache have completed."), +Wait until all pending writes to the index cache have completed.\n\ +Usage: maintenance wait-for-index-cache"), &maintenancelist); gdb::observers::gdb_exiting.attach (wait_for_index_cache, "cooked-index");