diff mbox series

[v2,4/4,gdb/testsuite] Move gdb.base/gdb-caching-proc.exp to gdb.testsuite

Message ID 20230304093549.8689-4-tdevries@suse.de
State Committed
Commit f69005750d70ff4e305c45a250053823b0559f11
Headers
Series [v2,1/4,gdb/testsuite] Add gdb.testsuite/gdb-caching-proc.exp |

Commit Message

Tom de Vries March 4, 2023, 9:35 a.m. UTC 
  Test-case gdb.base/gdb-caching-proc.exp doesn't really test gdb, but it tests
the gdb_caching_procs in the testsuite, so it belongs in gdb.testsuite rather
than gdb.base.

Move test-case gdb.base/gdb-caching-proc.exp to gdb.testsuite, renaming it to
gdb.testsuite/gdb-caching-proc-consistency.exp to not clash with
recently added gdb.testsuite/gdb-caching-proc.exp.

Tested on x86_64-linux.
---
 .../gdb-caching-proc-consistency.exp}                             | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename gdb/testsuite/{gdb.base/gdb-caching-proc.exp => gdb.testsuite/gdb-caching-proc-consistency.exp} (100%)

Comments

Tom Tromey March 6, 2023, 2:48 p.m. UTC | #1 
>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> Test-case gdb.base/gdb-caching-proc.exp doesn't really test gdb, but it tests
Tom> the gdb_caching_procs in the testsuite, so it belongs in gdb.testsuite rather
Tom> than gdb.base.

Tom> Move test-case gdb.base/gdb-caching-proc.exp to gdb.testsuite, renaming it to
Tom> gdb.testsuite/gdb-caching-proc-consistency.exp to not clash with
Tom> recently added gdb.testsuite/gdb-caching-proc.exp.

Tom> Tested on x86_64-linux.

I agree, seems fine, though I don't understand why it wasn't just
created there?
Reviewed-By: Tom Tromey <tom@tromey.com>

Tom
Tom de Vries March 6, 2023, 3:45 p.m. UTC | #2 
On 3/6/23 15:48, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Tom> Test-case gdb.base/gdb-caching-proc.exp doesn't really test gdb, but it tests
> Tom> the gdb_caching_procs in the testsuite, so it belongs in gdb.testsuite rather
> Tom> than gdb.base.
> 
> Tom> Move test-case gdb.base/gdb-caching-proc.exp to gdb.testsuite, renaming it to
> Tom> gdb.testsuite/gdb-caching-proc-consistency.exp to not clash with
> Tom> recently added gdb.testsuite/gdb-caching-proc.exp.
> 
> Tom> Tested on x86_64-linux.
> 
> I agree, seems fine, though I don't understand why it wasn't just
> created there?

The test-case gdb.base/gdb-caching-proc.exp was by added by this commit:
...
commit 64d27cfc97f5b865019f0b7293ff2b9565db427c
Author: Tom de Vries <tdevries@suse.de>
Date:   Sat Dec 1 08:56:56 2018 +0100
...

The dir gdb.testsuite was added by this commit:
...
commit 213fd9faf563ce5726ce66c8104cbaba44ba9c09
Author: Pedro Alves <palves@redhat.com>
Date:   Thu Jul 4 16:45:23 2019 +0100
...

In other words, the test-case wasn't created in gdb.testsuite because it 
predates gdb.testsuite.

Thanks for the reviews, I'll commit shortly.

Thanks,
- Tom

> Reviewed-By: Tom Tromey <tom@tromey.com>
> 
> Tom
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.base/gdb-caching-proc.exp b/gdb/testsuite/gdb.testsuite/gdb-caching-proc-consistency.exp
similarity index 100%
rename from gdb/testsuite/gdb.base/gdb-caching-proc.exp
rename to gdb/testsuite/gdb.testsuite/gdb-caching-proc-consistency.exp