From patchwork Wed Mar 1 21:30:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 65872 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6E0B2385559F for ; Wed, 1 Mar 2023 21:30:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6E0B2385559F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677706243; bh=GoPVsUFQGzv7F28MeyQW+jcspt3HPM/BeksOIJzXuEQ=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=DCIe5k82wOzCX9wGmWXSvR8Hh0y6qxVEvwT+WKB/OVLSI7675T2uQvQeGUWP2MmRE eeAvjNEVHZo8eCOvTqmv1GUH6vNTcvxQmJ4B3r9ls745D56V/cyum3/XMBePjtIDJX xmTQW7bVol3AS29QTfM8G7+Wtd1z/Qwj0mIhb/28= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by sourceware.org (Postfix) with ESMTPS id 2DE0B3858C62 for ; Wed, 1 Mar 2023 21:30:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2DE0B3858C62 Received: by mail-il1-x12e.google.com with SMTP id o8so9204166ilt.13 for ; Wed, 01 Mar 2023 13:30:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677706219; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GoPVsUFQGzv7F28MeyQW+jcspt3HPM/BeksOIJzXuEQ=; b=vo/vBbab7+gve8Am3Z5iFQQf7E5wa/uErMtaFc1FyNlpqHlJ5umPPt38+fPDXNst8v ImtyFZe5eJBGLS2gfO44K1tz6yfiO+UqnVhMZdNm8okZsInNBSsPREHGLqpFe2nmjPMU 6RJRZ4PkA0kZg3nHQGXsTL0jwKZkGVG0MC5NFEZBe5zceazBPcim0SOBVYGtNkLoDWPo ddmvVkYEjjIu6G8krbJt1w5PLlq2NA8on3UqUlIXLPj+Gq2iENwcxpYTzKf+fT+IXwMC xfHASxhlENLxzCZ3WjEMcf/b5iaZXClE/H3BuTIYxNHoy4SMzmkFk8m/fczuBO698dPs iddA== X-Gm-Message-State: AO0yUKWYrfLclWCVKmQfULPLhYpUVv+jzGsmy0kMqKVd0xKhiZqj+kfX gRSKXrMq+5keiYP/CBQ70J3a8YsHtvmm0GEz X-Google-Smtp-Source: AK7set/pzejxPdL8PTuk1F2fWe/aL+zhsHxfiN+myXnRFmor898JcUe3UcxLd1q92MfYUxzoIeu/5Q== X-Received: by 2002:a05:6e02:12e3:b0:313:cd79:adcb with SMTP id l3-20020a056e0212e300b00313cd79adcbmr7113009iln.18.1677706219401; Wed, 01 Mar 2023 13:30:19 -0800 (PST) Received: from localhost.localdomain (75-166-130-93.hlrn.qwest.net. [75.166.130.93]) by smtp.gmail.com with ESMTPSA id f10-20020a02caca000000b003de9d8de0edsm4237782jap.88.2023.03.01.13.30.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 13:30:18 -0800 (PST) To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Fix some value comments Date: Wed, 1 Mar 2023 14:30:09 -0700 Message-Id: <20230301213009.4030832-1-tromey@adacore.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom Tromey via Gdb-patches From: Tom Tromey Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" I noticed a very stale comment in valarith.c. This patch fixes a few comments in this area. Reviewed-By: Andrew Burgess --- gdb/valarith.c | 6 +++++- gdb/value.h | 5 +++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/gdb/valarith.c b/gdb/valarith.c index 6ea0cd9e8d1..4c2b44360bb 100644 --- a/gdb/valarith.c +++ b/gdb/valarith.c @@ -1884,7 +1884,7 @@ value_less (struct value *arg1, struct value *arg2) } } -/* The unary operators +, - and ~. They free the argument ARG1. */ +/* See value.h. */ struct value * value_pos (struct value *arg1) @@ -1902,6 +1902,8 @@ value_pos (struct value *arg1) error (_("Argument to positive operation not a number.")); } +/* See value.h. */ + struct value * value_neg (struct value *arg1) { @@ -1948,6 +1950,8 @@ value_neg (struct value *arg1) error (_("Argument to negate operation not a number.")); } +/* See value.h. */ + struct value * value_complement (struct value *arg1) { diff --git a/gdb/value.h b/gdb/value.h index c3eb96bf143..d83c4ab3674 100644 --- a/gdb/value.h +++ b/gdb/value.h @@ -1206,10 +1206,15 @@ extern struct value *value_ref (struct value *arg1, enum type_code refcode); extern struct value *value_assign (struct value *toval, struct value *fromval); +/* The unary + operation. */ extern struct value *value_pos (struct value *arg1); +/* The unary - operation. */ extern struct value *value_neg (struct value *arg1); +/* The unary ~ operation -- but note that it also implements the GCC + extension, where ~ of a complex number is the complex + conjugate. */ extern struct value *value_complement (struct value *arg1); extern struct value *value_struct_elt (struct value **argp,