Remove dead code from scalar_binop
Commit Message
scalar_binop has code for "&&" and "||", but I think this code can't
currently be run -- and, furthermore, it doesn't make sense to have
this code here, as the point of these operators is to short-circuit
evaluation.
This patch removes the dead code.
Regression tested on x86-64 Fedora 36.
---
gdb/valarith.c | 16 ----------------
1 file changed, 16 deletions(-)
Comments
On Wed, 1 Mar 2023 14:27:08 -0700
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> wrote:
> scalar_binop has code for "&&" and "||", but I think this code can't
> currently be run -- and, furthermore, it doesn't make sense to have
> this code here, as the point of these operators is to short-circuit
> evaluation.
Agreed, on both points. (Though it took me a while to convince myself
that it couldn't currently be run.)
Approved-by: Kevin Buettner <kevinb@redhat.com>
@@ -1331,14 +1331,6 @@ scalar_binop (struct value *arg1, struct value *arg2, enum exp_opcode op)
v = v1 ^ v2;
break;
- case BINOP_LOGICAL_AND:
- v = v1 && v2;
- break;
-
- case BINOP_LOGICAL_OR:
- v = v1 || v2;
- break;
-
case BINOP_MIN:
v = v1 < v2 ? v1 : v2;
break;
@@ -1492,14 +1484,6 @@ scalar_binop (struct value *arg1, struct value *arg2, enum exp_opcode op)
v = v1 ^ v2;
break;
- case BINOP_LOGICAL_AND:
- v = v1 && v2;
- break;
-
- case BINOP_LOGICAL_OR:
- v = v1 || v2;
- break;
-
case BINOP_MIN:
v = v1 < v2 ? v1 : v2;
break;