From patchwork Mon Feb 27 19:42:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Merey X-Patchwork-Id: 65694 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1D5CB3858004 for ; Mon, 27 Feb 2023 19:42:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1D5CB3858004 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677526979; bh=HRGE2HbisBa+uMzl+Z+PKXYg9oktZ2wcW0dW8DnKhf4=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=XtOlR9IsX8c2D8VTTNfUVx1i2KlTlJu8Do5mAnkyXo2kjcunCsWd49sObTjK3dHQ3 cGp2nzOt5BKFYP+4YO/1lJeXa4Ku/9sNZkjLIqZRmfjdX/0AUj5vFzyvVqBwdHYTkb zUs8YQLGDrO7NkT9zIUo5Hf658ZyykGcxRrMHctg= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C695D3858C52 for ; Mon, 27 Feb 2023 19:42:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C695D3858C52 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-103-PwLhO7FbNxyZWQiJFOEFlw-1; Mon, 27 Feb 2023 14:42:16 -0500 X-MC-Unique: PwLhO7FbNxyZWQiJFOEFlw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 10FD01C04336 for ; Mon, 27 Feb 2023 19:42:16 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.18.122]) by smtp.corp.redhat.com (Postfix) with ESMTP id D6523492C3E; Mon, 27 Feb 2023 19:42:15 +0000 (UTC) To: gdb-patches@sourceware.org Cc: Aaron Merey Subject: [PATCH 6/7] gdb/testsuite/gdb.debuginfod: Add lazy downloading tests Date: Mon, 27 Feb 2023 14:42:11 -0500 Message-Id: <20230227194212.348003-6-amerey@redhat.com> In-Reply-To: <20230227194212.348003-1-amerey@redhat.com> References: <20230227194212.348003-1-amerey@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Aaron Merey via Gdb-patches From: Aaron Merey Reply-To: Aaron Merey Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Add some tests for 'set debuginfod enabled lazy', .gdb_index downloading and deferred debuginfo downloading. --- .../gdb.debuginfod/fetch_src_and_symbols.exp | 58 +++++++++++++++++++ gdb/testsuite/gdb.debuginfod/libsection.c | 24 ++++++++ gdb/testsuite/gdb.debuginfod/section.c | 28 +++++++++ 3 files changed, 110 insertions(+) create mode 100644 gdb/testsuite/gdb.debuginfod/libsection.c create mode 100644 gdb/testsuite/gdb.debuginfod/section.c diff --git a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp b/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp index 8158c5c3cc6..fc7e4b685dc 100644 --- a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp +++ b/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp @@ -42,6 +42,23 @@ if { [gdb_compile "$sourcetmp" "${binfile}2" executable {debug build-id}] != "" return -1 } +set sectfile "section" +set sectsrc $srcdir/$subdir/section.c +set sectexec [standard_output_file $sectfile] + +set libfile "libsection" +set libsrc $srcdir/$subdir/$libfile.c +set lib_sl [standard_output_file $libfile.sl] + +set lib_opts [list debug build-id ] +set exec_opts [list debug build-id shlib=$lib_sl] + +if { [gdb_compile_shlib $libsrc $lib_sl $lib_opts] != "" + || [gdb_compile $sectsrc $sectexec executable $exec_opts] != "" } { + untested "failed to compile" + return -1 +} + # Write some assembly that just has a .gnu_debugaltlink section. # Copied from testsuite/gdb.dwarf2/dwzbuildid.exp. proc write_just_debugaltlink {filename dwzname buildid} { @@ -94,6 +111,7 @@ proc write_dwarf_file {filename buildid {value 99}} { } set corefile [standard_output_file "corefile"] +set lazy_support -1 # Setup the global variable DEBUGDIR as a directory containing the # debug information for the test executable. @@ -103,6 +121,8 @@ set corefile [standard_output_file "corefile"] # running. proc_with_prefix no_url { } { global binfile outputdir debugdir + global sectexec lib_sl libfile lazy_support + global gdb_prompt setenv DEBUGINFOD_URLS "" @@ -119,11 +139,18 @@ proc_with_prefix no_url { } { return -1 } + if { [gdb_gnu_strip_debug $lib_sl ""] != 0} { + fail "strip shlib debuginfo" + return -1 + } + set debugdir [standard_output_file "debug"] set debuginfo [standard_output_file "fetch_src_and_symbols.debug"] + set debuginfo_shlib [standard_output_file $libfile.sl.debug] file mkdir $debugdir file rename -force $debuginfo $debugdir + file rename -force $debuginfo_shlib $debugdir # Test that GDB cannot find symbols without debuginfod. clean_restart $binfile @@ -171,6 +198,25 @@ proc_with_prefix no_url { } { clean_restart gdb_test "core $::corefile" ".*in ?? ().*" "file [file tail $::corefile]" + clean_restart + + # Check for lazy downloading support. + gdb_test_multiple "set debuginfod enabled lazy" "check for lazy" { + -re ".*lazy downloading is not compiled into GDB.*\n.*${gdb_prompt} $" { + set lazy_support 0 + } + -re ".*${gdb_prompt} $" { + set lazy_support 1 + } + } + + if {$lazy_support == 1} { + gdb_test "file $sectexec" "" "file [file tail $sectexec] file no url" + gdb_test "start" "" "file [file tail $sectexec] start no url" + gdb_test "info sharedlibrary" ".*Yes \\(\\*\\).*libsection.*" "lib no debug" + } else { + untested "lazy support no_url" + } } # Test that GDB prints the debuginfod URLs when loading files. URLS @@ -208,6 +254,7 @@ proc disable_delete_breakpoints {} { # expected debug information. proc_with_prefix local_url { } { global binfile outputdir debugdir db + global sectexec lib_sl libfile lazy_support set url [start_debuginfod $db $debugdir] if { $url == "" } { @@ -256,6 +303,17 @@ proc_with_prefix local_url { } { "file [file tail ${binfile}_alt.o]" \ $enable_debuginfod_question "y" + if {$lazy_support == 1} { + # GDB should now download .gdb_index. + clean_restart + gdb_test "set debuginfod enabled lazy" "" "set lazy urls" + gdb_test "file $sectexec" "" "file [file tail $sectexec] file urls" + set res ".*Download.*\.gdb_index.*libsection.*\r\nDownload.*debug info.*libsection.*" + gdb_test "start $sectexec" $res "file [file tail $sectexec] start urls" + } else { + untested "lazy support urls" + } + # Configure debuginfod with commands. unsetenv DEBUGINFOD_URLS clean_restart diff --git a/gdb/testsuite/gdb.debuginfod/libsection.c b/gdb/testsuite/gdb.debuginfod/libsection.c new file mode 100644 index 00000000000..510f9205282 --- /dev/null +++ b/gdb/testsuite/gdb.debuginfod/libsection.c @@ -0,0 +1,24 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2020-2023 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +#include + +void +libsection_test () +{ + printf ("In libsection\n"); +} diff --git a/gdb/testsuite/gdb.debuginfod/section.c b/gdb/testsuite/gdb.debuginfod/section.c new file mode 100644 index 00000000000..3598896c1bc --- /dev/null +++ b/gdb/testsuite/gdb.debuginfod/section.c @@ -0,0 +1,28 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2020-2023 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +#include + +extern void libsection_test (); + +int +main() +{ + (void) open ("", 0); + libsection_test (); + return 0; +}