From patchwork Fri Feb 24 14:04:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Aktemur, Tankut Baris" X-Patchwork-Id: 65590 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9EB8B38515DD for ; Fri, 24 Feb 2023 14:04:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9EB8B38515DD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677247495; bh=KK17zQ6Ab5Bbg+RmbEXdddz6DE93vWS880s4ueWpRWQ=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=emTbsUOKwaiWbhKftm/TBRXkeX7BBFjhjMJqV+uLvuSYtsk/8XhH3vhY4K1lHNWVU S0dhvOs41F1LItEwiU1i52JqtIQowE1liccdix28S772hZkQLQ94GtCGIqt80r+8tU ITpBt+sC4YePbT7yOOpWjtB/7124tyBBwOVw407I= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by sourceware.org (Postfix) with ESMTPS id 035C1385840F for ; Fri, 24 Feb 2023 14:04:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 035C1385840F X-IronPort-AV: E=McAfee;i="6500,9779,10630"; a="313114103" X-IronPort-AV: E=Sophos;i="5.97,324,1669104000"; d="scan'208";a="313114103" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2023 06:04:26 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10630"; a="674941453" X-IronPort-AV: E=Sophos;i="5.97,324,1669104000"; d="scan'208";a="674941453" Received: from ultl2604.iul.intel.com (HELO localhost) ([172.28.48.47]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2023 06:04:22 -0800 To: gdb-patches@sourceware.org Subject: [PATCH 1/2] gdb, python: do minor modernization in execute_gdb_command Date: Fri, 24 Feb 2023 15:04:09 +0100 Message-Id: <20230224140410.2647437-1-tankut.baris.aktemur@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-9.6 required=5.0 tests=AC_FROM_MANY_DOTS, BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tankut Baris Aktemur via Gdb-patches From: "Aktemur, Tankut Baris" Reply-To: Tankut Baris Aktemur Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Use nullptr instead of NULL and boolify two local variables in execute_gdb_command. --- gdb/python/python.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/gdb/python/python.c b/gdb/python/python.c index ed466cc4511..5719f351528 100644 --- a/gdb/python/python.c +++ b/gdb/python/python.c @@ -621,31 +621,32 @@ static PyObject * execute_gdb_command (PyObject *self, PyObject *args, PyObject *kw) { const char *arg; - PyObject *from_tty_obj = NULL, *to_string_obj = NULL; - int from_tty, to_string; - static const char *keywords[] = { "command", "from_tty", "to_string", NULL }; + PyObject *from_tty_obj = nullptr; + PyObject *to_string_obj = nullptr; + static const char *keywords[] = { "command", "from_tty", "to_string", + nullptr }; if (!gdb_PyArg_ParseTupleAndKeywords (args, kw, "s|O!O!", keywords, &arg, &PyBool_Type, &from_tty_obj, &PyBool_Type, &to_string_obj)) - return NULL; + return nullptr; - from_tty = 0; - if (from_tty_obj) + bool from_tty = false; + if (from_tty_obj != nullptr) { int cmp = PyObject_IsTrue (from_tty_obj); if (cmp < 0) - return NULL; - from_tty = cmp; + return nullptr; + from_tty = ((cmp == 0) ? false : true); } - to_string = 0; - if (to_string_obj) + bool to_string = false; + if (to_string_obj != nullptr) { int cmp = PyObject_IsTrue (to_string_obj); if (cmp < 0) - return NULL; - to_string = cmp; + return nullptr; + to_string = ((cmp == 0) ? false : true); } std::string to_string_res;