diff mbox series

[3/4] More uses of require with istarget

Message ID 20230224-submit-require-fixes-v1-3-7cbcbbf613c9@tromey.com
State New
Headers
Series More uses of require |

Commit Message

Tom Tromey Feb. 24, 2023, 8:28 p.m. UTC 
  I found a few more spots that check istarget that can be switched to
use 'require'.
---
 gdb/testsuite/gdb.base/checkpoint.exp               | 4 +---
 gdb/testsuite/gdb.base/foll-exec-mode.exp           | 4 +---
 gdb/testsuite/gdb.base/foll-exec.exp                | 4 +---
 gdb/testsuite/gdb.base/inferior-died.exp            | 5 +----
 gdb/testsuite/gdb.base/jit-reader-exec.exp          | 4 +---
 gdb/testsuite/gdb.base/multi-forks.exp              | 4 +---
 gdb/testsuite/gdb.base/pie-execl.exp                | 4 +---
 gdb/testsuite/gdb.base/step-indirect-call-thunk.exp | 4 +---
 gdb/testsuite/gdb.threads/check-libthread-db.exp    | 3 ++-
 9 files changed, 10 insertions(+), 26 deletions(-)
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.base/checkpoint.exp b/gdb/testsuite/gdb.base/checkpoint.exp
index 189a240979f..a4ea94354b7 100644
--- a/gdb/testsuite/gdb.base/checkpoint.exp
+++ b/gdb/testsuite/gdb.base/checkpoint.exp
@@ -16,9 +16,7 @@ 
 # Until "set follow-fork-mode" and "catch fork" are implemented on
 # other targets...
 #
-if {![istarget "*-*-linux*"]} {
-    return
-}
+require {istarget "*-*-linux*"}
 
 # Checkpoint support is currently implemented in the Linux native
 # target, so only works with "target native".
diff --git a/gdb/testsuite/gdb.base/foll-exec-mode.exp b/gdb/testsuite/gdb.base/foll-exec-mode.exp
index 0846441eac7..cdfded5c111 100644
--- a/gdb/testsuite/gdb.base/foll-exec-mode.exp
+++ b/gdb/testsuite/gdb.base/foll-exec-mode.exp
@@ -35,9 +35,7 @@  if { [target_info exists gdb_protocol]
 
 # Until "catch exec" is implemented on other targets...
 #
-if {![istarget "*-linux*"]} {
-     return
-}
+require {istarget "*-linux*"}
 
 standard_testfile foll-exec-mode.c
 
diff --git a/gdb/testsuite/gdb.base/foll-exec.exp b/gdb/testsuite/gdb.base/foll-exec.exp
index 0092fcceacc..8da3e5f6635 100644
--- a/gdb/testsuite/gdb.base/foll-exec.exp
+++ b/gdb/testsuite/gdb.base/foll-exec.exp
@@ -18,9 +18,7 @@ 
 
 # Until "catch exec" is implemented on other targets...
 #
-if {![istarget "*-linux*"]} {
-    return
-}
+require {istarget "*-linux*"}
 
 standard_testfile foll-exec.c
 
diff --git a/gdb/testsuite/gdb.base/inferior-died.exp b/gdb/testsuite/gdb.base/inferior-died.exp
index 4a72e8da98b..7717b2fd929 100644
--- a/gdb/testsuite/gdb.base/inferior-died.exp
+++ b/gdb/testsuite/gdb.base/inferior-died.exp
@@ -16,10 +16,7 @@ 
 # Until "set follow-fork-mode" and "catch fork" are implemented on
 # other targets...
 #
-if {![istarget "*-*-linux*"]} {
-    unsupported "inferior-died.exp"
-    return
-}
+require {istarget "*-*-linux*"}
 
 require support_displaced_stepping
 
diff --git a/gdb/testsuite/gdb.base/jit-reader-exec.exp b/gdb/testsuite/gdb.base/jit-reader-exec.exp
index d1009449fd0..ef28ba44f2d 100644
--- a/gdb/testsuite/gdb.base/jit-reader-exec.exp
+++ b/gdb/testsuite/gdb.base/jit-reader-exec.exp
@@ -17,9 +17,7 @@ 
 # inferior that used the JIT API then exec'd a program that did not
 # use it.
 
-if {![istarget "*-linux*"]} {
-    return
-}
+require {istarget "*-linux*"}
 
 standard_testfile jit-reader-exec.c
 
diff --git a/gdb/testsuite/gdb.base/multi-forks.exp b/gdb/testsuite/gdb.base/multi-forks.exp
index 542d36efec7..02dd327cad7 100644
--- a/gdb/testsuite/gdb.base/multi-forks.exp
+++ b/gdb/testsuite/gdb.base/multi-forks.exp
@@ -16,9 +16,7 @@ 
 # Until "set follow-fork-mode" and "catch fork" are implemented on
 # other targets...
 #
-if {![istarget "*-*-linux*"]} {
-    return
-}
+require {istarget "*-*-linux*"}
 
 
 standard_testfile .c
diff --git a/gdb/testsuite/gdb.base/pie-execl.exp b/gdb/testsuite/gdb.base/pie-execl.exp
index d47fd5160d0..156deefb222 100644
--- a/gdb/testsuite/gdb.base/pie-execl.exp
+++ b/gdb/testsuite/gdb.base/pie-execl.exp
@@ -19,9 +19,7 @@ 
 global inferior_spawn_id
 global gdb_spawn_id
 
-if ![istarget *-linux*] {
-    return
-}
+require {istarget *-linux*}
 
 # In remote mode we cannot use the 'set args' command, and this
 # test requires it.
diff --git a/gdb/testsuite/gdb.base/step-indirect-call-thunk.exp b/gdb/testsuite/gdb.base/step-indirect-call-thunk.exp
index 94da7e7ce97..b51257c20cc 100644
--- a/gdb/testsuite/gdb.base/step-indirect-call-thunk.exp
+++ b/gdb/testsuite/gdb.base/step-indirect-call-thunk.exp
@@ -15,9 +15,7 @@ 
 
 standard_testfile
 
-if { ![istarget "x86*"] } {
-    return
-}
+require {istarget "x86*"}
 
 set cflags "-mindirect-branch=thunk -mfunction-return=thunk"
 
diff --git a/gdb/testsuite/gdb.threads/check-libthread-db.exp b/gdb/testsuite/gdb.threads/check-libthread-db.exp
index 2324b7f27e6..051c2322eca 100644
--- a/gdb/testsuite/gdb.threads/check-libthread-db.exp
+++ b/gdb/testsuite/gdb.threads/check-libthread-db.exp
@@ -14,9 +14,10 @@ 
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 # This test only works for native processes on GNU/Linux.
-if {[target_info gdb_protocol] != "" || ![istarget *-linux*]} {
+if {[target_info gdb_protocol] != ""} {
     return
 }
+require {istarget *-linux*}
 
 # Test relies on checking gdb debug output. Do not run if gdb debug is
 # enabled as any debug will be redirected to the log.