From patchwork Fri Feb 24 20:28:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 65623 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CD13A384FB41 for ; Fri, 24 Feb 2023 20:29:10 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 223B5385B50A for ; Fri, 24 Feb 2023 20:28:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 223B5385B50A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id 730D810047E35 for ; Fri, 24 Feb 2023 20:28:35 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id VegFptIc21ikhVegFp2Ah4; Fri, 24 Feb 2023 20:28:35 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=De7SFthW c=1 sm=1 tr=0 ts=63f91df3 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=TkTTPzHaAAAA:8 a=oQreJm1ZJsEwO1qtDOMA:9 a=QEXdDO2ut3YA:10:nop_charset_2 a=Qz3p68GZ3z-NqTySStDO:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KF8i06kxjheQZ37UMbOM4h2lY+H6JyBh58Z65IDXN3w=; b=J3JH9ykg3I5ppwYZDgNXVnuBTz oBVQJflSyxOeX+CDFNVnimrWaBSTiM5a22zJ3agcMjP8nr4vjQWjtHNXEasP2VjrXAp229Aw0Brfd HecQCEZHAEZWCvTiNAAiBBrru; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:37332 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pVegF-002w7s-AC for gdb-patches@sourceware.org; Fri, 24 Feb 2023 13:28:35 -0700 From: Tom Tromey Date: Fri, 24 Feb 2023 13:28:29 -0700 Subject: [PATCH 2/4] Use require with gdb_skip_stdio_test MIME-Version: 1.0 Message-Id: <20230224-submit-require-fixes-v1-2-7cbcbbf613c9@tromey.com> References: <20230224-submit-require-fixes-v1-0-7cbcbbf613c9@tromey.com> In-Reply-To: <20230224-submit-require-fixes-v1-0-7cbcbbf613c9@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pVegF-002w7s-AC X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net ([192.168.0.21]) [75.166.130.93]:37332 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" One use of gdb_skip_stdio_test can use 'require'. --- gdb/testsuite/gdb.base/a2-run.exp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gdb/testsuite/gdb.base/a2-run.exp b/gdb/testsuite/gdb.base/a2-run.exp index d5d4d9ef19e..08f6599c84a 100644 --- a/gdb/testsuite/gdb.base/a2-run.exp +++ b/gdb/testsuite/gdb.base/a2-run.exp @@ -16,9 +16,7 @@ # This file was written by Rob Savoye. (rob@cygnus.com) # Can't do this test without stdio support. -if [gdb_skip_stdio_test "a2run.exp"] { - return -} +require {!gdb_skip_stdio_test "a2run.exp"} # # test running programs