From patchwork Thu Feb 23 19:47:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 65537 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1B3D9385B52D for ; Thu, 23 Feb 2023 19:48:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1B3D9385B52D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677181739; bh=xO86pLQnEuyIGtThBPu93pJstN3l4vmlraHtJmbhWVI=; h=Date:Subject:References:In-Reply-To:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=cdOGQY+nrYnXRJ7e/2Tx0V167ZVBIR0mKax1yc8KDt0L9wS/G9gzeoANtEYCU1g71 5JscbzUtoSHmXmE62a8WcUhM7cPUajZBfiCVIRH2/Trw5LTSMjaysGEFYee9tX6Gi9 6Ysy7hZYel4OslwhIKzf5UkemsAy4uu39PfkMqHg= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id 28298385840F for ; Thu, 23 Feb 2023 19:48:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 28298385840F Received: by mail-il1-x135.google.com with SMTP id i4so4397816ils.1 for ; Thu, 23 Feb 2023 11:48:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xO86pLQnEuyIGtThBPu93pJstN3l4vmlraHtJmbhWVI=; b=WgjGNyAxF6C0ql4Nukf4nmc2eMcOfe4bXtQcG1a6wZc6X1SNs3bhE68klFIjNm2cRX EtV37xntuByfn7i82eRAXzyVdJXCJ+6CCFYIDPegAEY5UX7vjts81hOjIYieBaLl8ojA ReKWw/VlJK//5f4VTJEXk+2VJl9/WYokTV/VlEq7dJiJYURRR3OSUsq5Uw7lX/1tHp7o e4DPLj6RKhdH7Eh1wYSFrS7RLqFDRK2JplAl9E3B0fjipD6io5gkqTXhRuIXb2Gmtq01 j362WWxj9UPXU1SXLNsSv6yW7u4ojxUvvlxDFe2pYsbIELboTAxJay92C4FosJ4PYtXZ GDUw== X-Gm-Message-State: AO0yUKVOczTJ3BRtkjX67+5EjCG5eVVuYhfxEG3+2zTauDtd606JXgox GNbTSpD3O909OgvUkcERuY+50fh57bDP9Lqi X-Google-Smtp-Source: AK7set+ahUkZjHWw7Fbu0+dkWIz++UpUfEdSdzcf3gl0Uwb+3QKxeY2u/OggSHmnja2xq/IxnuWvgQ== X-Received: by 2002:a92:7a0e:0:b0:315:4c18:5142 with SMTP id v14-20020a927a0e000000b003154c185142mr9676591ilc.10.1677181682421; Thu, 23 Feb 2023 11:48:02 -0800 (PST) Received: from localhost.localdomain (75-166-130-93.hlrn.qwest.net. [75.166.130.93]) by smtp.gmail.com with ESMTPSA id x4-20020a920604000000b00316e4139270sm2038351ilg.35.2023.02.23.11.48.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 11:48:01 -0800 (PST) Date: Thu, 23 Feb 2023 12:47:59 -0700 Subject: [PATCH 1/6] Clean up gmp-utils.h includes MIME-Version: 1.0 Message-Id: <20230223-submit-gmp-hiding-v1-1-ea6ff9e32716@adacore.com> References: <20230223-submit-gmp-hiding-v1-0-ea6ff9e32716@adacore.com> In-Reply-To: <20230223-submit-gmp-hiding-v1-0-ea6ff9e32716@adacore.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.0 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom Tromey via Gdb-patches From: Tom Tromey Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" gmp-utils.h includes "defs.h", but normally the rule in gdb is that the .c files include this first. This patch changes this code to match the rest of gdb. --- gdb/gmp-utils.c | 1 + gdb/gmp-utils.h | 2 -- gdb/unittests/gmp-utils-selftests.c | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/gmp-utils.c b/gdb/gmp-utils.c index b9c9b495398..8150fa5dcdf 100644 --- a/gdb/gmp-utils.c +++ b/gdb/gmp-utils.c @@ -15,6 +15,7 @@ You should have received a copy of the GNU General Public License along with this program. If not, see . */ +#include "defs.h" #include "gmp-utils.h" /* See gmp-utils.h. */ diff --git a/gdb/gmp-utils.h b/gdb/gmp-utils.h index 0e57471b2ef..0522f3453aa 100644 --- a/gdb/gmp-utils.h +++ b/gdb/gmp-utils.h @@ -20,8 +20,6 @@ #ifndef GMP_UTILS_H #define GMP_UTILS_H -#include "defs.h" - /* Include and ahead of , so as to get access to GMP's various formatting functions. */ #include diff --git a/gdb/unittests/gmp-utils-selftests.c b/gdb/unittests/gmp-utils-selftests.c index cc525a13fc0..e2ccd2ca094 100644 --- a/gdb/unittests/gmp-utils-selftests.c +++ b/gdb/unittests/gmp-utils-selftests.c @@ -17,6 +17,7 @@ You should have received a copy of the GNU General Public License along with this program. If not, see . */ +#include "defs.h" #include "gmp-utils.h" #include "gdbsupport/selftest.h"