From patchwork Wed Feb 22 22:22:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 65465 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3B23438582A1 for ; Wed, 22 Feb 2023 22:23:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3B23438582A1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677104599; bh=6TjKLIXYpxO5mtkINUk4nVJ+98e6xClCbet2hFrZCRc=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=Po4Huzn/R+T8Hj3VzYpNZHc5eg77ESQBXVnuIKgJTwWX4jwjlinQsMZd++XJMwr1i 2+rvY4L3exSxdKQqndpnkPvebI8gOf7byM3bJsyKbYehG2CnxxoSNrj/Xr/evU+PpW p2EBtWZcQV31lZcf0DL5PH1zt593PhMyYcvf9+a8= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by sourceware.org (Postfix) with ESMTPS id 8AB123858D33 for ; Wed, 22 Feb 2023 22:22:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8AB123858D33 Received: by mail-io1-xd36.google.com with SMTP id d73so4123887iof.4 for ; Wed, 22 Feb 2023 14:22:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6TjKLIXYpxO5mtkINUk4nVJ+98e6xClCbet2hFrZCRc=; b=rN4aSDyG6kwaWxM2dnUvuZej/Z5DxFp9D5qucd1knHkesakZX+fjwuMpwXAPMDA1TU 57trog8TRXY3TPGByWPZjFp70p/oC7Zf2C4iTOB73+t6CWVWPER9m2xzEdKtZx8jKwkF fXKugmHaAV7V5BOG1nK8uaN2l3ThSUL7h/yykw7e+pG0Zj/UlxQFB8sCKqe0oWkWeabK 1SMhG8R21jJa8nNjRBVwXwPHGMxMJgNftDJ5EjFec4WIpsshjZg4l6rcV7zrgrwNdnmj KWh0tkH9m1LfT9q7oS1BdSLdCyv03WcVAOg+aW1jXi2pI+JzR6bO0b1mD7qLnIdSMtb4 leaQ== X-Gm-Message-State: AO0yUKV0F7sxBZuWcPXYg+ccqu64dlI1ts0Wb5kb+VgYvDj1/PMtoMLn x8jdjsuDs6tNyxAmOSKh2Kfvsahy9eSgCEww X-Google-Smtp-Source: AK7set+n8n0RSROBbLGVB+QI6eQnqHhfdVZOCmx7BDBl+CFcdOTawch6nF8IRzenjZ6vyK13eOu9Lg== X-Received: by 2002:a5d:8c93:0:b0:743:7742:1bc2 with SMTP id g19-20020a5d8c93000000b0074377421bc2mr6011031ion.16.1677104572976; Wed, 22 Feb 2023 14:22:52 -0800 (PST) Received: from localhost.localdomain (75-166-130-93.hlrn.qwest.net. [75.166.130.93]) by smtp.gmail.com with ESMTPSA id z26-20020a056602005a00b00716eb44b97esm2409792ioz.27.2023.02.22.14.22.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 14:22:52 -0800 (PST) To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Remove 'eval' from gdb_breakpoint Date: Wed, 22 Feb 2023 15:22:42 -0700 Message-Id: <20230222222242.65558-1-tromey@adacore.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom Tromey via Gdb-patches From: Tom Tromey Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Now that Tcl has the {*} operator, we can remove the use of eval from gdb_breakpoint. Tested on x86-64 Fedora 36. --- gdb/testsuite/lib/gdb.exp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 6864dac3ac9..66a5d31d9ad 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -704,12 +704,7 @@ proc runto { linespec args } { set test_name "runto: run to $linespec" - # We need to use eval here to pass our varargs args to gdb_breakpoint - # which is also a varargs function. - # But we also have to be careful because $linespec may have multiple - # elements, and we don't want Tcl to move the remaining elements after - # the first to $args. That is why $linespec is wrapped in {}. - if ![eval gdb_breakpoint {$linespec} $args] { + if {![gdb_breakpoint $linespec {*}$args]} { return 0 }