diff mbox series

[pushed,gdb/testsuite] Require syscall time in gdb.reverse/time-reverse.exp

Message ID 20230221131027.29637-1-tdevries@suse.de
State Committed
Headers
Series [pushed,gdb/testsuite] Require syscall time in gdb.reverse/time-reverse.exp |

Commit Message

Tom de Vries Feb. 21, 2023, 1:10 p.m. UTC 
  On aarch64-linux, I run into:
...
Running gdb.reverse/time-reverse.exp ...
gdb compile failed, gdb.reverse/time-reverse.c: In function 'main':
gdb.reverse/time-reverse.c:39:12: error: 'SYS_time' undeclared \
  (first use in this function); did you mean 'SYS_times'?
   syscall (SYS_time, &time_global);
            ^~~~~~~~
            SYS_times
gdb.reverse/time-reverse.c:39:12: note: each undeclared identifier is \
  reported only once for each function it appears in
UNTESTED: gdb.reverse/time-reverse.exp: failed to prepare
...

Fix this by adding a new proc have_syscall, and requiring syscall time, such
that we have instead:
...
UNSUPPORTED: gdb.reverse/time-reverse.exp: require failed: \
  expr [have_syscall time]
...

Tested on x86_64-linux and aarch64-linux.
---
 gdb/testsuite/gdb.reverse/time-reverse.exp |  2 ++
 gdb/testsuite/lib/gdb.exp                  | 11 +++++++++++
 2 files changed, 13 insertions(+)


base-commit: d720176596dd6495c258fa73c4029f009616ebd2

Comments

Tom Tromey Feb. 21, 2023, 7:44 p.m. UTC | #1 
>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> +require {expr [have_syscall time]}

I think simply "require {have_syscall time}" should work.

Tom
Tom de Vries Feb. 24, 2023, 12:53 p.m. UTC | #2 
On 2/21/23 20:44, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Tom> +require {expr [have_syscall time]}
> 
> I think simply "require {have_syscall time}" should work.

Thanks for the review.

Pedro already cleaned this one up, but I found it in another test-case 
as well.

Fixed by commit below.

Thanks,
- Tom
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.reverse/time-reverse.exp b/gdb/testsuite/gdb.reverse/time-reverse.exp
index 07d55b348e8..befda65d836 100644
--- a/gdb/testsuite/gdb.reverse/time-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/time-reverse.exp
@@ -23,6 +23,8 @@  require supports_reverse
 
 standard_testfile
 
+require {expr [have_syscall time]}
+
 if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } {
     return -1
 }
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index e48228ed4f6..12839a54710 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -9397,5 +9397,16 @@  gdb_caching_proc linux_kernel_version {
     return [list $v1 $v2 $v3]
 }
 
+# Return 1 if syscall NAME is supported.
+
+proc have_syscall { name } {
+    set src \
+	[list \
+	     "#include <sys/syscall.h>" \
+	     "int var = SYS_$name;"]
+    set src [join $src "\n"]
+    return [gdb_can_simple_compile have_syscall_$name $src object]
+}
+
 # Always load compatibility stuff.
 load_lib future.exp