From patchwork Fri Feb 17 17:25:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 65190 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E37C3386187B for ; Fri, 17 Feb 2023 17:26:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E37C3386187B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1676654765; bh=goR3/D5PxDQdh7vrxGNeIt0AjRtS1eS/4QLZdaXH5bM=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=GKzL8Z+1AH0PoQweMnAPbaz9M3imuJ7JYUFDmiTfmraBz7KYABAXcengmguclYSXh ipZtydiVzN0i5osTtFCV0kL/9xMAXGPiLz9y+2VOHTl++FUGMwsdi74dN3r9/j2Ge3 PTHeXnlTEsjGf7+kxhcgGn+uQqgp818K5DtNDh4A= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by sourceware.org (Postfix) with ESMTPS id 9011D385781F for ; Fri, 17 Feb 2023 17:25:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9011D385781F Received: by mail-il1-x12e.google.com with SMTP id j11so531945ilf.0 for ; Fri, 17 Feb 2023 09:25:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=goR3/D5PxDQdh7vrxGNeIt0AjRtS1eS/4QLZdaXH5bM=; b=n2S39f0xeNcLHoOznFBKIEJMhQsEpL/A0zkXG2fsAG0JVedbKXpEw4kXQD6JqkgCuY TEWhl8gry67iTZ4XNYbTNfn+m+NrL6bS/+9oYoZq77Nzbq6T0/6XI+tub0iZm8LQoI92 0n9qzfktOzk40jicc/m5vnDun+Eqc5fpjViO85AtrIzLiGvlDljE6Pb8VXqlZioKqk5V O8XSj2zNCUUs03SPQEfRj5nsagrUykPWAKQRf8PxNTwcSZzxmKiKoxVJB0giTI2c8CJL sU9UJb1HrR9p0us3Req5XpXPYGc4kLD2Ni10KLdIHn742Tjp3oAYpvXkaXFXiQ8EgPPY 1q/g== X-Gm-Message-State: AO0yUKWj6U+wBAc4JvHAP7X6UaEhT/zMUqQOJRmd/jjT/aiqeyc/BymK kOccqBh6rsTOUIWCaV+7xIInfKFoy0ib8wOb X-Google-Smtp-Source: AK7set9PiECKqahFZqi9HHwg/Iny9mmTAozcZl8+U64Wo4MOtGI7JHC+Prt6HW2TFEDDnti/NKtgXw== X-Received: by 2002:a92:c269:0:b0:313:dd5c:e55f with SMTP id h9-20020a92c269000000b00313dd5ce55fmr5150668ild.6.1676654741763; Fri, 17 Feb 2023 09:25:41 -0800 (PST) Received: from localhost.localdomain (75-166-130-93.hlrn.qwest.net. [75.166.130.93]) by smtp.gmail.com with ESMTPSA id b11-20020a92ce0b000000b003140503bf63sm1531587ilo.11.2023.02.17.09.25.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 09:25:41 -0800 (PST) To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [pushed] Remove two unnecessary returns in ada-lang.c Date: Fri, 17 Feb 2023 10:25:32 -0700 Message-Id: <20230217172532.2369102-1-tromey@adacore.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom Tromey via Gdb-patches From: Tom Tromey Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" I found a couple of spots in ada-lang.c where a return follows a call to error. These are unnecessary because error never returns. --- gdb/ada-lang.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index eb81d737ca0..75c5f5ebd6e 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -11731,11 +11731,8 @@ ada_has_this_exception_support (const struct exception_support_info *einfo) /* Make sure that the symbol we found corresponds to a function. */ if (sym->aclass () != LOC_BLOCK) - { - error (_("Symbol \"%s\" is not a function (class = %d)"), - sym->linkage_name (), sym->aclass ()); - return 0; - } + error (_("Symbol \"%s\" is not a function (class = %d)"), + sym->linkage_name (), sym->aclass ()); sym = standard_lookup (einfo->catch_handlers_sym, NULL, VAR_DOMAIN); if (sym == NULL) @@ -11754,11 +11751,8 @@ ada_has_this_exception_support (const struct exception_support_info *einfo) /* Make sure that the symbol we found corresponds to a function. */ if (sym->aclass () != LOC_BLOCK) - { - error (_("Symbol \"%s\" is not a function (class = %d)"), - sym->linkage_name (), sym->aclass ()); - return 0; - } + error (_("Symbol \"%s\" is not a function (class = %d)"), + sym->linkage_name (), sym->aclass ()); return 1; }