From patchwork Fri Feb 17 14:22:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 65185 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 81CE5385B515 for ; Fri, 17 Feb 2023 14:22:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 81CE5385B515 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1676643758; bh=FFkY5MoHFVrNKY39Nszcm9h+0V8UFCIUpiNejeKGPSA=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=XEGfSt0EhM6bnkqMrOkkR9WC+c5K8uDCffrSNVPdTi6xcQrGiYRw456TgAZ6pBJAe /gehhVP0Cv22495i0DbD146tL3SgiJ/aMkZim3BypOPdIud5fJhSnhpRIlol+DgJAw 3ii8ty0Yp1q35FjywVtiDLmXi6oTMTKmZK0Wjams= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id C6DC53858C31 for ; Fri, 17 Feb 2023 14:22:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C6DC53858C31 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C1EED1FFA0; Fri, 17 Feb 2023 14:22:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A93E413274; Fri, 17 Feb 2023 14:22:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GYQzKJSN72NzGwAAMHmgww (envelope-from ); Fri, 17 Feb 2023 14:22:12 +0000 To: gdb-patches@sourceware.org Cc: "Markus T . Metzger" Subject: [PATCH] [gdb/testsuite] Add xfail case in gdb.python/py-record-btrace.exp Date: Fri, 17 Feb 2023 15:22:13 +0100 Message-Id: <20230217142213.7147-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom de Vries via Gdb-patches From: Tom de Vries Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" I came across: ... gdb) PASS: gdb.python/py-record-btrace.exp: prepare record: stepi 100 python insn = r.instruction_history^M warning: Non-contiguous trace at instruction 1 (offset = 0x3e10).^M (gdb) FAIL: gdb.python/py-record-btrace.exp: prepare record: python insn = r.i\ nstruction_history ... I'm assuming it's the same root cause as for the already present XFAIL. Fix this by recognizing above warning in the xfail regexp. Tested on x86_64-linux, although sofar I was not able to trigger the warning again. --- gdb/testsuite/gdb.python/py-record-btrace.exp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) base-commit: ccd87ffec78506220973b84f4f2b48137a9ef408 diff --git a/gdb/testsuite/gdb.python/py-record-btrace.exp b/gdb/testsuite/gdb.python/py-record-btrace.exp index c055a882f85..703db0ce8e1 100644 --- a/gdb/testsuite/gdb.python/py-record-btrace.exp +++ b/gdb/testsuite/gdb.python/py-record-btrace.exp @@ -76,6 +76,11 @@ with_test_prefix "prepare record" { "warning: Decode error \\($nonl_re*\\) at instruction $decimal" \ "\\(offset = $hex, pc = $hex\\):" \ "$nonl_re*\\."]] + set xfail_re_2 \ + [join \ + [list \ + "warning: Non-contiguous trace at instruction $decimal" \ + "\\(offset = $hex\\)\\."]] set got_xfail 0 set cmd "python insn = r.instruction_history" @@ -83,7 +88,7 @@ with_test_prefix "prepare record" { -re "^[string_to_regexp $cmd]\r\n$::gdb_prompt $" { pass $gdb_test_name } - -re -wrap "$xfail_re" { + -re -wrap "($xfail_re|$xfail_re_2)" { if { $have_xfail } { xfail $gdb_test_name set got_xfail 1