diff mbox series

Remove exception_catchpoint::resources_needed

Message ID 20230216172624.2238588-1-tromey@adacore.com
State Committed
Commit c52e4861c61926a1e22e56837487b819e2dc3cc8
Headers
Series Remove exception_catchpoint::resources_needed |

Commit Message

Tom Tromey Feb. 16, 2023, 5:26 p.m. UTC 
  exception_catchpoint::resources_needed has a FIXME comment that I
think makes this method obsolete.  Also, I note that similar
catchpoints, for example Ada catchpoints, don't have this method.
This patch removes the method.  Regression tested on x86-64 Fedora 36.
---
 gdb/break-catch-throw.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Tom Tromey March 6, 2023, 3:09 p.m. UTC | #1 
>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> exception_catchpoint::resources_needed has a FIXME comment that I
Tom> think makes this method obsolete.  Also, I note that similar
Tom> catchpoints, for example Ada catchpoints, don't have this method.
Tom> This patch removes the method.  Regression tested on x86-64 Fedora 36.

I'm checking this in.

Tom
diff mbox series

Patch

diff --git a/gdb/break-catch-throw.c b/gdb/break-catch-throw.c
index ab7899e2b9c..457446efbc6 100644
--- a/gdb/break-catch-throw.c
+++ b/gdb/break-catch-throw.c
@@ -94,13 +94,6 @@  struct exception_catchpoint : public code_breakpoint
   void check_status (struct bpstat *bs) override;
   struct bp_location *allocate_location () override;
 
-  /* FIXME this is temporary - until ordinary breakpoints have been
-     converted.  */
-  int resources_needed (const struct bp_location *) override
-  {
-    return 1;
-  }
-
   /* The kind of exception catchpoint.  */
 
   enum exception_event_kind kind;