diff mbox series

[v3,35/50] Fully qualify calls to copy in value.c

Message ID	20230209-submit-value-fixups-2023-v3-35-45e91a20c742@tromey.com
State	Committed
Commit	e18312bb596fcc9b4df1d018038690df28a68b46
Headers	DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB0A83858404 From: Tom Tromey <tom@tromey.com> Date: Sun, 12 Feb 2023 20:15:51 -0700 Subject: [PATCH v3 35/50] Fully qualify calls to copy in value.c MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230209-submit-value-fixups-2023-v3-35-45e91a20c742@tromey.com> References: <20230209-submit-value-fixups-2023-v3-0-45e91a20c742@tromey.com> In-Reply-To: <20230209-submit-value-fixups-2023-v3-0-45e91a20c742@tromey.com> To: gdb-patches@sourceware.org Cc: Simon Marchi <simon.marchi@efficios.com> Precedence: list Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org>
Series	Use methods for struct value \| [v3,00/50] Use methods for struct value [v3,01/50] Automatic date update in version.in [v3,02/50] Rename all fields of struct value [v3,03/50] Move ~value body out-of-line [v3,04/50] Move struct value to value.h [v3,05/50] Turn value_type into method [v3,06/50] Turn deprecated_set_value_type into a method [v3,07/50] Turn value_arch into method [v3,08/50] Turn value_bitsize into method [v3,09/50] Turn value_bitpos into method [v3,10/50] Turn value_parent into method [v3,11/50] Turn value_offset into method [v3,12/50] Turn deprecated_value_modifiable into method [v3,13/50] Turn value_enclosing_type into method [v3,14/50] Turn some value offset functions into method [v3,15/50] Turn value_lazy and set_value_lazy functions into methods [v3,16/50] Turn value_stack and set_value_stack functions into methods [v3,17/50] Turn value_computed_closure and value_computed_funcs functions into methods [v3,18/50] Convert value_lval_const and deprecated_lval_hack to methods [v3,19/50] Turn value_initialized and set_value_initialized functions into methods [v3,20/50] Turn value_address and set_value_address functions into methods [v3,21/50] Turn more deprecated_* functions into methods [v3,22/50] Turn allocate_value_lazy into a static "constructor" [v3,23/50] Turn allocate_value into a static "constructor" [v3,24/50] Turn allocate_computed_value into static "constructor" [v3,25/50] Turn allocate_optimized_out_value into static "constructor" [v3,26/50] Turn value_zero into static "constructor" [v3,27/50] Turn some value_contents functions into methods [v3,28/50] Turn value_fetch_lazy into a method [v3,29/50] Turn allocate_value_contents into a method [v3,30/50] Turn value_contents_eq into a method [v3,31/50] Turn value_bits_synthetic_pointer into a method [v3,32/50] Move value_ref_policy methods out-of-line [v3,33/50] Turn value_incref and value_decref into methods [v3,34/50] Turn remaining value_contents functions into methods [v3,35/50] Fully qualify calls to copy in value.c [v3,36/50] Turn value_copy into a method [v3,37/50] Turn many optimized-out value functions into methods [v3,38/50] Turn value_non_lval and value_force_lval into methods [v3,39/50] Turn set_value_component_location into method [v3,40/50] Change some code to use value methods [v3,41/50] Turn some xmethod functions into methods [v3,42/50] Turn preserve_one_value into method [v3,43/50] Turn various value copying-related functions into methods [v3,44/50] Add value::set_modifiable [v3,45/50] Turn record_latest_value into a method [v3,46/50] Make struct value data members private [v3,47/50] Make ~value private [v3,48/50] Introduce set_lval method on value [v3,49/50] Remove deprecated_lval_hack

Commit Message

Tom Tromey Feb. 13, 2023, 3:15 a.m. UTC

  A coming patch will add value::copy, so this namespace-qualifies
existing calls to 'copy' in value.c, to ensure it will still compile
after that change is done.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
---
 gdb/value.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff mbox series

Patch

diff --git a/gdb/value.c b/gdb/value.c
index 23453e82ce5..804444221ba 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -1216,7 +1216,7 @@  value_contents_copy_raw (struct value *dst, LONGEST dst_offset,
   gdb::array_view<const gdb_byte> src_contents
     = src->contents_all_raw ().slice (src_offset * unit_size,
 					  length * unit_size);
-  copy (src_contents, dst_contents);
+  gdb::copy (src_contents, dst_contents);
 
   /* Copy the meta-data, adjusted.  */
   src_bit_offset = src_offset * unit_size * HOST_CHAR_BIT;
@@ -1562,7 +1562,7 @@  value_copy (const value *arg)
       gdb::array_view<gdb_byte> val_contents
 	= val->contents_all_raw ().slice (0, length);
 
-      copy (arg_view, val_contents);
+      gdb::copy (arg_view, val_contents);
     }
 
   if (VALUE_LVAL (val) == lval_computed)
@@ -1604,7 +1604,7 @@  value_non_lval (struct value *arg)
       struct type *enc_type = arg->enclosing_type ();
       struct value *val = value::allocate (enc_type);
 
-      copy (arg->contents_all (), val->contents_all_raw ());
+      gdb::copy (arg->contents_all (), val->contents_all_raw ());
       val->m_type = arg->m_type;
       val->set_embedded_offset (arg->embedded_offset ());
       val->set_pointed_to_offset (arg->pointed_to_offset ());