From patchwork Tue Feb 7 13:28:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lancelot SIX X-Patchwork-Id: 64448 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1ED31385B52C for ; Tue, 7 Feb 2023 13:29:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1ED31385B52C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675776547; bh=165XItic3Ljm688Z30Orn0lrbzYZNCAagn5zHRAMxiY=; h=To:CC:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=HqlrvrkKn5awLozoGqy3wM+nNsP9tRATOYHU+7CFPZaugtuTFBKSUCdjHadRnQWuh RwpCD0rNn5VZhFk4npLLjIoa8QZsirgkGW48q6eDMZoRyQzCjwFTnRrkT1HnciItIV NBU1ImnKxfIQXDnvCU0I86HV/ci3VSd1SyXBwlCM= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2045.outbound.protection.outlook.com [40.107.220.45]) by sourceware.org (Postfix) with ESMTPS id D1CBB3858D39 for ; Tue, 7 Feb 2023 13:28:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D1CBB3858D39 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aRiCLKff9+JE7MhnANtKkZfrDkXwM7F0ENHT67C0FTqU8QgRM3pPO33I5fOnd993sX60kElc+H6Dx8OtdTQpJoIl50swY4h/wIruskv68mYNqfOlCA6xXUhm9BKpB1kGEcDyRWTgRZwm3hChxStJD2K667gzwg4QMdysxuB/F55jbwQhsZZRibpzkC+Ci/3buWMKdWDEXCTOUEXD/lqfgJC7StwD2IDc66WAblPouSzyAIJNk74/UchbdSe4ZT2QmZulVHl4T+66D0LN3KywjGsSagbA4e99FrwfLCcq/7ctPKSmuJFqNtIb81fdVyVd2WJwWbSZDX9tdHKCJXIaww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=165XItic3Ljm688Z30Orn0lrbzYZNCAagn5zHRAMxiY=; b=nZzbpJvW9MvSqRDbRH0w+QG1m28DBltbXCgxXkyvbjuJV3lc4iG1JajOLlm5qAer17+c90KbSZd1kAixu9AbCI7aRbydt1x2JgwoXnAoj5U22OoInHV1YWl4zorUuxzklehl6C8Fqj8AnWYhyiDFk1K8Z3IWqCaRAPEXuTSOSbjz3N8NE4qz/vwHP3bSJY6qUsY5mj8AzbKEnIS7vnW7A6U3GmdCxUT+DQHTGTSA0pIz7JlJj+j7FSLvngIVqGHZsEHiGEaDCGV42DkqvX5um6XKSVhPWJJjwrOHZZhOkiW+ifKSpeMcpIh3vFCxfBhP7NZUZLh24sqfKaq60d9+uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none Received: from DM6PR11CA0030.namprd11.prod.outlook.com (2603:10b6:5:190::43) by PH8PR12MB7110.namprd12.prod.outlook.com (2603:10b6:510:22e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.32; Tue, 7 Feb 2023 13:28:33 +0000 Received: from DM6NAM11FT010.eop-nam11.prod.protection.outlook.com (2603:10b6:5:190:cafe::6b) by DM6PR11CA0030.outlook.office365.com (2603:10b6:5:190::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36 via Frontend Transport; Tue, 7 Feb 2023 13:28:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT010.mail.protection.outlook.com (10.13.172.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.16 via Frontend Transport; Tue, 7 Feb 2023 13:28:33 +0000 Received: from khazad-dum.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 7 Feb 2023 07:28:31 -0600 To: CC: , Lancelot SIX Subject: [PATCH 3/4] gdb/testsuite: require amd-dbgapi support to run rocm tests Date: Tue, 7 Feb 2023 13:28:01 +0000 Message-ID: <20230207132802.223510-4-lancelot.six@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207132802.223510-1-lancelot.six@amd.com> References: <20230207132802.223510-1-lancelot.six@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT010:EE_|PH8PR12MB7110:EE_ X-MS-Office365-Filtering-Correlation-Id: 6a59f4e1-fa79-4f56-30a4-08db090f35c2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e8HVpyU4khPaOYRA6z7Lz2MdkT3D7n9KcJrQHxcfdq1dV8l9QUVEe30aSiLfvE+lmhPCZFHkY+5spYFexTgbGh+fXYtYoVupzYPqfnwkW8g/Qau4FJbRZBj1pE3uAJ8nVRYeMIV1Vkz/K2YaC6jUJftvW/NjuEMQfp9XyHl5gE4Jb2GjrNs8HvJpOCREOfJrrkDH1y7tjXjidYSUiMMfQwiWrH4EGojnkvvtr/djoWjOdv5+3+ve3BagkiIYVoF9fWQ6bK9vHv4t3+GJkmV9wcSkkxi3tlxrior2SBtpxHarRYLtHg2I3wHDnXxB7EkGZkJ8lfSyYxdC2GgP11USpvXiEgCR+ciF7CWBQHgRXto3kVKQtwLYMBp4SFZeA3UE0ifBy6WwDEx0SRj4DX7TP0zeCQHv+xzu/IkmODlbNYVawDOsiD6aF8ldj0/Qvj5utLAPbSAxCUGj5ulUj8iZ/SrDVVRoA1Egh24AIaxKNisEfEYRbsfj5Woqy/pWq3/RV1dqzOoAl5xHrNqiQPABe72FvRxNOrrn/cq+9oSNs0EO04UCzGxghi0u3ivBrF44OEOYUOiWP0svAHw+r2AAOkHSj/z1gP9I7LW4FyoiuoNtgRewk8OG9H2RsRu7MVNPWUnct2yOhcyuTCwHYFTRjwnC33YyxKMaVGcZi886nBkOgbzHqWZI271uG0XLSkXjbzD149oou+yE4wn2r9ylFO9b1jP8XCyiqu1flDm2oNs= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230025)(4636009)(376002)(346002)(136003)(39860400002)(396003)(451199018)(40470700004)(46966006)(36840700001)(4326008)(426003)(82310400005)(54906003)(36860700001)(8676002)(5660300002)(40480700001)(41300700001)(8936002)(356005)(4744005)(86362001)(316002)(82740400003)(81166007)(16526019)(1076003)(47076005)(186003)(336012)(83380400001)(40460700003)(26005)(7696005)(2616005)(2906002)(36756003)(478600001)(70206006)(6666004)(70586007)(6916009)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 13:28:33.3354 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6a59f4e1-fa79-4f56-30a4-08db090f35c2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT010.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7110 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Lancelot SIX via Gdb-patches From: Lancelot SIX Reply-To: Lancelot SIX Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Update allow_hipcc_tests to check that GDB has the amd-dbgapi support built-in. Without this support, all tests using hipcc and the rocm stack will fail. --- gdb/testsuite/lib/rocm.exp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gdb/testsuite/lib/rocm.exp b/gdb/testsuite/lib/rocm.exp index 1440ac85d32..b5b59748c27 100644 --- a/gdb/testsuite/lib/rocm.exp +++ b/gdb/testsuite/lib/rocm.exp @@ -22,6 +22,13 @@ proc allow_hipcc_tests { } { if {[target_info gdb_protocol] != ""} { return 0 } + + # Ensure that GDB is built with amd-dbgapi support. + set output [remote_exec host $::GDB "$::INTERNAL_GDBFLAGS --configuration"] + if { [expr {[string first "--with-amd-dbgapi" $output] == -1}] } { + return 0 + } + return 1 }