From patchwork Tue Feb 7 13:28:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lancelot SIX X-Patchwork-Id: 64450 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 50A8B385840C for ; Tue, 7 Feb 2023 13:29:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 50A8B385840C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675776570; bh=q7mTO4EuVXGo/OFm6rX9KgorTaYbj3U5PEOS74iBr6E=; h=To:CC:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=AKs3loqVhvWqdkYuCuJO6Un6OXwRWFMI5SB2Q14leVUoX82mbC+Z0/Ley5kKmNLOm VqqpaKch0c1KsnQ28E8pWPgtp8QX/tfV+Ok3pqqaCqSf8mpfs6dj4s+Y7qHEa+tskC urx8+TOhK0YsE1uaM/DNv6mUzCDfI/5ibfGU5Lp4= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2052.outbound.protection.outlook.com [40.107.243.52]) by sourceware.org (Postfix) with ESMTPS id EA5FB3858D38 for ; Tue, 7 Feb 2023 13:28:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EA5FB3858D38 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ElWSbTCiOCyL5YD72R7VE+UbgQrjTrYRPTTju1WmkxGqZE88bB+5dXJxMewQPW8LnxtOqiF3mlFl1fKBC9nvAB7Bop6SBNgkbME/8lgwfm+23lX1UYNt9CUJNOofOT+HSZcdlcJyQTz6qwgTLXNVleXdgaO1bhJ9S7uM/Pj4rrerCRpaMjwx39wOidkAiTRb7hyZ68hTzr6+qWDB7utdqvRS9mt+YUGHGHEJ8Dlmy43pYEB8pI3BbEqtvv/SH3J1xySHYvwQAalaOKKuIMZ4OeIots0wnWFUqrCCITHTtM3WFGDXZ4nUEx+JHddyrajaqP/QHq145abo/dTVeDxwrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q7mTO4EuVXGo/OFm6rX9KgorTaYbj3U5PEOS74iBr6E=; b=oZhY1X41eHQ30cIpddG8ojYAFCIqz1V5XTDoGK7yVY+UJVjBtcGOERZ93hTzlWy74AoBREdTUHBMTWjuUpcFFhBU3a2Ty6yHvyJ23DajwhFgWAf5GcTWTckfvLkoy8g8KVIew25QHm9fEipJlHlsalxQ1GKAqnxsLBN98y1R1H24pxipv4F8OtJSxEZ3gFhq4se8ue4L3G5XP9FvMaRYL2oCtTYArZQiWeicVRacYLOaadkiaJ56fYjGeYG/lpJ/r0a/7ZC1nila1mKTsONoV/VnzecoOPcH0EMm5HC3mawkELRYz4CpPueI3oXQiXfzrmgobyUe50sIY9LoeNRbhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none Received: from DM6PR11CA0012.namprd11.prod.outlook.com (2603:10b6:5:190::25) by BN9PR12MB5177.namprd12.prod.outlook.com (2603:10b6:408:11a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Tue, 7 Feb 2023 13:28:32 +0000 Received: from DM6NAM11FT010.eop-nam11.prod.protection.outlook.com (2603:10b6:5:190:cafe::ee) by DM6PR11CA0012.outlook.office365.com (2603:10b6:5:190::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36 via Frontend Transport; Tue, 7 Feb 2023 13:28:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT010.mail.protection.outlook.com (10.13.172.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.16 via Frontend Transport; Tue, 7 Feb 2023 13:28:32 +0000 Received: from khazad-dum.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 7 Feb 2023 07:28:30 -0600 To: CC: , Lancelot SIX Subject: [PATCH 2/4] gdb/testsuite: Rename skip_hipcc_tests to allow_hipcc_tests Date: Tue, 7 Feb 2023 13:28:00 +0000 Message-ID: <20230207132802.223510-3-lancelot.six@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207132802.223510-1-lancelot.six@amd.com> References: <20230207132802.223510-1-lancelot.six@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT010:EE_|BN9PR12MB5177:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ca38435-0635-41a0-c483-08db090f3530 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jNdWVozqTGbYMdiGhm8YiwY3Ui3fjGrm3fPiNTA6CWDNuA3+D2Wy7s/wfco1xk3FO7YeHMw0OxhndLs1mhE0JJTAh00J6D+yM9aD5MLvjTcDy9Xwu2wcecdWGDV+OnwqAJWhfMXZZ162GhX6OE2pj8prgslDoM2wlnJYsc7lyFHuJce64jyN7Wwio2+I3AV7M2Rj0js5kQoS7wulAmJDHtLcg3Z72iQMQtiQHdcGeECxyvH2UYVDtU1Aalv35exNPpaUEMXocWbpx9jMhxS6Jhp0FqpwCy8vXX5mO0ApVyujEBN9b1fjFjXFKCpmEm0op0esPe4n6ioEjdbrCcyrSFNx07wdTxSgU5qouy3kQ96EYvWTNjUz87I42F986AHN68NAz0933+NLuuWVTRRrN0EcCFNx/0kwJQlEyl3Ydcp2pf1+AUjH/wjhMVjy5pFtFXVpJzkNEB43+ZFNAuaAyBZoC4aoCtPpKXnnmo5Szauq7SH/4kGm6i7nu1GPouNjBaoQiEXeWtLml3RjkoUaVdRC7WIMUEsEuXkYIBX8dXJh6Cs2v7u0n+tWdEh1HTEmj3o5/JbQFJv1gZPdcAYcAQZKHyKV+aga4zBiIun5IDShjUInjJemTlG6nnFdQQcX+6W2A2cg2iaiZarAMoxgrUG4UB7ebE006m6qlU6qiLVzFNYWdUbtWONOVUeVb40AiFyzN3vVphWvv7OhU+nhbEcBUgMb9GWx+0SST6AHrP888/2Ytt2EUtTXuvOCsdnCCC/IRHYWVReS/83tI9VtxA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230025)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199018)(40470700004)(46966006)(36840700001)(40460700003)(4326008)(82740400003)(81166007)(316002)(356005)(8936002)(8676002)(41300700001)(6916009)(70586007)(70206006)(2906002)(36860700001)(5660300002)(2616005)(1076003)(6666004)(26005)(16526019)(478600001)(186003)(82310400005)(86362001)(83380400001)(54906003)(426003)(47076005)(336012)(7696005)(40480700001)(36756003)(84970400001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 13:28:32.3823 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ca38435-0635-41a0-c483-08db090f3530 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT010.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5177 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Lancelot SIX via Gdb-patches From: Lancelot SIX Reply-To: Lancelot SIX Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Rename skip_hipcc_tests to allow_hipcc_tests so it can be used as a "require" predicate in tests. Use require in gdb.rocm/simple.exp. --- gdb/testsuite/gdb.rocm/simple.exp | 5 +---- gdb/testsuite/lib/rocm.exp | 6 +++--- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/gdb/testsuite/gdb.rocm/simple.exp b/gdb/testsuite/gdb.rocm/simple.exp index f84df71414e..befcc7aaabc 100644 --- a/gdb/testsuite/gdb.rocm/simple.exp +++ b/gdb/testsuite/gdb.rocm/simple.exp @@ -20,10 +20,7 @@ load_lib rocm.exp standard_testfile .cpp -if [skip_hipcc_tests] { - verbose "skipping hip test: ${testfile}" - return -} +require allow_hipcc_tests if {[build_executable "failed to prepare" $testfile $srcfile {debug hip}]} { return diff --git a/gdb/testsuite/lib/rocm.exp b/gdb/testsuite/lib/rocm.exp index e22f392deb1..1440ac85d32 100644 --- a/gdb/testsuite/lib/rocm.exp +++ b/gdb/testsuite/lib/rocm.exp @@ -15,14 +15,14 @@ # # Support library for testing ROCm (AMD GPU) GDB features. -proc skip_hipcc_tests { } { +proc allow_hipcc_tests { } { # Only the native target supports ROCm debugging. E.g., when # testing against GDBserver, there's no point in running the ROCm # tests. if {[target_info gdb_protocol] != ""} { - return 1 + return 0 } - return 0 + return 1 } # The lock file used to ensure that only one GDB has access to the GPU