From patchwork Tue Feb 7 10:42:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 64438 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 62CE33858404 for ; Tue, 7 Feb 2023 10:42:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 62CE33858404 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675766549; bh=q3tARzjx9jJ4WHKWsenKbTmngay/98L5p4Vwt/rPZ5E=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Vz/bl6Jo9Y7ZyCwWXFdMe1GdZD86isaXInwWhkTKwPEnFm37tstNQ6yONNEaDT7nO 7o3OxxGIx97bvylRZbBr13fbiHB8TIygivsbWHjmQOU7+wC5gUbrh7D8lbffhfCdy/ 86ukaQ8iDPmFVRjlb0RsLH49gN7Npe9GeKCEpe/s= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 70F993858D33 for ; Tue, 7 Feb 2023 10:42:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 70F993858D33 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9CB812090C for ; Tue, 7 Feb 2023 10:42:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8883313467 for ; Tue, 7 Feb 2023 10:42:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WB4mIP0q4mOYKQAAMHmgww (envelope-from ) for ; Tue, 07 Feb 2023 10:42:05 +0000 To: gdb-patches@sourceware.org Subject: [pushed] [gdb/testsuite] Improve untested message in gdb.ada/finish-var-size.exp Date: Tue, 7 Feb 2023 11:42:05 +0100 Message-Id: <20230207104205.25747-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom de Vries via Gdb-patches From: Tom de Vries Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" I came across: ... UNTESTED: gdb.ada/finish-var-size.exp: GCC too told for this test ... The message only tells us that the compiler version too old, not what compiler version is required. Fix this by rewriting using required: ... UNSUPPORTED: gdb.ada/finish-var-size.exp: require failed: \ expr [gcc_major_version] >= 12 ... Tested on x86_64-linux. --- gdb/testsuite/gdb.ada/finish-var-size.exp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) base-commit: e7a881b9d49f16bd901dba53006c48a8bfd115df diff --git a/gdb/testsuite/gdb.ada/finish-var-size.exp b/gdb/testsuite/gdb.ada/finish-var-size.exp index c1cf6406433..5865be249a0 100644 --- a/gdb/testsuite/gdb.ada/finish-var-size.exp +++ b/gdb/testsuite/gdb.ada/finish-var-size.exp @@ -18,10 +18,7 @@ load_lib "ada.exp" require allow_ada_tests # GCC 12 has the needed fix. -if {![test_compiler_info {gcc-1[2-9]-*}]} { - untested "GCC too told for this test" - return -1 -} +require {expr [gcc_major_version] >= 12} standard_ada_testfile p