diff mbox series

[04/27] Remove some dead code in gdb.fortran/info-types.exp

Message ID	20230125224614.1006886-5-tom@tromey.com
State	Committed
Headers	DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EE0CB3858C53 From: Tom Tromey <tom@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey <tom@tromey.com> Subject: [PATCH 04/27] Remove some dead code in gdb.fortran/info-types.exp Date: Wed, 25 Jan 2023 15:45:51 -0700 Message-Id: <20230125224614.1006886-5-tom@tromey.com> In-Reply-To: <20230125224614.1006886-1-tom@tromey.com> References: <20230125224614.1006886-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org>
Series	Many small testsuite cleanups \| [00/27] Many small testsuite cleanups [01/27] Use ordinary calling convention for clean_restart [02/27] Use clean_restart in gdb.dlang [03/27] Eliminate spurious returns from the test suite [04/27] Remove some dead code in gdb.fortran/info-types.exp [05/27] Minor "require" fixups [06/27] Remove unnecessary call to standard_testfile [07/27] Start gdb after building executable in mi-basics.exp [08/27] Use mi_clean_restart more [09/27] Use clean_restart in gdb.pascal [10/27] Use clean_restart in gdb.linespec [11/27] Use clean_restart in gdb.opencl [12/27] Use clean_restart in gdb.trace [13/27] Use clean_restart in gdb.objc [14/27] Use clean_restart in gdb.threads [15/27] Use clean_restart in gdb.guile [16/27] Use clean_restart in gdb.arch [17/27] Use clean_restart in gdb.reverse [18/27] Use clean_restart in gdb.dwarf2 [19/27] Use clean_restart in gdb.ada [20/27] Use clean_restart in gdb.fortran [21/27] Use clean_restart in gdb.stabs [22/27] Use clean_restart in gdb.go [23/27] Use clean_restart in gdb.perf [24/27] Use clean_restart in gdb.disasm [25/27] Use clean_restart in gdb.cp [26/27] Use clean_restart in gdb.python [27/27] Use clean_restart in gdb.base

Commit Message

Tom Tromey Jan. 25, 2023, 10:45 p.m. UTC

  An early "return" in this test case prevents a test from running.
This seems to have been intentional and has been in place since:

commit d57cbee932f86df06251498daa93154046dc77c0
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Date:   Tue Dec 3 13:18:43 2019 +0000

    gdb/testsuite/fortran: Fix info-modules/info-types for gfortran 8+

This patch removes the dead code.
---
 gdb/testsuite/gdb.fortran/info-types.exp | 17 -----------------
 1 file changed, 17 deletions(-)

diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.fortran/info-types.exp b/gdb/testsuite/gdb.fortran/info-types.exp
index 98fb812dd8b..8cd9a2ae6cb 100644
--- a/gdb/testsuite/gdb.fortran/info-types.exp
+++ b/gdb/testsuite/gdb.fortran/info-types.exp
@@ -61,20 +61,3 @@  if { [test_compiler_info {gfortran-*} f90] } {
     setup_xfail *-*-* gcc/105454
     GDBInfoSymbols::check_entry "${srcfile}" "41" "Type s1;"
 }
-
-return 0
-
-gdb_test "info types" \
-    [multi_line \
-	 "All defined types:" \
-	 "" \
-	 "File .*:" \
-	 "\[\t \]+${character1}" \
-	 "\[\t \]+${integer4}" \
-	 "(\[\t \]+${integer8}" \
-	 ")?\[\t \]+${logical4}" \
-	 "(35:\[\t \]+Type __vtype_mod1_M1t1;" \
-	 ")?$decimal:\[\t \]+Type m1t1;" \
-	 "\[\t \]+${real4}" \
-	 "41:\[\t \]+Type s1;(" \
-	 ".*)?"]