From patchwork Wed Jan 25 21:27:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mark Wielaard X-Patchwork-Id: 63696 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E62A93858D38 for ; Wed, 25 Jan 2023 21:28:08 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from csb.redhat.com (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id A79423858D28 for ; Wed, 25 Jan 2023 21:27:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A79423858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: by csb.redhat.com (Postfix, from userid 10916) id 77F90CF2C7; Wed, 25 Jan 2023 22:27:53 +0100 (CET) From: Mark Wielaard To: gdb-patches@sourceware.org Cc: Simon Marchi , Sam James , Tom Tromey , John Baldwin , Hannes Domani , Mark Wielaard Subject: [PATCH] gdb: Replace memcpy with std::copy to avoid some g++ warnings on sparc Date: Wed, 25 Jan 2023 22:27:46 +0100 Message-Id: <20230125212746.994955-1-mark@klomp.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3037.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEXHASH_WORD, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" For some reason g++ 12.2.1 on sparc produces spurious warnings for stringop-overread and restrict in fbsd-tdep.c for a memcpy call. Use std::copy to avoid the warnings: In function ‘void* memcpy(void*, const void*, size_t)’, inlined from ‘gdb::optional > > > fbsd_make_note_desc(target_object, uint32_t)’ at ../../binutils-gdb/gdb/fbsd-tdep.c:666:10: /usr/include/bits/string_fortified.h:29:33: error: ‘void* __builtin_memcpy(void*, const void*, long unsigned int)’ specified bound 18446744073709551612 exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=] In function ‘void* memcpy(void*, const void*, size_t)’, inlined from ‘gdb::optional > > > fbsd_make_note_desc(target_object, uint32_t)’ at ../../binutils-gdb/gdb/fbsd-tdep.c:673:10: /usr/include/bits/string_fortified.h:29:33: error: ‘void* __builtin_memcpy(void*, const void*, long unsigned int)’ accessing 18446744073709551612 bytes at offsets 0 and 0 overlaps 9223372036854775801 bytes at offset -9223372036854775805 [-Werror=restrict] gdb/ChangeLog: * fbsd-tdep.c (fbsd_make_note_desc): Use std::copy instead of memcpy. --- V6: Only use std::copy for the second memcpy V5: Use buf->begin (), buf->end () in second std::copy V4: Fix std::copy argument typo V3: Drop diagnostic suppressions just use std::copy V2: Fix typos and add example errors to commit messages gdb/fbsd-tdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/fbsd-tdep.c b/gdb/fbsd-tdep.c index 203390d9880..3a7cb9b14ea 100644 --- a/gdb/fbsd-tdep.c +++ b/gdb/fbsd-tdep.c @@ -663,7 +663,7 @@ fbsd_make_note_desc (enum target_object object, uint32_t structsize) gdb::byte_vector desc (sizeof (structsize) + buf->size ()); memcpy (desc.data (), &structsize, sizeof (structsize)); - memcpy (desc.data () + sizeof (structsize), buf->data (), buf->size ()); + std::copy (buf->begin (), buf->end (), desc.data () + sizeof (structsize)); return desc; }