Message ID | 20230123075939.1771-1-tdevries@suse.de |
---|---|
State | Committed |
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C84083858C74 for <patchwork@sourceware.org>; Mon, 23 Jan 2023 08:00:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C84083858C74 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674460803; bh=Cfl1rofNa/ohM6JSQ0rPYLyAqywBor7s75QSNYA9Xp0=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=vykXUz0AS9qVl+jLDBlA9YG5S8a0PPAt50xp8oq9aX/SzIZI3tH4P45Msjb1j6o8y UGp0sSX+au4ioSlxVZRhrRRS0PF8Q40VgXiEIrRpzzHC58y6/m4bfJhaMXNYx+NWmf nkAlFtXinB0NLWt4nz6KYKt9uk84ZcBG00+XK4pI= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 8BAD23858D32 for <gdb-patches@sourceware.org>; Mon, 23 Jan 2023 07:59:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8BAD23858D32 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 74A691F385 for <gdb-patches@sourceware.org>; Mon, 23 Jan 2023 07:59:40 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 62975134F5 for <gdb-patches@sourceware.org>; Mon, 23 Jan 2023 07:59:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Yb/0Fmw+zmOLRAAAMHmgww (envelope-from <tdevries@suse.de>) for <gdb-patches@sourceware.org>; Mon, 23 Jan 2023 07:59:40 +0000 To: gdb-patches@sourceware.org Subject: [pushed] [gdb/testsuite] Fix untested in gdb.base/frame-view.exp Date: Mon, 23 Jan 2023 08:59:39 +0100 Message-Id: <20230123075939.1771-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> From: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> Reply-To: Tom de Vries <tdevries@suse.de> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
[pushed,gdb/testsuite] Fix untested in gdb.base/frame-view.exp
|
|
Commit Message
Tom de Vries
Jan. 23, 2023, 7:59 a.m. UTC
When running test-case gdb.base/frame-view.exp, I see: ... gdb compile failed, ld: frame-view0.o: in function `main': frame-view.c:73: undefined reference to `pthread_create' ld: frame-view.c:76: undefined reference to `pthread_join' collect2: error: ld returned 1 exit status UNTESTED: gdb.base/frame-view.exp: failed to prepare ... Fix this by adding pthreads to the compilation flags. Tested on x86_64-linux. --- gdb/testsuite/gdb.base/frame-view.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 7e538762c2c1f2e5c4be31b9ec7d99cc4fbabf7f
Comments
On 1/23/23 02:59, Tom de Vries via Gdb-patches wrote: > When running test-case gdb.base/frame-view.exp, I see: > ... > gdb compile failed, ld: frame-view0.o: in function `main': > frame-view.c:73: undefined reference to `pthread_create' > ld: frame-view.c:76: undefined reference to `pthread_join' > collect2: error: ld returned 1 exit status > UNTESTED: gdb.base/frame-view.exp: failed to prepare > ... > > Fix this by adding pthreads to the compilation flags. Thanks for fixing this. I suppose it worked on my machines because they use newer glibcs where pthread is integrated into libc? Simon
On 1/23/23 17:12, Simon Marchi wrote: > > > On 1/23/23 02:59, Tom de Vries via Gdb-patches wrote: >> When running test-case gdb.base/frame-view.exp, I see: >> ... >> gdb compile failed, ld: frame-view0.o: in function `main': >> frame-view.c:73: undefined reference to `pthread_create' >> ld: frame-view.c:76: undefined reference to `pthread_join' >> collect2: error: ld returned 1 exit status >> UNTESTED: gdb.base/frame-view.exp: failed to prepare >> ... >> >> Fix this by adding pthreads to the compilation flags. > > Thanks for fixing this. I suppose it worked on my machines because they > use newer glibcs where pthread is integrated into libc? Np, and ack, that's also what I suppose what happened. Thanks, - Tom
diff --git a/gdb/testsuite/gdb.base/frame-view.exp b/gdb/testsuite/gdb.base/frame-view.exp index edae16735ab..72955bd1aff 100644 --- a/gdb/testsuite/gdb.base/frame-view.exp +++ b/gdb/testsuite/gdb.base/frame-view.exp @@ -18,7 +18,7 @@ standard_testfile if { [build_executable "failed to prepare" \ - ${testfile} ${srcfile}] } { + ${testfile} ${srcfile} {debug pthreads}] } { return }