From patchwork Sun Jan 22 21:55:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 63567 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 92DE03857007 for ; Sun, 22 Jan 2023 21:56:47 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 5F4263858C50 for ; Sun, 22 Jan 2023 21:56:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5F4263858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id D147F1003FBD7 for ; Sun, 22 Jan 2023 21:56:11 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id JiJvp5U8mNX2aJiJvpsidB; Sun, 22 Jan 2023 21:56:11 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=63cdb0fb a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=0F0erh2C4RPssITTzoYA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hKJKKXlpOrR9wavirRRQzqrJUxS9g9ARrMvPjEds9OU=; b=P8lSpPCHU1mVqPBBUbz02Kt2Lg IqadFkalqvNMIiLFqfywBAFdroLe3pZSyJjMemCUqlmkfNuEhMiawBnPyMrMGO4iPkh/TARTT9xP0 GodGKpn4xk2ffOj5ECJOR/xq0; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:55760 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pJiJv-003faM-Gk; Sun, 22 Jan 2023 14:56:11 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 7/8] Add unsupported calls where needed Date: Sun, 22 Jan 2023 14:55:57 -0700 Message-Id: <20230122215558.1931803-8-tom@tromey.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230122215558.1931803-1-tom@tromey.com> References: <20230122215558.1931803-1-tom@tromey.com> MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pJiJv-003faM-Gk X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (localhost.localdomain) [97.122.76.186]:55760 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" A number of tests will exit early without saying why. This patch adds "unsupported" at spots like this that I could readily find. There are definitely more of these; for example dw2-ranges.exp fails silently because a compilation fails. I didn't attempt to address these as that is a much larger task. --- gdb/testsuite/gdb.arch/pa-nullify.exp | 2 +- gdb/testsuite/gdb.arch/powerpc-trap.exp | 2 +- gdb/testsuite/gdb.base/remote.exp | 1 + gdb/testsuite/gdb.base/solib-disc.exp | 1 + gdb/testsuite/gdb.dwarf2/implptr.exp | 1 + gdb/testsuite/gdb.server/extended-remote-restart.exp | 2 ++ gdb/testsuite/gdb.threads/reconnect-signal.exp | 1 + gdb/testsuite/gdb.trace/stap-trace.exp | 1 + 8 files changed, 9 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.arch/pa-nullify.exp b/gdb/testsuite/gdb.arch/pa-nullify.exp index 4686ed29209..285047cc95f 100644 --- a/gdb/testsuite/gdb.arch/pa-nullify.exp +++ b/gdb/testsuite/gdb.arch/pa-nullify.exp @@ -26,7 +26,7 @@ switch -glob -- [istarget] { set testfile "pa64-nullify" } "*" { - verbose "Skipping hppa nullification tests." + unsupported "Skipping hppa nullification tests." return } } diff --git a/gdb/testsuite/gdb.arch/powerpc-trap.exp b/gdb/testsuite/gdb.arch/powerpc-trap.exp index a1739f33c43..f197b1ab56b 100644 --- a/gdb/testsuite/gdb.arch/powerpc-trap.exp +++ b/gdb/testsuite/gdb.arch/powerpc-trap.exp @@ -29,7 +29,7 @@ if { [istarget powerpc-*] } { # with the source file powerpc64-trap.s. set expected_traps 5 } else { - verbose "Skipping ${gdb_test_file_name}." + unsupported "Skipping powerpc-specific tests" return } diff --git a/gdb/testsuite/gdb.base/remote.exp b/gdb/testsuite/gdb.base/remote.exp index 1ce27e8a958..a1c9973b802 100644 --- a/gdb/testsuite/gdb.base/remote.exp +++ b/gdb/testsuite/gdb.base/remote.exp @@ -16,6 +16,7 @@ # Test only on boards that actually use the remote protocol. if {[target_info gdb_protocol] != "remote" && [target_info gdb_protocol] != "extended-remote"} { + unsupported "requires remote protocol" return } diff --git a/gdb/testsuite/gdb.base/solib-disc.exp b/gdb/testsuite/gdb.base/solib-disc.exp index 0e3acfce954..46b11dc768b 100644 --- a/gdb/testsuite/gdb.base/solib-disc.exp +++ b/gdb/testsuite/gdb.base/solib-disc.exp @@ -19,6 +19,7 @@ require allow_shlib_tests set gdbserver_reconnect_p 1 if { [info proc gdb_reconnect] == "" } { + unsupported "requires gdbserver reconnect" return 0 } diff --git a/gdb/testsuite/gdb.dwarf2/implptr.exp b/gdb/testsuite/gdb.dwarf2/implptr.exp index a309994ecff..70d86ddf19a 100644 --- a/gdb/testsuite/gdb.dwarf2/implptr.exp +++ b/gdb/testsuite/gdb.dwarf2/implptr.exp @@ -29,6 +29,7 @@ if [info exists COMPILE] { lappend opts debug optimize=-O2 } elseif {![is_x86_like_target]} { # This test can only be run on x86 targets. + unsupported "needs x86-like target" return 0 } diff --git a/gdb/testsuite/gdb.server/extended-remote-restart.exp b/gdb/testsuite/gdb.server/extended-remote-restart.exp index 8d3b384f348..b9eb2a69573 100644 --- a/gdb/testsuite/gdb.server/extended-remote-restart.exp +++ b/gdb/testsuite/gdb.server/extended-remote-restart.exp @@ -30,6 +30,7 @@ # This test is only for extended remote targets. if {[target_info gdb_protocol] != "extended-remote"} { + unsupported "requires extended-remote" return } @@ -40,6 +41,7 @@ require {is_any_target "*-*-linux*" "*-*-openbsd*"} # And we need to be able to reconnect to gdbserver. set gdbserver_reconnect_p 1 if { [info proc gdb_reconnect] == "" } { + unsupported "requires gdbserver reconnect" return 0 } diff --git a/gdb/testsuite/gdb.threads/reconnect-signal.exp b/gdb/testsuite/gdb.threads/reconnect-signal.exp index bec68e62c91..dbc7d7d7806 100644 --- a/gdb/testsuite/gdb.threads/reconnect-signal.exp +++ b/gdb/testsuite/gdb.threads/reconnect-signal.exp @@ -17,6 +17,7 @@ set gdbserver_reconnect_p 1 if { [info proc gdb_reconnect] == "" } { + unsupported "requires gdbserver reconnect" return 0 } diff --git a/gdb/testsuite/gdb.trace/stap-trace.exp b/gdb/testsuite/gdb.trace/stap-trace.exp index 34122737d20..39c2fa02ca1 100644 --- a/gdb/testsuite/gdb.trace/stap-trace.exp +++ b/gdb/testsuite/gdb.trace/stap-trace.exp @@ -115,6 +115,7 @@ if { ![runto_main] } { if { ![gdb_target_supports_trace] } { # Test cannot run on this target. + unsupported "test requires trace" return 1 }