From patchwork Sun Jan 22 21:55:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 63568 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B59CD3853573 for ; Sun, 22 Jan 2023 21:56:49 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 6849B3858D3C for ; Sun, 22 Jan 2023 21:56:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6849B3858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id D8AD8100471C5 for ; Sun, 22 Jan 2023 21:56:10 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id JiJupkK74vm7MJiJupM34W; Sun, 22 Jan 2023 21:56:10 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=T4lJ89GQ c=1 sm=1 tr=0 ts=63cdb0fa a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=l_918p7Os8p5NCmjfqkA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qyN6wayUp3UnjdiNeNqgZk78yX3dJz/QFLfk0rHR+7I=; b=vTDrRCh2zUj6JjWPsA9Lb16lT6 4SiYl+3AFc9PxfNfa0xxaBrDhMKfYF0qeTO1MvVtO5es1jxxmWUSV9Gv0htSGT5I08d/Fbm5cyn74 BE0Wcnisw4n6g8CBcjgjNFHC2; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:55760 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pJiJu-003faM-KX; Sun, 22 Jan 2023 14:56:10 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 4/8] Rename skip_vsx_tests to allow form Date: Sun, 22 Jan 2023 14:55:54 -0700 Message-Id: <20230122215558.1931803-5-tom@tromey.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230122215558.1931803-1-tom@tromey.com> References: <20230122215558.1931803-1-tom@tromey.com> MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pJiJu-003faM-KX X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (localhost.localdomain) [97.122.76.186]:55760 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" This renames skip_vsx_tests to allow_vsx_tests and updates it users to use require. --- gdb/testsuite/gdb.arch/powerpc-vsx-gcore.exp | 5 +--- gdb/testsuite/gdb.arch/vsx-regs.exp | 5 +--- gdb/testsuite/gdb.arch/vsx-vsr-float28.exp | 6 +---- gdb/testsuite/lib/gdb.exp | 28 ++++++++++---------- 4 files changed, 17 insertions(+), 27 deletions(-) diff --git a/gdb/testsuite/gdb.arch/powerpc-vsx-gcore.exp b/gdb/testsuite/gdb.arch/powerpc-vsx-gcore.exp index 69789998ea2..8ea773ccaee 100644 --- a/gdb/testsuite/gdb.arch/powerpc-vsx-gcore.exp +++ b/gdb/testsuite/gdb.arch/powerpc-vsx-gcore.exp @@ -18,10 +18,7 @@ # This test checks that generating and loading a core file preserves # the correct VSX register state. -if {![istarget "powerpc*-*-linux*"] || [skip_vsx_tests]} { - verbose "Skipping PowerPC test for corefiles with VSX registers." - return -} +require {istarget "powerpc*-*-linux*"} allow_vsx_tests standard_testfile .c diff --git a/gdb/testsuite/gdb.arch/vsx-regs.exp b/gdb/testsuite/gdb.arch/vsx-regs.exp index b3a120e8188..2b72a012ef9 100644 --- a/gdb/testsuite/gdb.arch/vsx-regs.exp +++ b/gdb/testsuite/gdb.arch/vsx-regs.exp @@ -19,10 +19,7 @@ # -if {![istarget "powerpc*"] || [skip_vsx_tests]} { - verbose "Skipping vsx register tests." - return -} +require {istarget "powerpc*"} allow_vsx_tests standard_testfile diff --git a/gdb/testsuite/gdb.arch/vsx-vsr-float28.exp b/gdb/testsuite/gdb.arch/vsx-vsr-float28.exp index 296a7420f61..4f831d5c9fd 100644 --- a/gdb/testsuite/gdb.arch/vsx-vsr-float28.exp +++ b/gdb/testsuite/gdb.arch/vsx-vsr-float28.exp @@ -18,11 +18,7 @@ # Test the vsr registers print values in float128 bit format. # - -if {![istarget "powerpc*"] || [skip_vsx_tests]} { - verbose "Skipping vsr float128 field tests." - return -} +require {istarget "powerpc*"} allow_vsx_tests standard_testfile diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 5425ae74cb9..4b8337dbc1c 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -3571,19 +3571,19 @@ gdb_caching_proc allow_power_isa_3_1_tests { return $allow_power_isa_3_1_tests } -# Run a test on the target to see if it supports vmx hardware. Return 0 if so, -# 1 if it does not. Based on 'check_vmx_hw_available' from the GCC testsuite. +# Run a test on the target to see if it supports vmx hardware. Return 1 if so, +# 0 if it does not. Based on 'check_vmx_hw_available' from the GCC testsuite. -gdb_caching_proc skip_vsx_tests { +gdb_caching_proc allow_vsx_tests { global srcdir subdir gdb_prompt inferior_exited_re - set me "skip_vsx_tests" + set me "allow_vsx_tests" # Some simulators are known to not support Altivec instructions, so # they won't support VSX instructions as well. if { [istarget powerpc-*-eabi] || [istarget powerpc*-*-eabispe] } { - verbose "$me: target known to not support VSX, returning 1" 2 - return 1 + verbose "$me: target known to not support VSX, returning 0" 2 + return 0 } # Make sure we have a compiler that understands altivec. @@ -3592,8 +3592,8 @@ gdb_caching_proc skip_vsx_tests { } elseif [test_compiler_info xlc*] { set compile_flags "additional_flags=-qasm=gcc" } else { - verbose "Could not compile with vsx support, returning 1" 2 - return 1 + verbose "Could not compile with vsx support, returning 0" 2 + return 0 } # Compile a test program containing VSX instructions. @@ -3609,7 +3609,7 @@ gdb_caching_proc skip_vsx_tests { } } if {![gdb_simple_compile $me $src executable $compile_flags]} { - return 1 + return 0 } # No error message, compilation succeeded so now run it via gdb. @@ -3622,22 +3622,22 @@ gdb_caching_proc skip_vsx_tests { gdb_expect { -re ".*Illegal instruction.*${gdb_prompt} $" { verbose -log "\n$me VSX hardware not detected" - set skip_vsx_tests 1 + set allow_vsx_tests 0 } -re ".*$inferior_exited_re normally.*${gdb_prompt} $" { verbose -log "\n$me: VSX hardware detected" - set skip_vsx_tests 0 + set allow_vsx_tests 1 } default { warning "\n$me: default case taken" - set skip_vsx_tests 1 + set allow_vsx_tests 0 } } gdb_exit remote_file build delete $obj - verbose "$me: returning $skip_vsx_tests" 2 - return $skip_vsx_tests + verbose "$me: returning $allow_vsx_tests" 2 + return $allow_vsx_tests } # Run a test on the target to see if it supports TSX hardware. Return 1 if so,