From patchwork Wed Jan 18 11:35:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Vrany X-Patchwork-Id: 63336 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6D5EA3858C36 for ; Wed, 18 Jan 2023 11:36:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6D5EA3858C36 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674041767; bh=3eYaWaPwIJ6tGM+zJGYqyfsp0y+5Ghd5EsgdX48MWGw=; h=To:CC:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=qfhEhocmy14bAmp0GmSrhqAFBrK9lDe2S+3fFJsV7+1oxuJ6SfsWOjCZldbVjLWvc Q6Mk7Az7ufJDzDA706S34jzb2toFeb9yC6Hyqljmixvh0ro0xRHHgDRbhUN5LQREcE BWMgeNklO73KTLVobh2sh7F1pt2IkIXpUG6VudPQ= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-114.mimecast.com (us-smtp-delivery-114.mimecast.com [170.10.133.114]) by sourceware.org (Postfix) with ESMTPS id C328D3858D28 for ; Wed, 18 Jan 2023 11:35:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C328D3858D28 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-32-DTmXxE0WPyKmwdQIKIh3DQ-1; Wed, 18 Jan 2023 06:35:41 -0500 X-MC-Unique: DTmXxE0WPyKmwdQIKIh3DQ-1 Received: from DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) by PH0PR17MB5488.namprd17.prod.outlook.com (2603:10b6:510:ba::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Wed, 18 Jan 2023 11:35:37 +0000 Received: from DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::1729:3f69:5d95:b768]) by DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::1729:3f69:5d95:b768%7]) with mapi id 15.20.6002.024; Wed, 18 Jan 2023 11:35:36 +0000 To: gdb-patches@sourceware.org CC: Jan Vrany Subject: [pushed] gdb: care for dynamic objfiles in build_id_bfd_get () Date: Wed, 18 Jan 2023 11:35:25 +0000 Message-ID: <20230118113525.114475-1-jan.vrany@labware.com> X-Mailer: git-send-email 2.39.0 X-ClientProxiedBy: LO6P123CA0036.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::10) To DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR17MB3113:EE_|PH0PR17MB5488:EE_ X-MS-Office365-Filtering-Correlation-Id: c05acfd3-9f3f-49b3-d73f-08daf9481e0a X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: nWPV9cBWYdkckjNWemcxJKCzqBaZ1WAbVGoT5N3eo6B9//njHsTVmt5VYkdqKKSwSuiNx/8r+bZc1N1pLt+bu9BcU0XNFp2OTp1IuPgoVzAXrqj0GshK302ypEnrS0T4FfzKDTsCPL4UZbntkk7GI6zQuz4FW053h5RIl4J3ySQMq+PBK+a9k92afJ0z8yHQGjnKjkKq0/kM4GMWo1MOFWdpRPHMptN7Yq+vbwy6pmlJ81iwcHFrKWMXDMXODALUca/zsv6KX8pfjua4LlB8xYGwvbZZCZL3DyA8hJEDEySOC2luGQ66mnYq3lbonD/EJsjkEhEQjbnmkCUAvJjJRmh1vrJ86uL1j8vITkuXBFBU4vP91iyXueov2juCW/lMHH2hjYtVdyknKIcFCmwvi3rbgo1ZiY/ppwrjJpgl9Y0qWZl4abBYlWfg1VC4Yniir4xzS0x9kjNjOzpE6IPyX6yfZxr9g3K1AzQfKo7dY0ohZ//DCa5YIanYn+eM2kqOWqPUyocc/3sOP1x6GzgTAu81sSoyATJQfCLb9gITXUm2DsmBJ/xM7tkWt0/ulIeN0hMP8G2sybWtLgw+/xXTX3gH7xosFRod9OyHPh9y0vPPI7O9K9HPQEO73lI78lD7/I0cBw70HcwqddZbuB38wQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR17MB3113.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(396003)(136003)(376002)(39850400004)(366004)(451199015)(6506007)(6916009)(6666004)(107886003)(2906002)(5660300002)(66476007)(8676002)(6512007)(8936002)(83380400001)(44832011)(36756003)(38100700002)(41300700001)(4326008)(478600001)(6486002)(186003)(1076003)(26005)(66946007)(66556008)(86362001)(316002)(2616005); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: f0y1lkpUOKgYI50FDJyN+PeND/kofOfZzABF0tvCSe9OjgmTFdtGFEBuqbWZCPxVWPck/WQlaHdaCcvsXIkXBlQXkGa3W3Z7kiloOfHcS2uok1wE31BUHFUuknVgw3NQ7if2FNEY41ireWT5X8WiZ9zl34ChW0/d1EBKZAefyEcmSD4Rk7+fnbYpecj9bAKk81vPa/J7Wp1JZJSZL6PgQDD6RogMTo3fRnopSoq8kItBq2d/e4X1inWb6JNaMkIDi3dDBDiQKJZpy2fZ7SJBENSGWloqu6J4DXybwQVQ+QSBXl82x0FEwEyL+m++ubpFAJnmIaade3D3UZ2zqlcP34VgsxspPfSWCcG8mwPfHuMJgDzo+LQEB3qjtu7a/KqSo80vQx/d+mjEDbvyF6Sys2eTGI5mTO+fvE0K2E181M7uyeGbFZ5Nrk48U1BcVha+kbyQ2fwiHframWHaeLl5SfxfLXVJNGfhLyyACBBIv4b8WZWi4dV20SBN4oiaiRyNoffk8Y89XFbroCkiTRNYrtBmJCQAlSQvhQToowsU2I+KxOEQcHCNY6FBHKy0jKL3hUdJxalKcW+CMBhdMc62F2cxyEjiwE7JPgvk7kpBsknf3vXWKNyJRTR7lo8YBkVFNc8JS/KdYKGxixLsrB/epG9QsixkmMNNYEzh3Y/3+G/rYBRYu5DAXBRM6YMNjc6NGV9Bsi9QTEQK8AN5OZlT+DCNWYtSlFGeH84Su4GYaD4+u21ambPf2nBNbjsp5YYlEcWVMgN8JrM2JIhDPnXZrzguFwZD9/WfPGcZ0+V+L2IvFfeKQqHaM+VBF7Z04mCldML6ivwpMT5QH5Kwvq9zLSNvEPxz/TWJvCI893ltXcKJb9YHdGFuyO1lzi1jpy45nVX2RF3pBGL+PhzRAGnBEy1i5vBjsdxKFMEx4H4tb9bN4qK7tVX9ziSF3P9OYze+RQGmJlrfpwVHzyXcl9SBPUuDPpO+/aRUhTPs2S4aLw/b5I2uwriLPOpgt/4IQUz0kWcYHuO0oM9ybd14cAGi+OjcRC+qfLR2tdZ0KsGOuFqBvQdXAgkmdYMZAXIu2Ua3N/AfrcRCb/udJBXxRnvCFQJhqww0qH861M/N62JmvdEdEOl+Zmu/C3PoKtvtTCtxdKZUp/y0XFO13GRvQqjeEm4ou6mlpgGLoliwPdgmFSXTA8xo1NvFEkSGD/50373Wh5lC5GNXGl4Zgb+PYc3t4/oWR61jN6DFhIBz9Q5xoDdVIHlzF6t/kQNlmMno8K7Bn2ZVpYVz99R336yYWEq1S1FTpEcmqVhLLBwhz7SegFmbjVMZVKg7i+S5dXoX1X/EnvWA9SswE6P5RrkEPy1o3Tz4SZO+3rFpLCfPWPAqk7+D+0wowsiLWMHTsNTFDQmy4rRNVaDOj8GgDBvopnSG2sd5MMzAztBomiFV96Uqq99SG8HCIq09vZKTXwIKSTZvlIQjNO+x8Fyj5Zg7QmEBHG31FXp3iOGICXLdVAqdYv5sSTrCnipPNoDzwcxkCh1XDU/8NOAI/IsZbIsBfMa3Sn6givLrAzdwMhvM0vG2dVS4UTRcS7Z+AuWm1uuNj+UwHU9k0z4CmARz6Ug2yA8khA== X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-Network-Message-Id: c05acfd3-9f3f-49b3-d73f-08daf9481e0a X-MS-Exchange-CrossTenant-AuthSource: DM6PR17MB3113.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 11:35:36.5834 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LMwMJXh2qH1VbAGt2taQYDDzLKiwZ6PPkTU9Ypfh3OrDUd+UCjx5eadM5GeEUN0BlRn5OgEIJzBTcDdrECTadA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR17MB5488 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: labware.com X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Vrany via Gdb-patches From: Jan Vrany Reply-To: Jan Vrany Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Accessing gdb.Objfile.build_id caused GDB to crash when objfile is dynamic, that is created by JIT reader API. The issue was NULL-pointer dereferencing in build_id_bfd_get () because dynamic objfiles have no underlaying BFD structure. This commit fixes the problem by a NULL-check in build_id_bfd_get (). --- gdb/build-id.c | 6 ++++++ gdb/testsuite/gdb.base/jit-reader.exp | 4 ++++ 2 files changed, 10 insertions(+) diff --git a/gdb/build-id.c b/gdb/build-id.c index c82f96402c8..801eb004ad7 100644 --- a/gdb/build-id.c +++ b/gdb/build-id.c @@ -32,6 +32,12 @@ const struct bfd_build_id * build_id_bfd_get (bfd *abfd) { + /* Dynamic objfiles such as ones created by JIT reader API + have no underlaying bfd structure (that is, objfile->obfd + is NULL). */ + if (abfd == nullptr) + return nullptr; + if (!bfd_check_format (abfd, bfd_object) && !bfd_check_format (abfd, bfd_core)) return NULL; diff --git a/gdb/testsuite/gdb.base/jit-reader.exp b/gdb/testsuite/gdb.base/jit-reader.exp index fd0c5f56d6e..399cb67dcce 100644 --- a/gdb/testsuite/gdb.base/jit-reader.exp +++ b/gdb/testsuite/gdb.base/jit-reader.exp @@ -227,6 +227,10 @@ proc jit_reader_test {} { gdb_test "python print(list(map(lambda objf : objf.filename, gdb.objfiles())))" \ "$any'<< JIT compiled code at $hex >>'$any" \ "python gdb.Objfile.filename" + + gdb_test "python print( \[o for o in gdb.objfiles() if o.filename.startswith('<< JIT compiled code')\]\[0\].build_id )" \ + "None" \ + "python gdb.Objfile.build_id" } } }