From patchwork Tue Jan 17 22:36:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Ijaz, Abdul B" X-Patchwork-Id: 63310 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7555D3858C53 for ; Tue, 17 Jan 2023 22:37:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7555D3858C53 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673995070; bh=H4kKCs/LFU3ndLNvzgn2+/NmzXESZYjJlHOf+Sx4Hao=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=dYnr8FaqfaTkbX0dzOvejZXmVV3U0aj9SFgcmUGL3ZpBlc2VoIhiGKHUYYiuyx28f zJbUo57lRyLO+LSJ8N26sTd3Kbhhub0J1/Zd8HgZN5IYpwFKqA7QYw8QDEvXhk8B6u F2bwRhUNHpnYGcd0rEW+OeG0Rqh8rsMQq+ZPdQZ0= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by sourceware.org (Postfix) with ESMTPS id 3727A3858D28 for ; Tue, 17 Jan 2023 22:37:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3727A3858D28 X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="352082668" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="352082668" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 14:36:46 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="727929220" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="727929220" Received: from labpc2030.iul.intel.com (HELO localhost) ([172.28.48.46]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 14:36:44 -0800 To: gdb-patches@sourceware.org Cc: abdul.b.ijaz@intel.com, aburgess@redhat.com Subject: [PATCH v4 1/1] gdb, testsuite: Fix arrays of variable length strings for FORTRAN Date: Tue, 17 Jan 2023 23:36:37 +0100 Message-Id: <20230117223637.27194-1-abdul.b.ijaz@intel.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Abdul Basit Ijaz via Gdb-patches From: "Ijaz, Abdul B" Reply-To: Abdul Basit Ijaz Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Before this change resolve_dynamic_array_or_string was called for all TYPE_CODE_ARRAY and TYPE_CODE_STRING types, but, in the end, this function always called create_array_type_with_stride, which creates a TYPE_CODE_ARRAY type. Suppose we have subroutine vla_array (arr1, arr2) character (len=*):: arr1 (:) character (len=5):: arr2 (:) print *, arr1 ! break-here print *, arr2 end subroutine vla_array The "print arr1" and "print arr2" command at the "break-here" line gives the following output: (gdb) print arr1 $1 = (gdb) print arr2 $2 = ('abcde', 'abcde', 'abcde') (gdb) ptype arr1 type = Type End Type (gdb) ptype arr2 type = character*5 (3) Dwarf info using Intel® Fortran Compiler for such case contains following: <1>: Abbrev Number: 12 (DW_TAG_string_type) DW_AT_name : (indirect string, offset: 0xd2): .str.ARR1 <102> DW_AT_string_length: 3 byte block: 97 23 8 (DW_OP_push_object_address; DW_OP_plus_uconst: 8) After this change resolve_dynamic_array_or_string now calls create_array_type_with_stride or create_string_type, so if the incoming dynamic type is a TYPE_CODE_STRING then we'll get back a TYPE_CODE_STRING type. Now gdb shows following: (gdb) p arr1 $1 = ('abddefghij', 'abddefghij', 'abddefghij', 'abddefghij', 'abddefghij') (gdb) p arr2 $2 = ('abcde', 'abcde', 'abcde') (gdb) ptype arr1 type = character*10 (5) (gdb) ptype arr2 type = character*5 (3) Fixing above issue introduce regression in gdb.fortran/mixed-lang-stack.exp, i.e. the test forces the language to C/C++ and print a Fortran string value. The string value is a dynamic type with code TYPE_CODE_STRING. Before this commit the dynamic type resolution would always convert this to a TYPE_CODE_ARRAY of characters, which the C value printing could handle. But now after this commit we get a TYPE_CODE_STRING, which neither the C value printing, or the generic value printing code can support. And so, I've added support for TYPE_CODE_STRING to the C value printing, strings are handled just like arrays. Lastly, in gdb.opt/fortran-string.exp and gdb.fortran/string-types.exp tests it expects type of character array in 'character (3)' format but now after this change we get 'character*3', so tests are updated accordingly. 2023-01-17 Abdul Basit Ijaz --- gdb/c-valprint.c | 1 + gdb/gdbtypes.c | 45 ++++++++++++++-- gdb/testsuite/gdb.fortran/string-types.exp | 4 +- gdb/testsuite/gdb.fortran/vla-array.exp | 60 ++++++++++++++++++++++ gdb/testsuite/gdb.fortran/vla-array.f90 | 45 ++++++++++++++++ gdb/testsuite/gdb.opt/fortran-string.exp | 2 +- 6 files changed, 151 insertions(+), 6 deletions(-) create mode 100644 gdb/testsuite/gdb.fortran/vla-array.exp create mode 100644 gdb/testsuite/gdb.fortran/vla-array.f90 diff --git a/gdb/c-valprint.c b/gdb/c-valprint.c index ce759bc887f..3b744b76254 100644 --- a/gdb/c-valprint.c +++ b/gdb/c-valprint.c @@ -427,6 +427,7 @@ c_value_print_inner (struct value *val, struct ui_file *stream, int recurse, switch (type->code ()) { case TYPE_CODE_ARRAY: + case TYPE_CODE_STRING: c_value_print_array (val, stream, recurse, options); break; diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index 6a4c5976f18..6dfa3705a1a 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -2353,9 +2353,45 @@ resolve_dynamic_array_or_string_1 (struct type *type, rank - 1, resolve_p); } else - elt_type = type->target_type (); + { + /* The following special case for TYPE_CODE_STRING should not be + needed, ideally we would defer resolving the dynamic type of the + array elements until needed later, and indeed, the resolved type + of each array element might be different, so attempting to resolve + the type here makes no sense. + + However, in Fortran, for arrays of strings, each element must be + the same type, as such, the DWARF for the string length relies on + the object address of the array itself. + + The problem here is that, when we create value's from the dynamic + array type, we resolve the data location, and use that as the + value address, this completely discards the original value + address, and it is this original value address that is the + descriptor for the dynamic array, the very address that the DWARF + needs us to push in order to resolve the dynamic string length. + + What this means then, is that, given the current state of GDB, if + we don't resolve the string length now, then we will have lost + access to the address of the dynamic object descriptor, and so we + will not be able to resolve the dynamic string later. + + For now then, we handle special case TYPE_CODE_STRING on behalf of + Fortran, and hope that this doesn't cause problems for anyone + else. */ + if (ary_dim->code () == TYPE_CODE_STRING) + elt_type = resolve_dynamic_type_internal (type->target_type (), + addr_stack, 0); + else + elt_type = type->target_type (); + } prop = type->dyn_prop (DYN_PROP_BYTE_STRIDE); + if (prop != nullptr && type->code () == TYPE_CODE_STRING) + { + prop = nullptr; + warning (_("byte stride property ignored on string type")); + } if (prop != NULL && resolve_p) { if (dwarf2_evaluate_property (prop, NULL, addr_stack, &value)) @@ -2375,8 +2411,11 @@ resolve_dynamic_array_or_string_1 (struct type *type, else bit_stride = TYPE_FIELD_BITSIZE (type, 0); - return create_array_type_with_stride (type, elt_type, range_type, NULL, - bit_stride); + if (type->code () == TYPE_CODE_STRING) + return create_string_type (type, elt_type, range_type); + else + return create_array_type_with_stride (type, elt_type, range_type, NULL, + bit_stride); } /* Resolve an array or string type with dynamic properties, return a new diff --git a/gdb/testsuite/gdb.fortran/string-types.exp b/gdb/testsuite/gdb.fortran/string-types.exp index 3114fbaac78..379857b2138 100644 --- a/gdb/testsuite/gdb.fortran/string-types.exp +++ b/gdb/testsuite/gdb.fortran/string-types.exp @@ -52,7 +52,7 @@ with_test_prefix "third breakpoint, first time" { # Continue to the third breakpoint. gdb_continue_to_breakpoint "continue" gdb_test "print s" " = 'foo'" - gdb_test "ptype s" "type = character \\(3\\)" + gdb_test "ptype s" "type = character\\*3" } with_test_prefix "third breakpoint, second time" { @@ -65,5 +65,5 @@ with_test_prefix "third breakpoint, second time" { # by most users, so seems good enough. gdb_continue_to_breakpoint "continue" gdb_test "print s" " = 'foo\\\\n\\\\t\\\\r\\\\000bar'" - gdb_test "ptype s" "type = character \\(10\\)" + gdb_test "ptype s" "type = character\\*10" } diff --git a/gdb/testsuite/gdb.fortran/vla-array.exp b/gdb/testsuite/gdb.fortran/vla-array.exp new file mode 100644 index 00000000000..c50141b7330 --- /dev/null +++ b/gdb/testsuite/gdb.fortran/vla-array.exp @@ -0,0 +1,60 @@ +# Copyright 2023 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +standard_testfile ".f90" +load_lib "fortran.exp" + +if {[skip_fortran_tests]} { return -1 } + +if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \ + {debug f90 quiet}] } { + return -1 +} + +if ![fortran_runto_main] { + untested "could not run to main" + return -1 +} + +# Try to access vla string / vla string array / string array values. +gdb_breakpoint [gdb_get_line_number "arr_vla1-print"] +gdb_continue_to_breakpoint "arr_vla1-print" + +# GFortran does not emit DW_TAG_string_type for array of variable length +# string. +if [test_compiler_info "gfortran*" f90] { setup_xfail *-*-* gcc/101826 } +gdb_test "print arr_vla1" \ + " = \\\('vlaaryvlaary', 'vlaaryvlaary', 'vlaaryvlaary', 'vlaaryvlaary', 'vlaaryvlaary'\\\)" \ + "print vla string array" + +if [test_compiler_info "gfortran*" f90] { setup_xfail *-*-* gcc/101826 } +gdb_test "ptype arr_vla1" \ + "type = character\\*12 \\(5\\)" \ + "print variable length string array type" +gdb_test "print arr_vla2" \ + " = 'vlaary'" \ + "print variable length string" +gdb_test "ptype arr_vla2" \ + "type = character\\*6" \ + "print variable length string type" +gdb_test "print arr2" \ + " = \\\('vlaaryvla', 'vlaaryvla', 'vlaaryvla'\\\)" \ + "print string array" +gdb_test "ptype arr2" \ + "type = character\\*9 \\(3\\)" \ + "print string array type" +gdb_test "print rank(arr_vla1)" \ + "$decimal" \ + "print string array rank" diff --git a/gdb/testsuite/gdb.fortran/vla-array.f90 b/gdb/testsuite/gdb.fortran/vla-array.f90 new file mode 100644 index 00000000000..7af88fb4414 --- /dev/null +++ b/gdb/testsuite/gdb.fortran/vla-array.f90 @@ -0,0 +1,45 @@ +! Copyright 2023 Free Software Foundation, Inc. +! +! This program is free software; you can redistribute it and/or modify +! it under the terms of the GNU General Public License as published by +! the Free Software Foundation; either version 3 of the License, or +! (at your option) any later version. +! +! This program is distributed in the hope that it will be useful, +! but WITHOUT ANY WARRANTY; without even the implied warranty of +! MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +! GNU General Public License for more details. +! +! You should have received a copy of the GNU General Public License +! along with this program. If not, see . + +subroutine vla_array_func (arr_vla1, arr_vla2, arr2) + character (len=*):: arr_vla1 (:) + character (len=*):: arr_vla2 + character (len=9):: arr2 (:) + + print *, arr_vla1 ! arr_vla1-print + print *, arr_vla2 + print *, arr2 + print *, rank(arr_vla1) +end subroutine vla_array_func + +program vla_array_main +interface + subroutine vla_array_func (arr_vla1, arr_vla2, arr2) + character (len=*):: arr_vla1 (:) + character (len=*):: arr_vla2 + character (len=9):: arr2 (:) + end subroutine vla_array_func +end interface + character (len=9) :: arr1 (3) + character (len=6) :: arr2 + character (len=12) :: arr3 (5) + + arr1 = 'vlaaryvla' + arr2 = 'vlaary' + arr3 = 'vlaaryvlaary' + + call vla_array_func (arr3, arr2, arr1) + +end program vla_array_main diff --git a/gdb/testsuite/gdb.opt/fortran-string.exp b/gdb/testsuite/gdb.opt/fortran-string.exp index e42b2905578..01750e359da 100644 --- a/gdb/testsuite/gdb.opt/fortran-string.exp +++ b/gdb/testsuite/gdb.opt/fortran-string.exp @@ -33,5 +33,5 @@ if {![runto f]} { gdb_test_no_output "set print frame-arguments all" gdb_test "frame" ".*s='foo'.*" -gdb_test "ptype s" "type = character \\(3\\)" +gdb_test "ptype s" "type = character\\*3" gdb_test "p s" "\\$\[0-9\]* = 'foo'"