From patchwork Thu Jan 12 03:00:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 63053 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 838913AA9413 for ; Thu, 12 Jan 2023 03:07:02 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id A4DBA3882118 for ; Thu, 12 Jan 2023 03:01:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A4DBA3882118 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 2AFA71004BD92 for ; Thu, 12 Jan 2023 03:01:51 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id FnqhpOwtrNX2aFnqhpDVYD; Thu, 12 Jan 2023 03:01:51 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=63bf781f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=mDV3o1hIAAAA:8 a=xWaAywOe11BJMmvO5qAA:9 a=_FVE-zBwftR9WsbkzFJk:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=pVigpMUWX3bfVUmlgCqYAKG3ZmH/LSDQ7E+WY1L/128=; b=kWfAUFVhFpx4iuhVcQJY3REoDq 0s56NtJvkyLMw6zVe63G4uVf8U9xnzO4OC9KmhNt4f5kPCw4ta8gjXVMes2W0cbaulMbp3j4urajr vRM5MKGG+/0SCTEP80HUjJ12u; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:41092 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pFnqg-000mJw-UN; Wed, 11 Jan 2023 20:01:51 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH v2 75/79] Rename to allow_tsx_tests Date: Wed, 11 Jan 2023 20:00:48 -0700 Message-Id: <20230112030052.3306113-76-tom@tromey.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230112030052.3306113-1-tom@tromey.com> References: <20230112030052.3306113-1-tom@tromey.com> MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pFnqg-000mJw-UN X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (localhost.localdomain) [97.122.76.186]:41092 X-Source-Auth: tom+tromey.com X-Email-Count: 76 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3028.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" This changes skip_tsx_tests to invert the sense, and renames it to allow_tsx_tests. --- gdb/testsuite/gdb.btrace/tsx.exp | 2 +- gdb/testsuite/lib/gdb.exp | 20 ++++++++++---------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/gdb/testsuite/gdb.btrace/tsx.exp b/gdb/testsuite/gdb.btrace/tsx.exp index 222c352c368..b56fd2858e0 100644 --- a/gdb/testsuite/gdb.btrace/tsx.exp +++ b/gdb/testsuite/gdb.btrace/tsx.exp @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . -require allow_btrace_pt_tests !skip_tsx_tests +require allow_btrace_pt_tests allow_tsx_tests standard_testfile .c x86-tsx.S if [prepare_for_testing "failed to prepare" $testfile "$srcfile $srcfile2" {debug}] { diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index c989d9e0b1f..94dccf8a6a1 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -3649,13 +3649,13 @@ gdb_caching_proc skip_vsx_tests { return $skip_vsx_tests } -# Run a test on the target to see if it supports TSX hardware. Return 0 if so, -# 1 if it does not. Based on 'check_vmx_hw_available' from the GCC testsuite. +# Run a test on the target to see if it supports TSX hardware. Return 1 if so, +# 0 if it does not. Based on 'check_vmx_hw_available' from the GCC testsuite. -gdb_caching_proc skip_tsx_tests { +gdb_caching_proc allow_tsx_tests { global srcdir subdir gdb_prompt inferior_exited_re - set me "skip_tsx_tests" + set me "allow_tsx_tests" # Compile a test program. set src { @@ -3667,7 +3667,7 @@ gdb_caching_proc skip_tsx_tests { } } if {![gdb_simple_compile $me $src executable]} { - return 1 + return 0 } # No error message, compilation succeeded so now run it via gdb. @@ -3680,22 +3680,22 @@ gdb_caching_proc skip_tsx_tests { gdb_expect { -re ".*Illegal instruction.*${gdb_prompt} $" { verbose -log "$me: TSX hardware not detected." - set skip_tsx_tests 1 + set allow_tsx_tests 0 } -re ".*$inferior_exited_re normally.*${gdb_prompt} $" { verbose -log "$me: TSX hardware detected." - set skip_tsx_tests 0 + set allow_tsx_tests 1 } default { warning "\n$me: default case taken." - set skip_tsx_tests 1 + set allow_tsx_tests 0 } } gdb_exit remote_file build delete $obj - verbose "$me: returning $skip_tsx_tests" 2 - return $skip_tsx_tests + verbose "$me: returning $allow_tsx_tests" 2 + return $allow_tsx_tests } # Run a test on the target to see if it supports avx512bf16. Return 1 if so,