From patchwork Thu Jan 12 03:00:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 63037 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9157B3954477 for ; Thu, 12 Jan 2023 03:05:53 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 78101382FC83 for ; Thu, 12 Jan 2023 03:01:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 78101382FC83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id F065510047325 for ; Thu, 12 Jan 2023 03:01:39 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id FnqVpqVE4B18UFnqVpA40Z; Thu, 12 Jan 2023 03:01:39 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Ns4Uz+RJ c=1 sm=1 tr=0 ts=63bf7813 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=TkTTPzHaAAAA:8 a=mDV3o1hIAAAA:8 a=3-9Ijlw7Pq7UadECio0A:9 a=Qz3p68GZ3z-NqTySStDO:22 a=_FVE-zBwftR9WsbkzFJk:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=C1ZlNjDjSf1zITqQDZKzAVG1dfUyKFMmW32WQfqyv8Q=; b=DxPWJg+SA5H4H5E1xquEOKWZON 5xICJ32QPWNl1CWUerrLQZ9PM35PtH+Fzge3lpeXzdDVFfZ2D+I1stW/SXlrTJAVbtVYCQ/ehFRFU bQRSoDWE/Kwyda0ZxZEDnpjst; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:60784 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pFnqV-000lzh-N1; Wed, 11 Jan 2023 20:01:39 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH v2 59/79] Rename to allow_ctf_tests Date: Wed, 11 Jan 2023 20:00:32 -0700 Message-Id: <20230112030052.3306113-60-tom@tromey.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230112030052.3306113-1-tom@tromey.com> References: <20230112030052.3306113-1-tom@tromey.com> MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pFnqV-000lzh-N1 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (localhost.localdomain) [97.122.76.186]:60784 X-Source-Auth: tom+tromey.com X-Email-Count: 60 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3028.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" This changes skip_ctf_tests to invert the sense, and renames it to allow_ctf_tests. --- gdb/testsuite/gdb.base/ctf-constvars.exp | 2 +- gdb/testsuite/gdb.base/ctf-ptype.exp | 2 +- gdb/testsuite/gdb.base/cvexpr.exp | 2 +- gdb/testsuite/gdb.base/whatis.exp | 2 +- gdb/testsuite/gdb.ctf/cross-tu-cyclic.exp | 2 +- gdb/testsuite/gdb.ctf/funcreturn.exp | 2 +- gdb/testsuite/gdb.ctf/multi.exp | 2 +- gdb/testsuite/lib/gdb.exp | 6 +++--- 8 files changed, 10 insertions(+), 10 deletions(-) diff --git a/gdb/testsuite/gdb.base/ctf-constvars.exp b/gdb/testsuite/gdb.base/ctf-constvars.exp index 7737401bbab..7b3c0f69da8 100644 --- a/gdb/testsuite/gdb.base/ctf-constvars.exp +++ b/gdb/testsuite/gdb.base/ctf-constvars.exp @@ -24,7 +24,7 @@ # const pointers to const vars # with mixed types. -require !skip_ctf_tests +require allow_ctf_tests standard_testfile .c diff --git a/gdb/testsuite/gdb.base/ctf-ptype.exp b/gdb/testsuite/gdb.base/ctf-ptype.exp index 4010cf4e15e..4a81993628e 100644 --- a/gdb/testsuite/gdb.base/ctf-ptype.exp +++ b/gdb/testsuite/gdb.base/ctf-ptype.exp @@ -15,7 +15,7 @@ # This file is a subset of ptype.exp written by Rob Savoye. (rob@cygnus.com) -require !skip_ctf_tests +require allow_ctf_tests # Some tests require GCC. set gcc_compiled [is_c_compiler_gcc] diff --git a/gdb/testsuite/gdb.base/cvexpr.exp b/gdb/testsuite/gdb.base/cvexpr.exp index 3d78936350a..bbaa7d4983b 100644 --- a/gdb/testsuite/gdb.base/cvexpr.exp +++ b/gdb/testsuite/gdb.base/cvexpr.exp @@ -497,7 +497,7 @@ lappend ctf_opts ldflags=-Wl,--strip-debug # Build up the set of debug formats for which we will run this test. set specs { {dwarf {debug}} } -if ![skip_ctf_tests] { +if {[allow_ctf_tests]} { lappend specs [list ctf $ctf_opts] } diff --git a/gdb/testsuite/gdb.base/whatis.exp b/gdb/testsuite/gdb.base/whatis.exp index 2da9aecc600..3736e78bbdc 100644 --- a/gdb/testsuite/gdb.base/whatis.exp +++ b/gdb/testsuite/gdb.base/whatis.exp @@ -592,7 +592,7 @@ lappend ctf_opts ldflags=-Wl,--ctf-variables # Build up the set of debug formats for which we will run this test. set specs { {dwarf {debug}} } -if ![skip_ctf_tests] { +if {[allow_ctf_tests]} { lappend specs [list ctf $ctf_opts] } diff --git a/gdb/testsuite/gdb.ctf/cross-tu-cyclic.exp b/gdb/testsuite/gdb.ctf/cross-tu-cyclic.exp index 4ce178af2c0..0292e394646 100644 --- a/gdb/testsuite/gdb.ctf/cross-tu-cyclic.exp +++ b/gdb/testsuite/gdb.ctf/cross-tu-cyclic.exp @@ -15,7 +15,7 @@ # This file is a subset of ptype.exp written by Rob Savoye. (rob@cygnus.com) -require !skip_ctf_tests +require allow_ctf_tests standard_testfile cross-tu-cyclic-1.c cross-tu-cyclic-2.c \ cross-tu-cyclic-3.c cross-tu-cyclic-4.c diff --git a/gdb/testsuite/gdb.ctf/funcreturn.exp b/gdb/testsuite/gdb.ctf/funcreturn.exp index a65a1cbf7ad..64ed031f693 100644 --- a/gdb/testsuite/gdb.ctf/funcreturn.exp +++ b/gdb/testsuite/gdb.ctf/funcreturn.exp @@ -13,7 +13,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . -require !skip_ctf_tests +require allow_ctf_tests if [target_info exists no_long_long] { set exec_opts [list debug additional_flags=-DNO_LONG_LONG] diff --git a/gdb/testsuite/gdb.ctf/multi.exp b/gdb/testsuite/gdb.ctf/multi.exp index 0afbdc5a6ab..c82d1b952e3 100644 --- a/gdb/testsuite/gdb.ctf/multi.exp +++ b/gdb/testsuite/gdb.ctf/multi.exp @@ -15,7 +15,7 @@ # This file is a subset of ptype.exp written by Rob Savoye. (rob@cygnus.com) -require !skip_ctf_tests +require allow_ctf_tests standard_testfile ctf-a.c ctf-b.c ctf-c.c diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index b1d0e7aefdf..e2feebfab8f 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -8522,11 +8522,11 @@ proc cmp_binary_files { file1 file2 } { # flag? If not then we should skip these tests. We should also # skip them if libctf was explicitly disabled. -gdb_caching_proc skip_ctf_tests { +gdb_caching_proc allow_ctf_tests { global enable_libctf if {$enable_libctf eq "no"} { - return 1 + return 0 } set can_ctf [gdb_can_simple_compile ctfdebug { @@ -8535,7 +8535,7 @@ gdb_caching_proc skip_ctf_tests { } } executable "additional_flags=-gctf"] - return [expr {!$can_ctf}] + return $can_ctf } # Return 1 if compiler supports -gstatement-frontiers. Otherwise,