From patchwork Tue Jan 10 18:33:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 62901 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9B9AA38460AD for ; Tue, 10 Jan 2023 18:34:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9B9AA38460AD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673375658; bh=yInp+UCMToB4+H3Td8N36YfyuEfUu7Xh8g2JSEKErFQ=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Ozd6Nd1dcqg7bC34BEjwvOib0SobKPDOVLo0zfeQRGORGanCHsw55eJWJk9eWvc7M +J6QqZrfk1D9yqV7cJOh6R7slqdEGvuuXUD9CeeO89N7APbz2QOxHS/PqaMsiyX6nY +cOj4pHKUgd/jMs3Ay0BXbNvlD/xSCxUp6iBf2Gc= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by sourceware.org (Postfix) with ESMTPS id 9C6B43858C52 for ; Tue, 10 Jan 2023 18:33:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9C6B43858C52 Received: by mail-il1-x12e.google.com with SMTP id i1so3357801ilu.8 for ; Tue, 10 Jan 2023 10:33:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yInp+UCMToB4+H3Td8N36YfyuEfUu7Xh8g2JSEKErFQ=; b=QZIn2NREZbK4cjMEfUzLMn0wznJ/JZSNzPU4I/HzPVZEM6dBjVpQ8TW4MBhiCUlbh5 IU9MO7w62V/RyCxXSgHf9s/8aO1o7vITkNJhEyIrlOppbb8eQFXDoz3aS4zdx6S6K939 kOGxjzuPFC0AT58nKf2+1EiXb22bNJ33D3vbBv7W9Mmc94O+J/E0Ua5GczvXYPXJtIQk VWY7pkmYsSu+VVeCQL/joIlW2OPDv2Kv4Xc9BYPmAGpfUb++Gbgb8OEr9NkdKjXY/C8e lJdig1GEvMJEJybda/AAkxMCZP9EpGUOwXZpqaU9swwaeohwgco8siZ1bQL7tg67Iqu/ uVpw== X-Gm-Message-State: AFqh2kqLHY67sReq+1R/RVAKuaxCTkPExenRWv9jKLS6vA1rzXLSGB5u TeGUVPPRQUiSyZLuOEcZmJ97YIG+Y6EyMwRi X-Google-Smtp-Source: AMrXdXs6KQhG9WbenRh3bXjvXOwANZ84zsSOi+Aer+VOsDqhG4UPZ2UD5kdMIkvMPFT91HsCiojY7A== X-Received: by 2002:a92:d80a:0:b0:30d:859b:156a with SMTP id y10-20020a92d80a000000b0030d859b156amr14125728ilm.16.1673375630863; Tue, 10 Jan 2023 10:33:50 -0800 (PST) Received: from localhost.localdomain (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id w20-20020a05663800d400b00375783003fcsm3739933jao.136.2023.01.10.10.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 10:33:50 -0800 (PST) To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH v2 2/4] Don't erase empty indices in DWARF reader Date: Tue, 10 Jan 2023 11:33:36 -0700 Message-Id: <20230110183338.2623088-3-tromey@adacore.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230110183338.2623088-1-tromey@adacore.com> References: <20230110183338.2623088-1-tromey@adacore.com> MIME-Version: 1.0 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom Tromey via Gdb-patches From: Tom Tromey Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" The DWARF reader has some code to remove empty indices. However, I think this code has been obsolete since some earlier changes to parallel_for_each. This patch removes this code. --- gdb/dwarf2/read.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 851852404eb..c3f246fedf7 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -7170,16 +7170,6 @@ dwarf2_build_psymtabs_hard (dwarf2_per_objfile *per_objfile) print_tu_stats (per_objfile); indexes.push_back (index_storage.release ()); - /* Remove any NULL entries. This might happen if parallel-for - decides to throttle the number of threads that were used. */ - indexes.erase - (std::remove_if (indexes.begin (), - indexes.end (), - [] (const std::unique_ptr &entry) - { - return entry == nullptr; - }), - indexes.end ()); indexes.shrink_to_fit (); cooked_index_vector *vec = new cooked_index_vector (std::move (indexes));