From patchwork Tue Jan 3 07:55:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 62608 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 457AC3948822 for ; Tue, 3 Jan 2023 08:03:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 457AC3948822 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1672732988; bh=BAUgsu5psvLZzUPFIx1bAWbays5V5JjyAW8g6ayfVz4=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=JUAjxsOOUymlnE2cq1UaJM1WFdHxEWw+eHOK7/QS4EHWs/VFWCM8fISuE6Cthoa2t um/AfgWUz3ri7Hl2gASyf0oBppJUONpdqXUqH9UvVfrI7SFuozgoarQ+YyEw001jD1 yhCpQ/7U66qaBJ4jKFMoK5QFRR+IKG8jQpTZ88/c= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 57F503858C39 for ; Tue, 3 Jan 2023 07:57:16 +0000 (GMT) Received: by smtp.gentoo.org (Postfix, from userid 559) id 0E77C340CD2; Tue, 3 Jan 2023 07:57:16 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH 31/83] sim: rl78: move libsim.a creation to top-level Date: Tue, 3 Jan 2023 02:55:13 -0500 Message-Id: <20230103075605.13606-32-vapier@gentoo.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230103075605.13606-1-vapier@gentoo.org> References: <20230103075605.13606-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Mike Frysinger via Gdb-patches From: Mike Frysinger Reply-To: Mike Frysinger Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" The objects are still compiled in the subdir, but the creation of the archive itself is in the top-level. This is a required step before we can move compilation itself up, and makes it easier to review. The downside is that each object compile is a recursive make instead of a single one. On my 4 core system, it adds ~100msec to the build per port, so it's not great, but it shouldn't be a big deal. This will go away of course once the top-level compiles objects. --- sim/Makefile.in | 83 ++++++++++++++++++++++++++++++-------------- sim/rl78/Makefile.in | 12 ++----- sim/rl78/local.mk | 24 ++++++++++--- 3 files changed, 78 insertions(+), 41 deletions(-) diff --git a/sim/rl78/Makefile.in b/sim/rl78/Makefile.in index 9ca400efe283..0cc55baf3b5a 100644 --- a/sim/rl78/Makefile.in +++ b/sim/rl78/Makefile.in @@ -20,15 +20,7 @@ ## COMMON_PRE_CONFIG_FRAG -SIM_RUN_OBJS = \ - main.o - -SIM_OBJS = \ - load.o \ - mem.o \ - cpu.o \ - rl78.o \ - gdb-if.o \ - trace.o +SIM_LIBSIM = +SIM_RUN_OBJS = ## COMMON_POST_CONFIG_FRAG diff --git a/sim/rl78/local.mk b/sim/rl78/local.mk index 07ff86711c16..935fbf1eea07 100644 --- a/sim/rl78/local.mk +++ b/sim/rl78/local.mk @@ -16,6 +16,26 @@ ## You should have received a copy of the GNU General Public License ## along with this program. If not, see . +%C%_libsim_a_SOURCES = +%C%_libsim_a_LIBADD = \ + $(common_libcommon_a_OBJECTS) \ + %D%/load.o \ + %D%/mem.o \ + %D%/cpu.o \ + %D%/rl78.o \ + %D%/gdb-if.o \ + %D%/modules.o \ + %D%/trace.o +$(%C%_libsim_a_OBJECTS) $(%C%_libsim_a_LIBADD): %D%/hw-config.h + +noinst_LIBRARIES += %D%/libsim.a + +%D%/%.o: %D%/%.c + $(AM_V_at)$(MAKE) $(AM_MAKEFLAGS) -C $(@D) $(@F) + +%D%/%.o: common/%.c + $(AM_V_at)$(MAKE) $(AM_MAKEFLAGS) -C $(@D) $(@F) + %C%_run_SOURCES = %C%_run_LDADD = \ %D%/main.o \ @@ -23,7 +43,3 @@ $(SIM_COMMON_LIBS) noinst_PROGRAMS += %D%/run - -## Helper targets for running make from the top-level due to run's main.o. -%D%/%.o: %D%/%.c | %D%/libsim.a $(SIM_ALL_RECURSIVE_DEPS) - $(MAKE) $(AM_MAKEFLAGS) -C $(@D) $(@F)