diff mbox series

[26/46] Use require is_aarch32_target

Message ID	20221217000818.3729389-27-tom@tromey.com
State	Committed
Headers	DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C03C138358BA From: Tom Tromey <tom@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey <tom@tromey.com> Subject: [PATCH 26/46] Use require is_aarch32_target Date: Fri, 16 Dec 2022 17:07:58 -0700 Message-Id: <20221217000818.3729389-27-tom@tromey.com> In-Reply-To: <20221217000818.3729389-1-tom@tromey.com> References: <20221217000818.3729389-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org>
Series	Rewrite "require" test procedure and use it more often \| [00/46] Rewrite "require" test procedure and use it more often [01/46] Don't use ensure_gdb_index with require [02/46] Change 'require' to accept a list of predicates [03/46] Use unsupported in 'require' [04/46] Use require supports_reverse [05/46] Use require supports_process_record [06/46] Use require dwarf2_support [07/46] Use require is_x86_like_target [08/46] Use require skip_cplus_tests [09/46] Use require skip_shlib_tests [10/46] Use require skip_dlmopen_tests [11/46] Use require skip_stl_tests [12/46] Use require skip_rust_tests [13/46] Use require skip_fortran_tests [14/46] Use require skip_ada_tests [15/46] Use require skip_go_tests [16/46] Use require skip_d_tests [17/46] Use require skip_ctf_tests [18/46] Use require skip_hw_watchpoint_tests [19/46] Use require skip_ifunc_tests [20/46] Use require skip_aarch64_sve_tests [21/46] Use require skip_btrace_tests [22/46] Use require skip_btrace_tests [23/46] Use require skip_avx_* [24/46] Use require support_displaced_stepping [25/46] Use require is_aarch64_target [26/46] Use require is_aarch32_target [27/46] Use require is_amd64_regs_target [28/46] Use require is_elf_target [29/46] Use require can_single_step_to_signal_handler [30/46] Use require supports_get_siginfo_type [31/46] Use require support_go_compile [32/46] Use require use_gdb_stub [33/46] Use require can_spawn_for_attach [34/46] Use require isnative [35/46] Use require skip_gdbserver_tests [36/46] Use require skip_shlib_tests [37/46] Use require is_c_compiler_gcc [38/46] Use require gdb_debug_enabled [39/46] Use require gdb_skip_xml_test [40/46] Use require gdb_trace_common_supports_arch [41/46] Use require skip_perf_tests [42/46] Use require skip_opencl_tests [43/46] Use require target_can_use_run_cmd [44/46] Use require using_fission [45/46] Use require skip_debuginfod_tests [46/46] Use require gnat_runtime_has_debug_info

Commit Message

Tom Tromey Dec. 17, 2022, 12:07 a.m. UTC

  This changes some tests to use "require is_aarch32_target".
---
 gdb/testsuite/gdb.arch/arm-bl-branch-dest.exp            | 5 +----
 gdb/testsuite/gdb.arch/arm-disp-step.exp                 | 5 +----
 gdb/testsuite/gdb.arch/arm-single-step-kernel-helper.exp | 5 +----
 gdb/testsuite/gdb.arch/pr25124.exp                       | 5 +----
 gdb/testsuite/gdb.arch/thumb-bx-pc.exp                   | 5 +----
 gdb/testsuite/gdb.arch/thumb-prologue.exp                | 5 +----
 gdb/testsuite/gdb.arch/thumb-singlestep.exp              | 5 +----
 7 files changed, 7 insertions(+), 28 deletions(-)

Comments

Luis Machado Dec. 19, 2022, 10:46 a.m. UTC | #1

On 12/17/22 00:07, Tom Tromey wrote:
> This changes some tests to use "require is_aarch32_target".
> ---
>   gdb/testsuite/gdb.arch/arm-bl-branch-dest.exp            | 5 +----
>   gdb/testsuite/gdb.arch/arm-disp-step.exp                 | 5 +----
>   gdb/testsuite/gdb.arch/arm-single-step-kernel-helper.exp | 5 +----
>   gdb/testsuite/gdb.arch/pr25124.exp                       | 5 +----
>   gdb/testsuite/gdb.arch/thumb-bx-pc.exp                   | 5 +----
>   gdb/testsuite/gdb.arch/thumb-prologue.exp                | 5 +----
>   gdb/testsuite/gdb.arch/thumb-singlestep.exp              | 5 +----
>   7 files changed, 7 insertions(+), 28 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.arch/arm-bl-branch-dest.exp b/gdb/testsuite/gdb.arch/arm-bl-branch-dest.exp
> index 34d98aec96e..37710649005 100644
> --- a/gdb/testsuite/gdb.arch/arm-bl-branch-dest.exp
> +++ b/gdb/testsuite/gdb.arch/arm-bl-branch-dest.exp
> @@ -13,10 +13,7 @@
>   # You should have received a copy of the GNU General Public License
>   # along with this program.  If not, see <http://www.gnu.org/licenses/>.
>   
> -if { ![is_aarch32_target] } {
> -    verbose "Skipping ${gdb_test_file_name}."
> -    return
> -}
> +require is_aarch32_target
>   
>   standard_testfile
>   
> diff --git a/gdb/testsuite/gdb.arch/arm-disp-step.exp b/gdb/testsuite/gdb.arch/arm-disp-step.exp
> index ec6578257b3..0eb1707bb6c 100644
> --- a/gdb/testsuite/gdb.arch/arm-disp-step.exp
> +++ b/gdb/testsuite/gdb.arch/arm-disp-step.exp
> @@ -17,10 +17,7 @@
>   
>   # Test arm displaced stepping.
>   
> -if {![is_aarch32_target]} {
> -    verbose "Skipping arm displaced stepping tests."
> -    return
> -}
> +require is_aarch32_target
>   
>   standard_testfile .S
>   
> diff --git a/gdb/testsuite/gdb.arch/arm-single-step-kernel-helper.exp b/gdb/testsuite/gdb.arch/arm-single-step-kernel-helper.exp
> index c3544b16a0b..22a2559b271 100644
> --- a/gdb/testsuite/gdb.arch/arm-single-step-kernel-helper.exp
> +++ b/gdb/testsuite/gdb.arch/arm-single-step-kernel-helper.exp
> @@ -13,10 +13,7 @@
>   # You should have received a copy of the GNU General Public License
>   # along with this program.  If not, see <http://www.gnu.org/licenses/>.
>   
> -if { ![is_aarch32_target] } {
> -    verbose "Skipping ${gdb_test_file_name}."
> -    return
> -}
> +require is_aarch32_target
>   
>   standard_testfile
>   
> diff --git a/gdb/testsuite/gdb.arch/pr25124.exp b/gdb/testsuite/gdb.arch/pr25124.exp
> index a68a3d1b7df..95636bd1ed8 100644
> --- a/gdb/testsuite/gdb.arch/pr25124.exp
> +++ b/gdb/testsuite/gdb.arch/pr25124.exp
> @@ -16,10 +16,7 @@
>   # Test proper disassembling of ARM thumb instructions when reloading a symbol
>   # file.
>   
> -if {![is_aarch32_target]} {
> -    verbose "Skipping ARM tests."
> -    return
> -}
> +require is_aarch32_target
>   
>   standard_testfile .S
>   
> diff --git a/gdb/testsuite/gdb.arch/thumb-bx-pc.exp b/gdb/testsuite/gdb.arch/thumb-bx-pc.exp
> index ccc6fbfdca7..6989d79c6d6 100644
> --- a/gdb/testsuite/gdb.arch/thumb-bx-pc.exp
> +++ b/gdb/testsuite/gdb.arch/thumb-bx-pc.exp
> @@ -15,10 +15,7 @@
>   
>   # Test PC adjustment from Thumb-mode "bx pc" instruction.
>   
> -if {![is_aarch32_target]} {
> -    verbose "Skipping ARM tests."
> -    return
> -}
> +require is_aarch32_target
>   
>   set testfile "thumb-bx-pc"
>   set srcfile ${testfile}.S
> diff --git a/gdb/testsuite/gdb.arch/thumb-prologue.exp b/gdb/testsuite/gdb.arch/thumb-prologue.exp
> index 0cb14572345..8e83bd3c009 100644
> --- a/gdb/testsuite/gdb.arch/thumb-prologue.exp
> +++ b/gdb/testsuite/gdb.arch/thumb-prologue.exp
> @@ -15,10 +15,7 @@
>   
>   # Test ARM/Thumb prologue analyzer.
>   
> -if {![is_aarch32_target]} {
> -    verbose "Skipping ARM prologue tests."
> -    return
> -}
> +require is_aarch32_target
>   
>   standard_testfile
>   
> diff --git a/gdb/testsuite/gdb.arch/thumb-singlestep.exp b/gdb/testsuite/gdb.arch/thumb-singlestep.exp
> index 289bdf52463..c3b7999036e 100644
> --- a/gdb/testsuite/gdb.arch/thumb-singlestep.exp
> +++ b/gdb/testsuite/gdb.arch/thumb-singlestep.exp
> @@ -15,10 +15,7 @@
>   
>   # Test single-stepping into incorrectly marked Thumb routine
>   
> -if {![is_aarch32_target]} {
> -    verbose "Skipping ARM tests."
> -    return
> -}
> +require is_aarch32_target
>   
>   set testfile "thumb-singlestep"
>   set srcfile ${testfile}.S

LGTM.

diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.arch/arm-bl-branch-dest.exp b/gdb/testsuite/gdb.arch/arm-bl-branch-dest.exp
index 34d98aec96e..37710649005 100644
--- a/gdb/testsuite/gdb.arch/arm-bl-branch-dest.exp
+++ b/gdb/testsuite/gdb.arch/arm-bl-branch-dest.exp
@@ -13,10 +13,7 @@ 
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-if { ![is_aarch32_target] } {
-    verbose "Skipping ${gdb_test_file_name}."
-    return
-}
+require is_aarch32_target
 
 standard_testfile
 
diff --git a/gdb/testsuite/gdb.arch/arm-disp-step.exp b/gdb/testsuite/gdb.arch/arm-disp-step.exp
index ec6578257b3..0eb1707bb6c 100644
--- a/gdb/testsuite/gdb.arch/arm-disp-step.exp
+++ b/gdb/testsuite/gdb.arch/arm-disp-step.exp
@@ -17,10 +17,7 @@ 
 
 # Test arm displaced stepping.
 
-if {![is_aarch32_target]} {
-    verbose "Skipping arm displaced stepping tests."
-    return
-}
+require is_aarch32_target
 
 standard_testfile .S
 
diff --git a/gdb/testsuite/gdb.arch/arm-single-step-kernel-helper.exp b/gdb/testsuite/gdb.arch/arm-single-step-kernel-helper.exp
index c3544b16a0b..22a2559b271 100644
--- a/gdb/testsuite/gdb.arch/arm-single-step-kernel-helper.exp
+++ b/gdb/testsuite/gdb.arch/arm-single-step-kernel-helper.exp
@@ -13,10 +13,7 @@ 
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-if { ![is_aarch32_target] } {
-    verbose "Skipping ${gdb_test_file_name}."
-    return
-}
+require is_aarch32_target
 
 standard_testfile
 
diff --git a/gdb/testsuite/gdb.arch/pr25124.exp b/gdb/testsuite/gdb.arch/pr25124.exp
index a68a3d1b7df..95636bd1ed8 100644
--- a/gdb/testsuite/gdb.arch/pr25124.exp
+++ b/gdb/testsuite/gdb.arch/pr25124.exp
@@ -16,10 +16,7 @@ 
 # Test proper disassembling of ARM thumb instructions when reloading a symbol
 # file.
 
-if {![is_aarch32_target]} {
-    verbose "Skipping ARM tests."
-    return
-}
+require is_aarch32_target
 
 standard_testfile .S
 
diff --git a/gdb/testsuite/gdb.arch/thumb-bx-pc.exp b/gdb/testsuite/gdb.arch/thumb-bx-pc.exp
index ccc6fbfdca7..6989d79c6d6 100644
--- a/gdb/testsuite/gdb.arch/thumb-bx-pc.exp
+++ b/gdb/testsuite/gdb.arch/thumb-bx-pc.exp
@@ -15,10 +15,7 @@ 
 
 # Test PC adjustment from Thumb-mode "bx pc" instruction.
 
-if {![is_aarch32_target]} {
-    verbose "Skipping ARM tests."
-    return
-}
+require is_aarch32_target
 
 set testfile "thumb-bx-pc"
 set srcfile ${testfile}.S
diff --git a/gdb/testsuite/gdb.arch/thumb-prologue.exp b/gdb/testsuite/gdb.arch/thumb-prologue.exp
index 0cb14572345..8e83bd3c009 100644
--- a/gdb/testsuite/gdb.arch/thumb-prologue.exp
+++ b/gdb/testsuite/gdb.arch/thumb-prologue.exp
@@ -15,10 +15,7 @@ 
 
 # Test ARM/Thumb prologue analyzer.
 
-if {![is_aarch32_target]} {
-    verbose "Skipping ARM prologue tests."
-    return
-}
+require is_aarch32_target
 
 standard_testfile
 
diff --git a/gdb/testsuite/gdb.arch/thumb-singlestep.exp b/gdb/testsuite/gdb.arch/thumb-singlestep.exp
index 289bdf52463..c3b7999036e 100644
--- a/gdb/testsuite/gdb.arch/thumb-singlestep.exp
+++ b/gdb/testsuite/gdb.arch/thumb-singlestep.exp
@@ -15,10 +15,7 @@ 
 
 # Test single-stepping into incorrectly marked Thumb routine
 
-if {![is_aarch32_target]} {
-    verbose "Skipping ARM tests."
-    return
-}
+require is_aarch32_target
 
 set testfile "thumb-singlestep"
 set srcfile ${testfile}.S