>This changes some tests to use "require skip_btrace_tests".
>---
> gdb/testsuite/gdb.btrace/buffer-size.exp | 5 +----
> gdb/testsuite/gdb.btrace/data.exp | 5 +----
> gdb/testsuite/gdb.btrace/delta.exp | 5 +----
> gdb/testsuite/gdb.btrace/enable-new-thread.exp | 5 +----
> gdb/testsuite/gdb.btrace/enable-running.exp | 5 +----
> gdb/testsuite/gdb.btrace/enable.exp | 5 +----
> gdb/testsuite/gdb.btrace/exception.exp | 5 +----
> gdb/testsuite/gdb.btrace/function_call_history.exp | 5 +----
> gdb/testsuite/gdb.btrace/gcore.exp | 5 +----
> gdb/testsuite/gdb.btrace/instruction_history.exp | 5 +----
> gdb/testsuite/gdb.btrace/multi-inferior.exp | 5 +----
> gdb/testsuite/gdb.btrace/multi-thread-step.exp | 5 +----
> gdb/testsuite/gdb.btrace/nohist.exp | 5 +----
> gdb/testsuite/gdb.btrace/non-stop.exp | 5 +----
> gdb/testsuite/gdb.btrace/reconnect.exp | 5 +----
> gdb/testsuite/gdb.btrace/record_goto-step.exp | 5 +----
> gdb/testsuite/gdb.btrace/record_goto.exp | 5 +----
> gdb/testsuite/gdb.btrace/rn-dl-bind.exp | 5 +----
> gdb/testsuite/gdb.btrace/segv.exp | 5 +----
> gdb/testsuite/gdb.btrace/step.exp | 5 +----
> gdb/testsuite/gdb.btrace/stepi.exp | 5 +----
> gdb/testsuite/gdb.btrace/tailcall-only.exp | 5 +----
> gdb/testsuite/gdb.btrace/tailcall.exp | 5 +----
> gdb/testsuite/gdb.btrace/unknown_functions.exp | 5 +----
> gdb/testsuite/gdb.btrace/vdso.exp | 5 +----
> gdb/testsuite/gdb.python/py-record-btrace-threads.exp | 5 +----
> gdb/testsuite/gdb.python/py-record-btrace.exp | 5 +----
> 27 files changed, 27 insertions(+), 108 deletions(-)
LGTM with two nits and a general comment below.
>-if { [skip_btrace_tests] } {
>- unsupported "target does not support record-btrace"
>- return -1
>-}
>+require !skip_btrace_tests
This looks a little bit odd, now, and the ! is easy to miss. Those skip checks
should probably be rewritten as support checks to fit better into the new
require logic.
>-if { [skip_btrace_tests] } {
>- unsupported "target does not support record-btrace"
>- return -1
>-}
>+require !skip_btrace_tests
>
> if { [use_gdb_stub] } {
> unsupported "test creates multiple inferiors"
Should this be
require !skip_btrace_tests !use_gdb_stub
>-if { [skip_btrace_tests] } {
>- unsupported "target does not support record-btrace"
>- return -1
>-}
>+require !skip_btrace_tests
> if { [skip_gdbserver_tests] } {
> unsupported "target does not support gdbserver"
> return -1
Same here with skip_gdbserver_tests.
regards,
markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
@@ -17,10 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
standard_testfile record_goto.c
if [prepare_for_testing "failed to prepare" $testfile $srcfile] {
@@ -17,10 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
standard_testfile
if [prepare_for_testing "failed to prepare" $testfile $srcfile] {
@@ -17,10 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
standard_testfile record_goto.c
if [prepare_for_testing "failed to prepare" $testfile $srcfile] {
@@ -17,10 +17,7 @@
# Test that new threads of recorded inferiors also get recorded.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
standard_testfile
if [prepare_for_testing "failed to prepare" $testfile $srcfile {debug pthreads}] {
@@ -15,10 +15,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
standard_testfile
if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" "$binfile" executable {debug}] != "" } {
@@ -17,10 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
# start fresh - without an executable
gdb_exit
@@ -17,10 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
# We expect a specific function call history. This gets messed up with
# PIE on 32-bit.
@@ -17,10 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
# We expect a specific function call history. This gets messed up with
# PIE on 32-bit.
@@ -17,10 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
standard_testfile record_goto.c
if [prepare_for_testing "failed to prepare" $testfile $srcfile] {
@@ -17,10 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
standard_testfile .c .S
if [prepare_for_testing "failed to prepare" $testfile "$srcfile $srcfile2" {debug}] {
@@ -22,10 +22,7 @@
#
# Each inferior can be recorded separately.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
if { [use_gdb_stub] } {
unsupported "test creates multiple inferiors"
@@ -17,10 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
standard_testfile
if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" "$binfile" executable {debug}] != "" } {
@@ -17,10 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
standard_testfile record_goto.c
if [prepare_for_testing "failed to prepare" $testfile $srcfile] {
@@ -15,10 +15,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
standard_testfile
if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" "$binfile" executable {debug}] != "" } {
@@ -19,10 +19,7 @@
load_lib gdbserver-support.exp
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
if { [skip_gdbserver_tests] } {
unsupported "target does not support gdbserver"
return -1
@@ -17,10 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
standard_testfile record_goto.c
if [prepare_for_testing "failed to prepare" $testfile $srcfile] {
@@ -17,10 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
# The "record goto" command jumps to a specific instruction in the execution
# trace. To guarantee that we always get the same execution trace, we use
@@ -21,10 +21,7 @@
# Test that we can reverse-next over the dynamic linker's symbol
# lookup code.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
standard_testfile
if [prepare_for_testing "failed to prepare" $testfile $srcfile \
@@ -17,10 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
standard_testfile
if [prepare_for_testing "failed to prepare" $testfile $srcfile] {
@@ -17,10 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
standard_testfile record_goto.c
if [prepare_for_testing "failed to prepare" $testfile $srcfile] {
@@ -17,10 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
# This test is stepping on instruction level. To guarantee that we always
# get the same execution trace, we use an assembly source file.
@@ -20,10 +20,7 @@
# calls. This used to cause a crash in get_frame_type.
#
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
# This test requires the compiler to generate a tail call. To guarantee that
# we always get one, we use an assembly source file.
@@ -17,10 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
# This test requires the compiler to generate a tail call. To guarantee that
# we always get one, we use an assembly source file.
@@ -17,10 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
standard_testfile
@@ -20,10 +20,7 @@
#
# Test that we can access the vdso memory during replay for stepping.
-if { [skip_btrace_tests] } {
- unsupported "target does not support record-btrace"
- return -1
-}
+require !skip_btrace_tests
standard_testfile
if [prepare_for_testing "failed to prepare" $testfile $srcfile] {
@@ -17,10 +17,7 @@
# Skip this test if btrace is disabled.
-if { [skip_btrace_tests] } {
- untested "skipping btrace tests"
- return -1
-}
+require !skip_btrace_tests
standard_testfile
@@ -17,10 +17,7 @@
# Skip this test if btrace is disabled.
-if { [skip_btrace_tests] } {
- untested "skipping btrace tests"
- return -1
-}
+require !skip_btrace_tests
load_lib gdb-python.exp