diff mbox series

[21/46] Use require skip_btrace_tests

Message ID	20221217000818.3729389-22-tom@tromey.com
State	Committed
Headers	DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2DBB2383600A From: Tom Tromey <tom@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey <tom@tromey.com> Subject: [PATCH 21/46] Use require skip_btrace_tests Date: Fri, 16 Dec 2022 17:07:53 -0700 Message-Id: <20221217000818.3729389-22-tom@tromey.com> In-Reply-To: <20221217000818.3729389-1-tom@tromey.com> References: <20221217000818.3729389-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org>
Series	Rewrite "require" test procedure and use it more often \| [00/46] Rewrite "require" test procedure and use it more often [01/46] Don't use ensure_gdb_index with require [02/46] Change 'require' to accept a list of predicates [03/46] Use unsupported in 'require' [04/46] Use require supports_reverse [05/46] Use require supports_process_record [06/46] Use require dwarf2_support [07/46] Use require is_x86_like_target [08/46] Use require skip_cplus_tests [09/46] Use require skip_shlib_tests [10/46] Use require skip_dlmopen_tests [11/46] Use require skip_stl_tests [12/46] Use require skip_rust_tests [13/46] Use require skip_fortran_tests [14/46] Use require skip_ada_tests [15/46] Use require skip_go_tests [16/46] Use require skip_d_tests [17/46] Use require skip_ctf_tests [18/46] Use require skip_hw_watchpoint_tests [19/46] Use require skip_ifunc_tests [20/46] Use require skip_aarch64_sve_tests [21/46] Use require skip_btrace_tests [22/46] Use require skip_btrace_tests [23/46] Use require skip_avx_* [24/46] Use require support_displaced_stepping [25/46] Use require is_aarch64_target [26/46] Use require is_aarch32_target [27/46] Use require is_amd64_regs_target [28/46] Use require is_elf_target [29/46] Use require can_single_step_to_signal_handler [30/46] Use require supports_get_siginfo_type [31/46] Use require support_go_compile [32/46] Use require use_gdb_stub [33/46] Use require can_spawn_for_attach [34/46] Use require isnative [35/46] Use require skip_gdbserver_tests [36/46] Use require skip_shlib_tests [37/46] Use require is_c_compiler_gcc [38/46] Use require gdb_debug_enabled [39/46] Use require gdb_skip_xml_test [40/46] Use require gdb_trace_common_supports_arch [41/46] Use require skip_perf_tests [42/46] Use require skip_opencl_tests [43/46] Use require target_can_use_run_cmd [44/46] Use require using_fission [45/46] Use require skip_debuginfod_tests [46/46] Use require gnat_runtime_has_debug_info

Commit Message

Tom Tromey Dec. 17, 2022, 12:07 a.m. UTC

  This changes some tests to use "require skip_btrace_tests" and
"require skip_tsx_tests".
---
 gdb/testsuite/gdb.btrace/tsx.exp | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

Comments

Enze Li Dec. 17, 2022, 1:15 a.m. UTC | #1

Hi Tom,

Just one nit.  skip_btrace_tests -> skip_btrace_pt_tests in the subject.

On Fri, Dec 16 2022 at 05:07:53 PM -0700, Tom Tromey wrote:

> This changes some tests to use "require skip_btrace_tests" and
> "require skip_tsx_tests".

Likewise here.

Thanks,
Enze

> ---
>  gdb/testsuite/gdb.btrace/tsx.exp | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.btrace/tsx.exp b/gdb/testsuite/gdb.btrace/tsx.exp
> index c055b0ae409..81b71b1fef9 100644
> --- a/gdb/testsuite/gdb.btrace/tsx.exp
> +++ b/gdb/testsuite/gdb.btrace/tsx.exp
> @@ -15,15 +15,7 @@
>  # You should have received a copy of the GNU General Public License
>  # along with this program.  If not, see <http://www.gnu.org/licenses/>.
>  
> -if { [skip_btrace_pt_tests] } {
> -    unsupported "target does not support PT"
> -    return -1
> -}
> -
> -if { [skip_tsx_tests] } {
> -    unsupported "target does not support TSX"
> -    return -1
> -}
> +require !skip_btrace_pt_tests !skip_tsx_tests
>  
>  standard_testfile .c x86-tsx.S
>  if [prepare_for_testing "failed to prepare" $testfile "$srcfile $srcfile2" {debug}] {

Tom Tromey Dec. 18, 2022, 12:48 a.m. UTC | #2

Enze> Just one nit.  skip_btrace_tests -> skip_btrace_pt_tests in the subject.

Thanks, I fixed this.

Tom

Enze Li Dec. 19, 2022, 5:13 a.m. UTC | #3

On Sat, Dec 17 2022 at 05:48:50 PM -0700, Tom Tromey wrote:

> Enze> Just one nit.  skip_btrace_tests -> skip_btrace_pt_tests in the subject.
>
> Thanks, I fixed this.
>
> Tom

I'm a little forgetful.  I created a pull request to your branch
"rewrite-require" a few days ago.  And, I dunno what's going on with
Github, it messed thing up.  I recreated one (#42), is that ok?

Best Regards,
Enze

Tom Tromey Dec. 19, 2022, 2:44 p.m. UTC | #4

>>>>> "Enze" == Enze Li <enze.li@hotmail.com> writes:

Enze> I'm a little forgetful.  I created a pull request to your branch
Enze> "rewrite-require" a few days ago.  And, I dunno what's going on with
Enze> Github, it messed thing up.  I recreated one (#42), is that ok?

I don't mind or anything, but I also don't look at issues or pull
requests there.  That repository is more just a spot for me to store
patches.

Tom

diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.btrace/tsx.exp b/gdb/testsuite/gdb.btrace/tsx.exp
index c055b0ae409..81b71b1fef9 100644
--- a/gdb/testsuite/gdb.btrace/tsx.exp
+++ b/gdb/testsuite/gdb.btrace/tsx.exp
@@ -15,15 +15,7 @@ 
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-if { [skip_btrace_pt_tests] } {
-    unsupported "target does not support PT"
-    return -1
-}
-
-if { [skip_tsx_tests] } {
-    unsupported "target does not support TSX"
-    return -1
-}
+require !skip_btrace_pt_tests !skip_tsx_tests
 
 standard_testfile .c x86-tsx.S
 if [prepare_for_testing "failed to prepare" $testfile "$srcfile $srcfile2" {debug}] {