Message ID | 20221217000818.3729389-22-tom@tromey.com |
---|---|
State | Committed |
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A7F793831E71 for <patchwork@sourceware.org>; Sat, 17 Dec 2022 00:13:04 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 2DBB2383600A for <gdb-patches@sourceware.org>; Sat, 17 Dec 2022 00:08:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2DBB2383600A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id A255410048541 for <gdb-patches@sourceware.org>; Sat, 17 Dec 2022 00:08:40 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 6Kkqp9EmhR8oI6KkqpfX3Z; Sat, 17 Dec 2022 00:08:40 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DseTREz+ c=1 sm=1 tr=0 ts=639d0888 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=sHyYjHe8cH0A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=mDV3o1hIAAAA:8 a=moFOZKqDViEG0xA1rNIA:9 a=_FVE-zBwftR9WsbkzFJk:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=twdmKn/dcj/EggKRhkKdjpjQQugwprNv6uU2W47TTAo=; b=yOheTTBJf1LgKcakPIVDJunnho 8zci+Te4KrT5m9zc6wxNx1a1EDwsWW/TflhJv7ux1hUFCnUqwLQZDut1uPvRJcGpkaFx1bWY8AgiQ Pa9SU4KrTwT0utW9WhHwHAndF; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:58422 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from <tom@tromey.com>) id 1p6Kkq-002gox-Fv; Fri, 16 Dec 2022 17:08:40 -0700 From: Tom Tromey <tom@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey <tom@tromey.com> Subject: [PATCH 21/46] Use require skip_btrace_tests Date: Fri, 16 Dec 2022 17:07:53 -0700 Message-Id: <20221217000818.3729389-22-tom@tromey.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221217000818.3729389-1-tom@tromey.com> References: <20221217000818.3729389-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1p6Kkq-002gox-Fv X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (localhost.localdomain) [97.122.76.186]:58422 X-Source-Auth: tom+tromey.com X-Email-Count: 22 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3028.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
Rewrite "require" test procedure and use it more often
|
|
Commit Message
Tom Tromey
Dec. 17, 2022, 12:07 a.m. UTC
This changes some tests to use "require skip_btrace_tests" and "require skip_tsx_tests". --- gdb/testsuite/gdb.btrace/tsx.exp | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)
Comments
Hi Tom, Just one nit. skip_btrace_tests -> skip_btrace_pt_tests in the subject. On Fri, Dec 16 2022 at 05:07:53 PM -0700, Tom Tromey wrote: > This changes some tests to use "require skip_btrace_tests" and > "require skip_tsx_tests". Likewise here. Thanks, Enze > --- > gdb/testsuite/gdb.btrace/tsx.exp | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/gdb/testsuite/gdb.btrace/tsx.exp b/gdb/testsuite/gdb.btrace/tsx.exp > index c055b0ae409..81b71b1fef9 100644 > --- a/gdb/testsuite/gdb.btrace/tsx.exp > +++ b/gdb/testsuite/gdb.btrace/tsx.exp > @@ -15,15 +15,7 @@ > # You should have received a copy of the GNU General Public License > # along with this program. If not, see <http://www.gnu.org/licenses/>. > > -if { [skip_btrace_pt_tests] } { > - unsupported "target does not support PT" > - return -1 > -} > - > -if { [skip_tsx_tests] } { > - unsupported "target does not support TSX" > - return -1 > -} > +require !skip_btrace_pt_tests !skip_tsx_tests > > standard_testfile .c x86-tsx.S > if [prepare_for_testing "failed to prepare" $testfile "$srcfile $srcfile2" {debug}] {
Enze> Just one nit. skip_btrace_tests -> skip_btrace_pt_tests in the subject. Thanks, I fixed this. Tom
On Sat, Dec 17 2022 at 05:48:50 PM -0700, Tom Tromey wrote: > Enze> Just one nit. skip_btrace_tests -> skip_btrace_pt_tests in the subject. > > Thanks, I fixed this. > > Tom I'm a little forgetful. I created a pull request to your branch "rewrite-require" a few days ago. And, I dunno what's going on with Github, it messed thing up. I recreated one (#42), is that ok? Best Regards, Enze
>>>>> "Enze" == Enze Li <enze.li@hotmail.com> writes:
Enze> I'm a little forgetful. I created a pull request to your branch
Enze> "rewrite-require" a few days ago. And, I dunno what's going on with
Enze> Github, it messed thing up. I recreated one (#42), is that ok?
I don't mind or anything, but I also don't look at issues or pull
requests there. That repository is more just a spot for me to store
patches.
Tom
diff --git a/gdb/testsuite/gdb.btrace/tsx.exp b/gdb/testsuite/gdb.btrace/tsx.exp index c055b0ae409..81b71b1fef9 100644 --- a/gdb/testsuite/gdb.btrace/tsx.exp +++ b/gdb/testsuite/gdb.btrace/tsx.exp @@ -15,15 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_pt_tests] } { - unsupported "target does not support PT" - return -1 -} - -if { [skip_tsx_tests] } { - unsupported "target does not support TSX" - return -1 -} +require !skip_btrace_pt_tests !skip_tsx_tests standard_testfile .c x86-tsx.S if [prepare_for_testing "failed to prepare" $testfile "$srcfile $srcfile2" {debug}] {