From patchwork Mon Dec 12 20:30:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 61826 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0A8F538475B6 for ; Mon, 12 Dec 2022 20:31:40 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by sourceware.org (Postfix) with ESMTPS id E3070384E7AC for ; Mon, 12 Dec 2022 20:31:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E3070384E7AC Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f44.google.com with SMTP id ay40so6608875wmb.2 for ; Mon, 12 Dec 2022 12:31:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nOAAHUzqDjfmDf5gOyPbbyMsRTjTjPYR0NjNluJ5W+I=; b=mBYyo4arDn3mFR+Giwy/6ZIQKYRmbkiTCivmXhmYc/0A7iEFuWND2s3DIEpGtDdt+y 1PMJzrhqwHQgC/+DC9rnGJTvISPRSJCJT4TXTGS6dt7ASXqLB4eBb6AS19gAI07ovRQ/ 6zGrAYYpHU81YnY8jWzCthHhP/cA/5x49gKbcaAGfDZanVLWMkCl3ksnmakJuAojlAIH FCowyIO/f51PAt8TR6GM9qujNgFFZ0vToj72OCSDkvmZ07LWueMpkG1I3Ci2Bgcmwz2w 1utOQpjVaNv2HckNp1JFWhZWjINBM44R+seGJdXzl857PmWWLGQZ4UU02JJS/INVHHII Yiqw== X-Gm-Message-State: ANoB5pneld/kKghaChM7TZWmndmm8jdWLhyTHHfsK+Vj5IuFhdjVIf3x 0htw+1f4OAyseRFeuxzE0hAwmRCQ6OEhXQ== X-Google-Smtp-Source: AA0mqf7dTHcgu1CP6cDij11tnkGNKI8ZX+QARsCJaTbtzO1HTkCX1mq76UleHlnsT7zNSW73xwlIHA== X-Received: by 2002:a05:600c:3b16:b0:3d2:267d:64da with SMTP id m22-20020a05600c3b1600b003d2267d64damr3959852wms.10.1670877064708; Mon, 12 Dec 2022 12:31:04 -0800 (PST) Received: from localhost ([2001:8a0:f912:6700:afd9:8b6d:223f:6170]) by smtp.gmail.com with ESMTPSA id k18-20020a05600c1c9200b003d22528decesm6520877wms.43.2022.12.12.12.31.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 12:31:04 -0800 (PST) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 06/31] Avoid duplicate QThreadEvents packets Date: Mon, 12 Dec 2022 20:30:36 +0000 Message-Id: <20221212203101.1034916-7-pedro@palves.net> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20221212203101.1034916-1-pedro@palves.net> References: <20221212203101.1034916-1-pedro@palves.net> MIME-Version: 1.0 X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Similarly to QProgramSignals and QPassSignals, avoid sending duplicate QThreadEvents packets. Change-Id: Iaf5babb0b64e1527ba4db31aac8674d82b17e8b4 --- gdb/remote.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gdb/remote.c b/gdb/remote.c index a7430eb79dd..41348a65dc4 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -314,6 +314,10 @@ class remote_state the target know about program signals list changes. */ char *last_program_signals_packet = nullptr; + /* Similarly, the last QThreadEvents state we sent to the + target. */ + bool last_thread_events = false; + gdb_signal last_sent_signal = GDB_SIGNAL_0; bool last_sent_step = false; @@ -14507,6 +14511,9 @@ remote_target::thread_events (int enable) if (packet_support (PACKET_QThreadEvents) == PACKET_DISABLE) return; + if (rs->last_thread_events == enable) + return; + xsnprintf (rs->buf.data (), size, "QThreadEvents:%x", enable ? 1 : 0); putpkt (rs->buf); getpkt (&rs->buf, 0); @@ -14517,6 +14524,7 @@ remote_target::thread_events (int enable) case PACKET_OK: if (strcmp (rs->buf.data (), "OK") != 0) error (_("Remote refused setting thread events: %s"), rs->buf.data ()); + rs->last_thread_events = enable; break; case PACKET_ERROR: warning (_("Remote failure reply: %s"), rs->buf.data ());