diff mbox series

[29/31] inferior::clear_thread_list always silent

Message ID	20221212203101.1034916-30-pedro@palves.net
State	New
Headers	DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4F54F3847596 From: Pedro Alves <pedro@palves.net> To: gdb-patches@sourceware.org Subject: [PATCH 29/31] inferior::clear_thread_list always silent Date: Mon, 12 Dec 2022 20:30:59 +0000 Message-Id: <20221212203101.1034916-30-pedro@palves.net> In-Reply-To: <20221212203101.1034916-1-pedro@palves.net> References: <20221212203101.1034916-1-pedro@palves.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org>
Series	Step over thread clone and thread exit \| [00/31] Step over thread clone and thread exit [01/31] displaced step: pass down target_waitstatus instead of gdb_signal [02/31] linux-nat: introduce pending_status_str [03/31] gdb/linux: Delete all other LWPs immediately on ptrace exec event [04/31] Step over clone syscall w/ breakpoint, TARGET_WAITKIND_THREAD_CLONED [05/31] Support clone events in the remote protocol [06/31] Avoid duplicate QThreadEvents packets [07/31] enum_flags to_string [08/31] Thread options & clone events (core + remote) [09/31] Thread options & clone events (native Linux) [10/31] Thread options & clone events (Linux GDBserver) [11/31] gdbserver: Hide and don't detach pending clone children [12/31] Remove gdb/19675 kfails (displaced stepping + clone) [13/31] Add test for stepping over clone syscall [14/31] all-stop/synchronous RSP support thread-exit events [15/31] gdbserver/linux-low.cc: Ignore event_ptid if TARGET_WAITKIND_IGNORE [16/31] Move deleting thread on TARGET_WAITKIND_THREAD_EXITED to core [17/31] Introduce GDB_THREAD_OPTION_EXIT thread option, fix step-over-thread-exit [18/31] Implement GDB_THREAD_OPTION_EXIT support for Linux GDBserver [19/31] Implement GDB_THREAD_OPTION_EXIT support for native Linux [20/31] gdb: clear step over information on thread exit (PR gdb/27338) [21/31] stop_all_threads: (re-)enable async before waiting for stops [22/31] gdbserver: Queue no-resumed event after thread exit [23/31] Don't resume new threads if scheduler-locking is in effect [24/31] Report thread exit event for leader if reporting thread exit events [25/31] Ignore failure to read PC when resuming [26/31] gdb/testsuite/lib/my-syscalls.S: Refactor new SYSCALL macro [27/31] Testcases for stepping over thread exit syscall (PR gdb/27338) [28/31] Document remote clone events, and QThreadOptions packet [29/31] inferior::clear_thread_list always silent [30/31] Centralize "[Thread ...exited]" notifications [31/31] Cancel execution command on thread exit, when stepping, nexting, etc.

Commit Message

Pedro Alves Dec. 12, 2022, 8:30 p.m. UTC

  Now that the MI mi_thread_exit observer ignores "silent", there's no
difference between inferior::clean_thread_list with silent true or
false.  And for the CLI, clean_thread_list() never printed anything
either.  So we can eliminate the 'silent' parameter.

Change-Id: I90ff9f07537d22ea70986fbcfe8819cac7e06613
---
 gdb/inferior.c | 12 ++++++------
 gdb/inferior.h |  5 ++---
 gdb/thread.c   |  2 +-
 3 files changed, 9 insertions(+), 10 deletions(-)

Comments

Andrew Burgess June 12, 2023, 12:20 p.m. UTC | #1

Pedro Alves <pedro@palves.net> writes:

> Now that the MI mi_thread_exit observer ignores "silent", there's no
> difference between inferior::clean_thread_list with silent true or
> false.  And for the CLI, clean_thread_list() never printed anything
> either.  So we can eliminate the 'silent' parameter.
>
> Change-Id: I90ff9f07537d22ea70986fbcfe8819cac7e06613
> ---
>  gdb/inferior.c | 12 ++++++------
>  gdb/inferior.h |  5 ++---
>  gdb/thread.c   |  2 +-
>  3 files changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/gdb/inferior.c b/gdb/inferior.c
> index 23cbfd63bde..eacb65ec1d7 100644
> --- a/gdb/inferior.c
> +++ b/gdb/inferior.c
> @@ -168,13 +168,13 @@ add_inferior (int pid)
>  /* See inferior.h.  */
>  
>  void
> -inferior::clear_thread_list (bool silent)
> +inferior::clear_thread_list ()
>  {
>    thread_list.clear_and_dispose ([=] (thread_info *thr)
>      {
> -      threads_debug_printf ("deleting thread %s, silent = %d",
> -			    thr->ptid.to_string ().c_str (), silent);
> -      set_thread_exited (thr, silent);
> +      threads_debug_printf ("deleting thread %s",
> +			    thr->ptid.to_string ().c_str ());
> +      set_thread_exited (thr, true);
>        if (thr->deletable ())
>  	delete thr;
>      });
> @@ -184,7 +184,7 @@ inferior::clear_thread_list (bool silent)
>  void
>  delete_inferior (struct inferior *inf)
>  {
> -  inf->clear_thread_list (true);
> +  inf->clear_thread_list ();
>  
>    auto it = inferior_list.iterator_to (*inf);
>    inferior_list.erase (it);
> @@ -204,7 +204,7 @@ delete_inferior (struct inferior *inf)
>  static void
>  exit_inferior_1 (struct inferior *inf, int silent)
>  {
> -  inf->clear_thread_list (silent);
> +  inf->clear_thread_list ();

If you wanted you could also remove SILENT from exit_inferior_1 as I
don't believe it is used there now either.

Which would then allow exit_inferior and exit_inferior_silent to be
merged.

... or this can be done in a follow up patch.

Reviewed-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew

>  
>    gdb::observers::inferior_exit.notify (inf);
>  
> diff --git a/gdb/inferior.h b/gdb/inferior.h
> index 69525a2e053..07d9527a802 100644
> --- a/gdb/inferior.h
> +++ b/gdb/inferior.h
> @@ -425,9 +425,8 @@ class inferior : public refcounted_object,
>    inline safe_inf_threads_range threads_safe ()
>    { return safe_inf_threads_range (this->thread_list.begin ()); }
>  
> -  /* Delete all threads in the thread list.  If SILENT, exit threads
> -     silently.  */
> -  void clear_thread_list (bool silent);
> +  /* Delete all threads in the thread list, silently.  */
> +  void clear_thread_list ();
>  
>    /* Continuations-related methods.  A continuation is an std::function
>       to be called to finish the execution of a command when running
> diff --git a/gdb/thread.c b/gdb/thread.c
> index 2c45d528bba..2ca3a867d8c 100644
> --- a/gdb/thread.c
> +++ b/gdb/thread.c
> @@ -235,7 +235,7 @@ init_thread_list (void)
>    highest_thread_num = 0;
>  
>    for (inferior *inf : all_inferiors ())
> -    inf->clear_thread_list (true);
> +    inf->clear_thread_list ();
>  }
>  
>  /* Allocate a new thread of inferior INF with target id PTID and add
> -- 
> 2.36.0

diff mbox series

Patch

diff --git a/gdb/inferior.c b/gdb/inferior.c
index 23cbfd63bde..eacb65ec1d7 100644
--- a/gdb/inferior.c
+++ b/gdb/inferior.c
@@ -168,13 +168,13 @@  add_inferior (int pid)
 /* See inferior.h.  */
 
 void
-inferior::clear_thread_list (bool silent)
+inferior::clear_thread_list ()
 {
   thread_list.clear_and_dispose ([=] (thread_info *thr)
     {
-      threads_debug_printf ("deleting thread %s, silent = %d",
-			    thr->ptid.to_string ().c_str (), silent);
-      set_thread_exited (thr, silent);
+      threads_debug_printf ("deleting thread %s",
+			    thr->ptid.to_string ().c_str ());
+      set_thread_exited (thr, true);
       if (thr->deletable ())
 	delete thr;
     });
@@ -184,7 +184,7 @@  inferior::clear_thread_list (bool silent)
 void
 delete_inferior (struct inferior *inf)
 {
-  inf->clear_thread_list (true);
+  inf->clear_thread_list ();
 
   auto it = inferior_list.iterator_to (*inf);
   inferior_list.erase (it);
@@ -204,7 +204,7 @@  delete_inferior (struct inferior *inf)
 static void
 exit_inferior_1 (struct inferior *inf, int silent)
 {
-  inf->clear_thread_list (silent);
+  inf->clear_thread_list ();
 
   gdb::observers::inferior_exit.notify (inf);
 
diff --git a/gdb/inferior.h b/gdb/inferior.h
index 69525a2e053..07d9527a802 100644
--- a/gdb/inferior.h
+++ b/gdb/inferior.h
@@ -425,9 +425,8 @@  class inferior : public refcounted_object,
   inline safe_inf_threads_range threads_safe ()
   { return safe_inf_threads_range (this->thread_list.begin ()); }
 
-  /* Delete all threads in the thread list.  If SILENT, exit threads
-     silently.  */
-  void clear_thread_list (bool silent);
+  /* Delete all threads in the thread list, silently.  */
+  void clear_thread_list ();
 
   /* Continuations-related methods.  A continuation is an std::function
      to be called to finish the execution of a command when running
diff --git a/gdb/thread.c b/gdb/thread.c
index 2c45d528bba..2ca3a867d8c 100644
--- a/gdb/thread.c
+++ b/gdb/thread.c
@@ -235,7 +235,7 @@  init_thread_list (void)
   highest_thread_num = 0;
 
   for (inferior *inf : all_inferiors ())
-    inf->clear_thread_list (true);
+    inf->clear_thread_list ();
 }
 
 /* Allocate a new thread of inferior INF with target id PTID and add