diff mbox series

[4/6] gdb/linux-nat: check ptrace return value in linux_nat_get_siginfo

Message ID 20221202200925.245955-4-simon.marchi@polymtl.ca
State Committed
Commit 7cc662bcb70fc4eb5a7b5883fd27fab0d4e372cb
Headers
Series [1/6] gdb/linux-nat: use get_ptrace_pid in two spots |

Commit Message

Simon Marchi Dec. 2, 2022, 8:09 p.m. UTC 
  Not a big deal, but it seems strange to check errno instead of the
ptrace return value to know whether it succeeded.

Change-Id: If0a6d0280ab0e5ecb077e546af0d6fe489c5b9fd
---
 gdb/linux-nat.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
diff mbox series

Patch

diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index c47b8db9299c..b33fac3d1492 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -4443,11 +4443,7 @@  bool
 linux_nat_get_siginfo (ptid_t ptid, siginfo_t *siginfo)
 {
   int pid = get_ptrace_pid (ptid);
-
-  errno = 0;
-  ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, siginfo);
-
-  return errno == 0;
+  return ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, siginfo) == 0;
 }
 
 /* See nat/linux-nat.h.  */