diff mbox series

[3/6] gdb/linux-nat: don't memset siginfo on failure in linux_nat_get_siginfo

Message ID 20221202200925.245955-3-simon.marchi@polymtl.ca
State Committed
Commit 8aa1556f2e88851f9bfcacd3f624c8182946a6f6
Headers
Series [1/6] gdb/linux-nat: use get_ptrace_pid in two spots |

Commit Message

Simon Marchi Dec. 2, 2022, 8:09 p.m. UTC 
  No caller cares about the value of *SIGINFO on failure.  It's also
documented in the function doc that *SIGINFO is uninitialized (I
understand "untouched") on failure.

Change-Id: I5ef38a5f58e3635e109b919ddf6f827f38f1225a
---
 gdb/linux-nat.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
diff mbox series

Patch

diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index 7b6a1f98d66d..c47b8db9299c 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -4446,12 +4446,8 @@  linux_nat_get_siginfo (ptid_t ptid, siginfo_t *siginfo)
 
   errno = 0;
   ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, siginfo);
-  if (errno != 0)
-    {
-      memset (siginfo, 0, sizeof (*siginfo));
-      return false;
-    }
-  return true;
+
+  return errno == 0;
 }
 
 /* See nat/linux-nat.h.  */