[pushed] gdb: make frame_register static

Message ID 20221201183249.1062823-1-simon.marchi@efficios.com
State Committed
Commit 77d2113f27eac3ad9b4dcaa7768b428dd7c59ae8
Headers
Series [pushed] gdb: make frame_register static |

Commit Message

Simon Marchi Dec. 1, 2022, 6:32 p.m. UTC
  From: Simon Marchi <simon.marchi@polymtl.ca>

It is only used inside frame.c.

Change-Id: I44eb46a5992412f8f8b4954b2284b0ef3b549504
---
 gdb/frame.c |  7 ++++++-
 gdb/frame.h | 11 -----------
 2 files changed, 6 insertions(+), 12 deletions(-)
  

Comments

Lancelot SIX Dec. 6, 2022, 2:52 p.m. UTC | #1
Hi Simon,

The function frame_register is used outside of frame.c in the rocgdb
downstream port.  Do you think we could revert this patch here?
Otherwise, this can be a change we keep downstream.

Best,
Lancelot.

On Thu, Dec 01, 2022 at 01:32:49PM -0500, Simon Marchi via Gdb-patches wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
> 
> It is only used inside frame.c.
> 
> Change-Id: I44eb46a5992412f8f8b4954b2284b0ef3b549504
> ---
>  gdb/frame.c |  7 ++++++-
>  gdb/frame.h | 11 -----------
>  2 files changed, 6 insertions(+), 12 deletions(-)
> 
> diff --git a/gdb/frame.c b/gdb/frame.c
> index c8c4ec817a42..b4079ef833e8 100644
> --- a/gdb/frame.c
> +++ b/gdb/frame.c
> @@ -1166,7 +1166,12 @@ frame_register_unwind (frame_info_ptr next_frame, int regnum,
>    release_value (value);
>  }
>  
> -void
> +/* Get the value of the register that belongs to this FRAME.  This
> +   function is a wrapper to the call sequence ``frame_register_unwind
> +   (get_next_frame (FRAME))''.  As per frame_register_unwind(), if
> +   VALUEP is NULL, the registers value is not fetched/computed.  */
> +
> +static void
>  frame_register (frame_info_ptr frame, int regnum,
>  		int *optimizedp, int *unavailablep, enum lval_type *lvalp,
>  		CORE_ADDR *addrp, int *realnump, gdb_byte *bufferp)
> diff --git a/gdb/frame.h b/gdb/frame.h
> index 6b841fd50636..100ab1fe48eb 100644
> --- a/gdb/frame.h
> +++ b/gdb/frame.h
> @@ -511,17 +511,6 @@ extern ULONGEST get_frame_register_unsigned (frame_info_ptr frame,
>  extern bool read_frame_register_unsigned (frame_info_ptr frame,
>  					  int regnum, ULONGEST *val);
>  
> -/* Get the value of the register that belongs to this FRAME.  This
> -   function is a wrapper to the call sequence ``frame_register_unwind
> -   (get_next_frame (FRAME))''.  As per frame_register_unwind(), if
> -   VALUEP is NULL, the registers value is not fetched/computed.  */
> -
> -extern void frame_register (frame_info_ptr frame, int regnum,
> -			    int *optimizedp, int *unavailablep,
> -			    enum lval_type *lvalp,
> -			    CORE_ADDR *addrp, int *realnump,
> -			    gdb_byte *valuep);
> -
>  /* The reverse.  Store a register value relative to the specified
>     frame.  Note: this call makes the frame's state undefined.  The
>     register and frame caches must be flushed.  */
> -- 
> 2.38.1
>
  
Simon Marchi Dec. 6, 2022, 3:43 p.m. UTC | #2
On 12/6/22 09:52, Lancelot SIX wrote:
> Hi Simon,
> 
> The function frame_register is used outside of frame.c in the rocgdb
> downstream port.  Do you think we could revert this patch here?
> Otherwise, this can be a change we keep downstream.

I think it would make sense to make the function non-static in the
downstream port, and then provide a patch that makes it non-static
upstream when submitting the code that needs it outside of frame.c.
Here, I happen to be involved in this port, but that is what I would
answer to anybody else in the same situation.

Simon
  

Patch

diff --git a/gdb/frame.c b/gdb/frame.c
index c8c4ec817a42..b4079ef833e8 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -1166,7 +1166,12 @@  frame_register_unwind (frame_info_ptr next_frame, int regnum,
   release_value (value);
 }
 
-void
+/* Get the value of the register that belongs to this FRAME.  This
+   function is a wrapper to the call sequence ``frame_register_unwind
+   (get_next_frame (FRAME))''.  As per frame_register_unwind(), if
+   VALUEP is NULL, the registers value is not fetched/computed.  */
+
+static void
 frame_register (frame_info_ptr frame, int regnum,
 		int *optimizedp, int *unavailablep, enum lval_type *lvalp,
 		CORE_ADDR *addrp, int *realnump, gdb_byte *bufferp)
diff --git a/gdb/frame.h b/gdb/frame.h
index 6b841fd50636..100ab1fe48eb 100644
--- a/gdb/frame.h
+++ b/gdb/frame.h
@@ -511,17 +511,6 @@  extern ULONGEST get_frame_register_unsigned (frame_info_ptr frame,
 extern bool read_frame_register_unsigned (frame_info_ptr frame,
 					  int regnum, ULONGEST *val);
 
-/* Get the value of the register that belongs to this FRAME.  This
-   function is a wrapper to the call sequence ``frame_register_unwind
-   (get_next_frame (FRAME))''.  As per frame_register_unwind(), if
-   VALUEP is NULL, the registers value is not fetched/computed.  */
-
-extern void frame_register (frame_info_ptr frame, int regnum,
-			    int *optimizedp, int *unavailablep,
-			    enum lval_type *lvalp,
-			    CORE_ADDR *addrp, int *realnump,
-			    gdb_byte *valuep);
-
 /* The reverse.  Store a register value relative to the specified
    frame.  Note: this call makes the frame's state undefined.  The
    register and frame caches must be flushed.  */