From patchwork Wed Nov 30 14:58:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 61264 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C56643855164 for ; Wed, 30 Nov 2022 14:58:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C56643855164 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669820334; bh=g19on0XD/RBU8hrIICiUysZpBSyeGQ2wkT8d5Q/jmuY=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=rt/0VxF6hek8w4oi8cxfrcRbHjPUFuYSrBuuOkOaYjwptmisdNgV6nAH547eTeQNm dLay+uIzOUY8JlpzhZoZXMzJILQ9kmDgxZQk+P/9qDjtj6aKAU8kcrg3DW9CoQn8Yz +B6ZTce4wnAI5VSqA46HiFr2PiXkHH6JiGoOqcf4= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 107E03858288 for ; Wed, 30 Nov 2022 14:58:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 107E03858288 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3D3C41F74C; Wed, 30 Nov 2022 14:58:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 25F0D1331F; Wed, 30 Nov 2022 14:58:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qc0qCJdvh2MXEQAAMHmgww (envelope-from ); Wed, 30 Nov 2022 14:58:31 +0000 To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH] [gdb/testsuite] Wait longer for core generation Date: Wed, 30 Nov 2022 15:58:30 +0100 Message-Id: <20221130145830.1535-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom de Vries via Gdb-patches From: Tom de Vries Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" When I run the gdb testsuite on a powerpc64le-linux system with (slow) nfs file system, I run into timeouts due to core generation, like for instance: ... (gdb) gcore $outputs/gdb.ada/task_switch_in_core/crash.gcore^M FAIL: gdb.ada/task_switch_in_core.exp: save a corefile (timeout) ... Fix this by using with_timeout_factor 3 in gdb_gcore_cmd. Tested on powerpc64le-linux. --- gdb/testsuite/lib/gdb.exp | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) base-commit: 016c606c66ce4b98c220130b9046545b04254a4a diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 23e3cc0c2d4..f41fc1375aa 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -5730,13 +5730,19 @@ proc gdb_gcore_cmd {core test} { global gdb_prompt set result 0 - gdb_test_multiple "gcore $core" $test { - -re "Saved corefile .*\[\r\n\]+$gdb_prompt $" { - pass $test - set result 1 - } - -re "(?:Can't create a corefile|Target does not support core file generation\\.)\[\r\n\]+$gdb_prompt $" { - unsupported $test + + set re_unsupported \ + "(?:Can't create a corefile|Target does not support core file generation\\.)" + + with_timeout_factor 3 { + gdb_test_multiple "gcore $core" $test { + -re -wrap "Saved corefile .*" { + pass $test + set result 1 + } + -re -wrap $re_unsupported { + unsupported $test + } } }