diff mbox series

[gdb/testsuite] Wait longer for core generation

Message ID 20221130145830.1535-1-tdevries@suse.de
State Committed
Headers
Series [gdb/testsuite] Wait longer for core generation |

Commit Message

Tom de Vries Nov. 30, 2022, 2:58 p.m. UTC 
  When I run the gdb testsuite on a powerpc64le-linux system with (slow) nfs
file system, I run into timeouts due to core generation, like for instance:
...
(gdb) gcore $outputs/gdb.ada/task_switch_in_core/crash.gcore^M
FAIL: gdb.ada/task_switch_in_core.exp: save a corefile (timeout)
...

Fix this by using with_timeout_factor 3 in gdb_gcore_cmd.

Tested on powerpc64le-linux.
---
 gdb/testsuite/lib/gdb.exp | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)


base-commit: 016c606c66ce4b98c220130b9046545b04254a4a

Comments

Tom Tromey Nov. 30, 2022, 9:25 p.m. UTC | #1 
>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> When I run the gdb testsuite on a powerpc64le-linux system with (slow) nfs
Tom> file system, I run into timeouts due to core generation, like for instance:
Tom> ...
Tom> (gdb) gcore $outputs/gdb.ada/task_switch_in_core/crash.gcore^M
Tom> FAIL: gdb.ada/task_switch_in_core.exp: save a corefile (timeout)
Tom> ...

Tom> Fix this by using with_timeout_factor 3 in gdb_gcore_cmd.

Tom> Tested on powerpc64le-linux.

This seems fine to me.

Tom
diff mbox series

Patch

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 23e3cc0c2d4..f41fc1375aa 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -5730,13 +5730,19 @@  proc gdb_gcore_cmd {core test} {
     global gdb_prompt
 
     set result 0
-    gdb_test_multiple "gcore $core" $test {
-	-re "Saved corefile .*\[\r\n\]+$gdb_prompt $" {
-	    pass $test
-	    set result 1
-	}
-	-re "(?:Can't create a corefile|Target does not support core file generation\\.)\[\r\n\]+$gdb_prompt $" {
-	    unsupported $test
+
+    set re_unsupported \
+	"(?:Can't create a corefile|Target does not support core file generation\\.)"
+
+    with_timeout_factor 3 {
+	gdb_test_multiple "gcore $core" $test {
+	    -re -wrap "Saved corefile .*" {
+		pass $test
+		set result 1
+	    }
+	    -re -wrap $re_unsupported {
+		unsupported $test
+	    }
 	}
     }