diff mbox series

[RFA] src-release.sh: Fix gdb source tarball build failure due to libsframe

Message ID 20221127125325.263577-1-brobecker@adacore.com
State New
Headers
Series [RFA] src-release.sh: Fix gdb source tarball build failure due to libsframe |

Commit Message

Joel Brobecker Nov. 27, 2022, 12:53 p.m. UTC 
  Hello,

This script was recently changed as follow:

    | commit e619dddb3a45780ae66d762756882a3b896b617d
    | Date:   Tue Nov 15 15:07:13 2022 -0800
    | Subject: src-release.sh: Add libsframe
    |
    | Add libsframe to the list of top level directories that will be included
    | in a release.

Since then, the gdb source tarball has been failing with the error
below during the "make configure-host configure-target" phase:

    | make[3]: *** No rule to make target '../libsframe/libsframe.la',
    |     needed by 'libbfd.la'.  Stop.
    | make[3]: Leaving directory '/tmp/gdb-public/bfd'

This patch fixes the issue by adding libsframe to the list of
GDB_SUPPORT_DIRS, similar to what was done for BINUTILS.

ChangeLog:

        * src-release.sh (GDB_SUPPORT_DIRS): Add libsframe.

Ok to apply to master?

NB: Once approved, I will take care of applying the patch to both
    binutils-gdb and gcc (hence the Cc: of gcc-patches).

Thank you,
---
 src-release.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Tromey Nov. 28, 2022, 2:44 p.m. UTC | #1 
>>>>> "Joel" == Joel Brobecker via Gdb-patches <gdb-patches@sourceware.org> writes:

Joel> ChangeLog:

Joel>         * src-release.sh (GDB_SUPPORT_DIRS): Add libsframe.

Joel> Ok to apply to master?

Looks good to me.
I think we recently agreed that gdb and binutils maintainers can approve
patches like this... ?

thanks,
Tom
Joel Brobecker Nov. 30, 2022, 3:37 a.m. UTC | #2 
> >>>>> "Joel" == Joel Brobecker via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Joel> ChangeLog:
> 
> Joel>         * src-release.sh (GDB_SUPPORT_DIRS): Add libsframe.
> 
> Joel> Ok to apply to master?
> 
> Looks good to me.
> I think we recently agreed that gdb and binutils maintainers can approve
> patches like this... ?

Thanks Tom. Pushed to master.

FTR, I thought this script was also part of the GCC repository,
but discovered that this is not the case when I tried to apply
the same patch there.
diff mbox series

Patch

diff --git a/src-release.sh b/src-release.sh
index 050a8eb958d..ec28f8691c7 100755
--- a/src-release.sh
+++ b/src-release.sh
@@ -322,7 +322,7 @@  gas_release()
     tar_compress $package $tool "$GAS_SUPPORT_DIRS" "$compressors"
 }
 
-GDB_SUPPORT_DIRS="bfd include libiberty libctf opcodes readline sim intl libdecnumber cpu zlib contrib gnulib gdbsupport gdbserver libbacktrace"
+GDB_SUPPORT_DIRS="libsframe bfd include libiberty libctf opcodes readline sim intl libdecnumber cpu zlib contrib gnulib gdbsupport gdbserver libbacktrace"
 gdb_release()
 {
     compressors=$1