From patchwork Wed Nov 23 18:39:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 61034 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 987FA384F6D1 for ; Wed, 23 Nov 2022 18:42:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 987FA384F6D1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669228955; bh=rli+B4tzRJkw7rwrUyBfISLtyQXxmCwzQbxzhPXIfbk=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=e83DX000i6V1pbTx7tgGHCgB1YD7GhxXuhxOgljAZ1O7mXGTVYvhZXxDOSrisjl3c cmdaPqYzjBaQcMWfRMX2nKx2+oTEtVBS5tSvcq6TtfX4XpJ55Gy91LPuXzldRqYiB5 YLylRs9m0jCfvL5S7/oU+VNIs954+FBB6zvoNsIY= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 6A42F38518A4 for ; Wed, 23 Nov 2022 18:42:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6A42F38518A4 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2ANIg5Od028135 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Nov 2022 13:42:10 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2ANIg5Od028135 Received: from simark.localdomain (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6D82D1E0CB; Wed, 23 Nov 2022 13:42:05 -0500 (EST) To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 08/14] gdb/testsuite/gdb.base/break.exp: split test_break_line_convenience_var Date: Wed, 23 Nov 2022 13:39:53 -0500 Message-Id: <20221123183959.2476477-9-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221123183959.2476477-1-simon.marchi@polymtl.ca> References: <20221123183959.2476477-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 23 Nov 2022 18:42:05 +0000 X-Spam-Status: No, score=-3189.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Simon Marchi via Gdb-patches From: Simon Marchi Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Change-Id: I593002373da971a0a4d6b5355d3fe321873479ab --- gdb/testsuite/gdb.base/break.exp | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/gdb/testsuite/gdb.base/break.exp b/gdb/testsuite/gdb.base/break.exp index d9cfeb9b21f0..cc327c195f46 100644 --- a/gdb/testsuite/gdb.base/break.exp +++ b/gdb/testsuite/gdb.base/break.exp @@ -604,18 +604,22 @@ gdb_test "break marker3" "Breakpoint.*at.*" "break marker3 #2" gdb_test "clear marker3" {Deleted breakpoints [0-9]+ [0-9]+.*} # Verify that a breakpoint can be set via a convenience variable. -# -with_test_prefix "set line breakpoint via convenience variable" { - gdb_test_no_output "set \$foo=$bp_location11" \ +proc_with_prefix test_break_line_convenience_var {} { + clean_restart break + + if { ![runto_main] } { + return + } + + gdb_test_no_output "set \$foo=$::bp_location11" \ "set convenience variable \$foo to bp_location11" gdb_test "break \$foo" \ - "Breakpoint (\[0-9\]*) at .*, line $bp_location11.*" + "Breakpoint (\[0-9\]*) at .*, line $::bp_location11.*" # Verify that GDB responds gracefully to an attempt to set a # breakpoint via a convenience variable whose type is not integer. - # gdb_test_no_output "set \$foo=81.5" \ "set convenience variable \$foo to 81.5" @@ -625,6 +629,8 @@ with_test_prefix "set line breakpoint via convenience variable" { "non-integer convenience variable disallowed" } +test_break_line_convenience_var + # Verify that we can set and trigger a breakpoint in a user-called function. proc_with_prefix test_break_user_call {} {