From patchwork Wed Nov 23 18:39:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 61032 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 24D7838518BF for ; Wed, 23 Nov 2022 18:41:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 24D7838518BF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669228862; bh=bOSTWqo3/IAW3QOkwDZwPm0nVakFLslIEyRD6OtzY6c=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=M9hg/Yo6ifRL8Y8G10nr3bQCwjKsWTOZcLelXitGxd5eXN5wm5BFmxFxBIsaUhWR9 XKZemip6wNagvhaLA4Luh02t8SHuImF1i7KqTevObfC1bh/wR4PA6y1cGDo45A+HAO 2nbgqiAmSTvPo9nOmZyu/duaZl0v1+fA4XJ35bYE= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id BDFEE38518A4 for ; Wed, 23 Nov 2022 18:40:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BDFEE38518A4 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2ANIe3TE026651 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Nov 2022 13:40:07 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2ANIe3TE026651 Received: from simark.localdomain (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D75171E11F; Wed, 23 Nov 2022 13:40:02 -0500 (EST) To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 01/14] gdb/testsuite/gdb.base/break.exp: split test_break_commands_clear Date: Wed, 23 Nov 2022 13:39:46 -0500 Message-Id: <20221123183959.2476477-2-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221123183959.2476477-1-simon.marchi@polymtl.ca> References: <20221123183959.2476477-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 23 Nov 2022 18:40:03 +0000 X-Spam-Status: No, score=-3189.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Simon Marchi via Gdb-patches From: Simon Marchi Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Change-Id: Ia58f90117d52fc419fc494836d9b4ed5d902fe9b --- gdb/testsuite/gdb.base/break.exp | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/gdb/testsuite/gdb.base/break.exp b/gdb/testsuite/gdb.base/break.exp index cb5831ac6103..c0756cdccc23 100644 --- a/gdb/testsuite/gdb.base/break.exp +++ b/gdb/testsuite/gdb.base/break.exp @@ -897,13 +897,21 @@ with_test_prefix "set line:file breakpoint via convenience variable" { "non-integer convenience variable disallowed" } -# # Test that commands can be cleared without error. -# -gdb_test "commands\nprint 232323\nend" ">end" "set some breakpoint commands" -gdb_test "commands\nend" ">end" "clear breakpoint commands" -# We verify that the commands were cleared by ensuring that the last -# breakpoint's location ends the output -- if there were commands, -# they would have been printed after the location. -gdb_test "info break" "$srcfile:$line_actual" "verify that they were cleared" +proc_with_prefix test_break_commands_clear {} { + clean_restart breako2 + + set line [gdb_get_line_number "set breakpoint 1 here"] + gdb_breakpoint $line + + gdb_test "commands\nprint 232323\nend" ">end" "set some breakpoint commands" + gdb_test "commands\nend" ">end" "clear breakpoint commands" + + # We verify that the commands were cleared by ensuring that the last + # breakpoint's location ends the output -- if there were commands, + # they would have been printed after the location. + gdb_test "info break" "$::srcfile:$::decimal" "verify that they were cleared" +} + +test_break_commands_clear