From patchwork Wed Nov 23 18:39:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 61035 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 27884386187E for ; Wed, 23 Nov 2022 18:42:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 27884386187E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669228957; bh=MypTuBChxv5yLlcBvrUaa3mldTOPHPB60LRJX/DtBhs=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=E2TvIzIZg8L79bVyxsdhZ3Bm/jNRdXJt14/oFpclJbVfVsYhKv7CG15sDp55n2dVz LkQBH/qNVdZyumCrrk88Nu/Sg8G0B0B7sGFVJG74nSzxVXQB43NFGYwPIFzd1EakB1 qHI1u4n2nj+jedI2JkNCle+W6+2Wddn1nUFLeYNQ= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id A850C38518A6 for ; Wed, 23 Nov 2022 18:42:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A850C38518A6 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2ANIg608028140 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Nov 2022 13:42:10 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2ANIg608028140 Received: from simark.localdomain (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CD7911E11F; Wed, 23 Nov 2022 13:42:05 -0500 (EST) To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 09/14] gdb/testsuite/gdb.base/break.exp: split test_break_silent_and_more Date: Wed, 23 Nov 2022 13:39:54 -0500 Message-Id: <20221123183959.2476477-10-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221123183959.2476477-1-simon.marchi@polymtl.ca> References: <20221123183959.2476477-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 23 Nov 2022 18:42:06 +0000 X-Spam-Status: No, score=-3189.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Simon Marchi via Gdb-patches From: Simon Marchi Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" This one is a bit tricky. The clear tests seem to depend on the various breakpoints that have been set before, starting with the "silent" breakpoints. So, move all this in a single chunk, it can always be split later if needed. Change-Id: I7ba61a5b130ade63eda0c4790534840339f8a72f --- gdb/testsuite/gdb.base/break.exp | 118 ++++++++++++++++--------------- 1 file changed, 62 insertions(+), 56 deletions(-) diff --git a/gdb/testsuite/gdb.base/break.exp b/gdb/testsuite/gdb.base/break.exp index cc327c195f46..e8762ffa664c 100644 --- a/gdb/testsuite/gdb.base/break.exp +++ b/gdb/testsuite/gdb.base/break.exp @@ -533,75 +533,81 @@ gdb_test "break if (1)" \ # Verify that a "silent" breakpoint can be set, and that GDB is indeed # "silent" about its triggering. -# -if ![runto_main] then { - return -} -gdb_test_multiple "break $bp_location1" \ - "set to-be-silent break bp_location1" { - -re "Breakpoint (\[0-9\]*) at .*, line $bp_location1.*$gdb_prompt $" { - set bpno $expect_out(1,string) - pass "set to-be-silent break bp_location1" - } +proc_with_prefix test_break_silent_and_more {} { + clean_restart break + + if ![runto_main] then { + return } -gdb_test "commands $bpno\nsilent\nend" ">end" "set silent break bp_location1" + gdb_test_multiple "break $::bp_location1" \ + "set to-be-silent break bp_location1" { + -re "Breakpoint (\[0-9\]*) at .*, line $::bp_location1.*$::gdb_prompt $" { + set bpno $expect_out(1,string) + pass "set to-be-silent break bp_location1" + } + } -gdb_test "info break $bpno" \ - "\[0-9\]*\[ \t\]*breakpoint.*:$bp_location1\r\n\[ \t\]*silent.*" \ - "info silent break bp_location1" + gdb_test "commands $bpno\nsilent\nend" ">end" "set silent break bp_location1" -gdb_test "continue" "Continuing." \ - "hit silent break bp_location1" + gdb_test "info break $bpno" \ + "\[0-9\]*\[ \t\]*breakpoint.*:$::bp_location1\r\n\[ \t\]*silent.*" \ + "info silent break bp_location1" -gdb_test "bt" "#0 main .* at .*:$bp_location1.*" \ - "stopped for silent break bp_location1" + gdb_test "continue" "Continuing." \ + "hit silent break bp_location1" -# Verify the $_hit_bpnum convenience variable is set to the silent hit bpno. -gdb_test "printf \"%d\\n\", \$_hit_bpnum" "$bpno" \ - "Silent breakpoint hit \$_hit_bpnum is silent $bpno" - -# Verify that GDB can at least parse a breakpoint with the -# "thread" keyword. (We won't attempt to test here that a -# thread-specific breakpoint really triggers appropriately. -# The gdb.threads subdirectory contains tests for that.) -# -set bp_location12 [gdb_get_line_number "set breakpoint 12 here"] -gdb_test "break $bp_location12 thread 999" "Unknown thread 999.*" \ - "thread-specific breakpoint on non-existent thread disallowed" + gdb_test "bt" "#0 main .* at .*:$::bp_location1.*" \ + "stopped for silent break bp_location1" -gdb_test "break $bp_location12 thread foo" \ - "Invalid thread ID: foo" \ - "thread-specific breakpoint on bogus thread ID disallowed" + # Verify the $_hit_bpnum convenience variable is set to the silent hit bpno. + gdb_test "printf \"%d\\n\", \$_hit_bpnum" "$bpno" \ + "Silent breakpoint hit \$_hit_bpnum is silent $bpno" -# Verify that GDB responds gracefully to a breakpoint command with -# trailing garbage. -# -gdb_test "break $bp_location12 foo" \ - "malformed linespec error: unexpected string, \"foo\".*" \ - "breakpoint with trailing garbage disallowed" + # Verify that GDB can at least parse a breakpoint with the + # "thread" keyword. (We won't attempt to test here that a + # thread-specific breakpoint really triggers appropriately. + # The gdb.threads subdirectory contains tests for that.) + # + set bp_location12 [gdb_get_line_number "set breakpoint 12 here"] + gdb_test "break $bp_location12 thread 999" "Unknown thread 999.*" \ + "thread-specific breakpoint on non-existent thread disallowed" -# Verify that GDB responds gracefully to a "clear" command that has -# no matching breakpoint. (First, get us off the current source line, -# which we know has a breakpoint.) -# -gdb_test "next" "marker1.*" "step over breakpoint" + gdb_test "break $bp_location12 thread foo" \ + "Invalid thread ID: foo" \ + "thread-specific breakpoint on bogus thread ID disallowed" -gdb_test "clear 81" "No breakpoint at 81.*" \ - "clear line has no breakpoint disallowed" + # Verify that GDB responds gracefully to a breakpoint command with + # trailing garbage. + # + gdb_test "break $bp_location12 foo" \ + "malformed linespec error: unexpected string, \"foo\".*" \ + "breakpoint with trailing garbage disallowed" -gdb_test "clear" "No breakpoint at this line.*" \ - "clear current line has no breakpoint disallowed" + # Verify that GDB responds gracefully to a "clear" command that has + # no matching breakpoint. (First, get us off the current source line, + # which we know has a breakpoint.) + # + gdb_test "next" "marker1.*" "step over breakpoint" -# Verify that we can set and clear multiple breakpoints. -# -# We don't test that it deletes the correct breakpoints. We do at -# least test that it deletes more than one breakpoint. -# -gdb_test "break marker3" "Breakpoint.*at.*" "break marker3 #1" -gdb_test "break marker3" "Breakpoint.*at.*" "break marker3 #2" -gdb_test "clear marker3" {Deleted breakpoints [0-9]+ [0-9]+.*} + gdb_test "clear 81" "No breakpoint at 81.*" \ + "clear line has no breakpoint disallowed" + + gdb_test "clear" "No breakpoint at this line.*" \ + "clear current line has no breakpoint disallowed" + + # Verify that we can set and clear multiple breakpoints. + # + # We don't test that it deletes the correct breakpoints. We do at + # least test that it deletes more than one breakpoint. + # + gdb_test "break marker3" "Breakpoint.*at.*" "break marker3 #1" + gdb_test "break marker3" "Breakpoint.*at.*" "break marker3 #2" + gdb_test "clear marker3" {Deleted breakpoints [0-9]+ [0-9]+.*} +} + +test_break_silent_and_more # Verify that a breakpoint can be set via a convenience variable.