From patchwork Tue Nov 15 20:48:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?K=C3=A9vin_Le_Gouguec?= X-Patchwork-Id: 60673 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 49287393BA4A for ; Tue, 15 Nov 2022 20:50:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 49287393BA4A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668545416; bh=7ECA3WqypXdijlMoUFL8Ht6MIYhIvVuVrvqF0nHVJYg=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=MGLD/QOn4wZKccz+Ox17V45M8GkZWQYr2DAxFK9JAzXwwPZR+Pveh40066xxX7yCU oaCiUlC2do9uDsiffFtwt+unhjD+/oD1t2128lZFAh6hPoI1U+wUxN0MmErb2wKfp9 rZPbNfckQ7G2ocWcAT6RvOlA0aO8E7A6KbfsbJJU= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id 48CE9392AC37 for ; Tue, 15 Nov 2022 20:49:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 48CE9392AC37 Received: by mail-wm1-x329.google.com with SMTP id fn7-20020a05600c688700b003b4fb113b86so27869wmb.0 for ; Tue, 15 Nov 2022 12:49:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7ECA3WqypXdijlMoUFL8Ht6MIYhIvVuVrvqF0nHVJYg=; b=IMEB01Ib6hBf/dA+MPiePWP4QmEvX0ostIAA8UfRVhRYv095DT1UnFiZ8UmSt/d/vM H0W/54rYSrNAuSyZf8ZysL3sZE070+8r/GGzKRiYPHBl6X4vKaCNBVhfNMfP+st7875c z11IFwVdhTXrLQ2yKeKTYHkquSP/XLB7FET9KuUwH9XKWr3yfMl+mHta2sBPDZTuaib+ zHKDjl/eYsQxHYEwMd9t1SJXd4eFHmwMrj0EeQvsJIj+svTJgAnTyrKESz7a8zJ0uCtV aLRfVyqLkDyCt4QRwtjmhvPjG9wp8aMpAUMW2/+Hql+xabl7Ql2TX6ntUtJJPrc7K+3K btDg== X-Gm-Message-State: ANoB5pkQmmPMCAtsCYmLuNFWnHaOQwxfchI2RSShKc9bN7m96MZar0Mz Prz5gUGvJ2Sb6knimoLOEBWwATAxRKp2qA== X-Google-Smtp-Source: AA0mqf7SU6v3qYfw0j6UGSvZ8w21FL/9QON6MdeXxjElolK0m3M8SegK15OmlVNAUquPis/q85waYA== X-Received: by 2002:a1c:cc07:0:b0:3cf:5b8a:a7cd with SMTP id h7-20020a1ccc07000000b003cf5b8aa7cdmr51751wmb.136.1668545388517; Tue, 15 Nov 2022 12:49:48 -0800 (PST) Received: from localhost.localdomain ([2a01:e0a:253:fe0:8cac:2ed7:853b:7ff9]) by smtp.gmail.com with ESMTPSA id t5-20020adfe445000000b00236740c6e6fsm13204197wrm.100.2022.11.15.12.49.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 12:49:47 -0800 (PST) To: gdb-patches@sourceware.org Cc: simon.marchi@polymtl.ca, =?utf-8?q?K=C3=A9vin_Le_Gouguec?= Subject: [PATCH] Guard against frame.c destructors running before frame-info.c's Date: Tue, 15 Nov 2022 21:48:21 +0100 Message-Id: <20221115204821.1260141-1-legouguec@adacore.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: =?utf-8?q?K=C3=A9vin_Le_Gouguec_via_Gdb-patches?= From: =?utf-8?q?K=C3=A9vin_Le_Gouguec?= Reply-To: =?utf-8?q?K=C3=A9vin_Le_Gouguec?= Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" On x86_64-windows, since 04e2ac7b2a7, we observe this internal error: [...]/gdbsupport/intrusive_list.h:458: internal-error: erase_element: Assertion `elem_node->prev != INTRUSIVE_LIST_UNLINKED_VALUE' failed. Breaking in the destructors for intrusive_list and frame_info_ptr shows that in this configuration, the destructors for frame.c's statically-stored objects are run before frame-info.c's: Thread 1 hit Breakpoint 7, intrusive_list >::~intrusive_list (this=0x7ff69c418c90 , __in_chrg=) [...]/../gdbsupport/intrusive_list.h:250 250 clear (); (gdb) bt #0 intrusive_list > ::~intrusive_list (this=0x7ff69c418c90 , __in_chrg=) [...]/../gdbsupport/intrusive_list.h:250 #1 0x00007ff69b78edba in __tcf_1 () [...]/frame-info.c:27 #2 0x00007ff9c457aa9f in msvcrt!_initterm_e () from C:\Windows\System32\msvcrt.dll #3 0x00007ff69b8246a6 in captured_main_1 (context=0x5ffe00) [...]/main.c:1111 #4 0x00007ff69b825149 in captured_main (data=0x5ffe00) [...]/main.c:1320 #5 0x00007ff69b8251b1 in gdb_main (args=0x5ffe00) [...]/main.c:1345 #6 0x00007ff69b5d1730 in main (argc=2, argv=0x751730) [...]/gdb.c:32 (gdb) c Continuing. Thread 1 hit Breakpoint 8, frame_info_ptr::~frame_info_ptr (this=0x7ff69c418e20 , __in_chrg=) [...]/frame-info.h:74 74 if (is_linked ()) (gdb) bt #0 frame_info_ptr::~frame_info_ptr (this=0x7ff69c418e20 , __in_chrg=) [...]/frame-info.h:74 #1 0x00007ff69b79a643 in __tcf_1 () [...]/frame.c:1675 #2 0x00007ff9c457aa9f in msvcrt!_initterm_e () from C:\Windows\System32\msvcrt.dll #3 0x00007ff69b8246a6 in captured_main_1 (context=0x5ffe00) [...]/main.c:1111 #4 0x00007ff69b825149 in captured_main (data=0x5ffe00) [...]/main.c:1320 #5 0x00007ff69b8251b1 in gdb_main (args=0x5ffe00) [...]/main.c:1345 #6 0x00007ff69b5d1730 in main (argc=2, argv=0x751730) [...]/gdb.c:32 --- gdb/frame-info.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/frame-info.h b/gdb/frame-info.h index 3369b114326..893b6632363 100644 --- a/gdb/frame-info.h +++ b/gdb/frame-info.h @@ -76,7 +76,11 @@ class frame_info_ptr : public intrusive_list_node ~frame_info_ptr () { - frame_list.erase (frame_list.iterator_to (*this)); + /* If this node has static storage, it may be deleted after + frame_list. Attempting to erase ourselves would then trigger + internal errors, so make sure we are still linked first. */ + if (is_linked ()) + frame_list.erase (frame_list.iterator_to (*this)); } frame_info_ptr &operator= (const frame_info_ptr &other)