From patchwork Thu Nov 10 18:41:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 60364 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B6CFB3858D3C for ; Thu, 10 Nov 2022 18:44:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B6CFB3858D3C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668105879; bh=tGAnOi4vxrNi6dzQLMbXtVngCXYnFZlKjqri5LjAJ7A=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=MS7tK98p4zjkcIcveJKoHhauPpuA+aWW0OJ0fK7ez0ddc3LlRiuv2u3YvEKdggy/V NKs/7WCHyqnumUkeS1IilPxcrGJJDAeq1IDq00snlnPAf/qV2RFzmMdrPFiUfra+or VJBqhAzUaN74lrWAgrWSrueJ0YyinwQqAlnGQr1k= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id C98C03858CDA for ; Thu, 10 Nov 2022 18:42:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C98C03858CDA Received: by smtp.gentoo.org (Postfix, from userid 559) id 258E0340F42; Thu, 10 Nov 2022 18:41:34 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH 2/4] sim: igen: mark output funcs with printf attribute Date: Fri, 11 Nov 2022 01:41:26 +0700 Message-Id: <20221110184128.18812-2-vapier@gentoo.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221110184128.18812-1-vapier@gentoo.org> References: <20221110184128.18812-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Mike Frysinger via Gdb-patches From: Mike Frysinger Reply-To: Mike Frysinger Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" ... and fix the legitimate bug that it catches. --- sim/igen/ld-insn.c | 2 +- sim/igen/misc.h | 9 +++------ 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/sim/igen/ld-insn.c b/sim/igen/ld-insn.c index aa9688dda955..a823b3f6cf60 100644 --- a/sim/igen/ld-insn.c +++ b/sim/igen/ld-insn.c @@ -448,7 +448,7 @@ parse_insn_words (insn_entry * insn, char *formats) the same size */ if (f->width != refered_field->width) error (insn->line, - "Conditional `%s' of field `%s' should be of size %s\n", + "Conditional `%s' of field `%s' should be of size %i\n", cond->string, f->val_string, refered_field->width); } diff --git a/sim/igen/misc.h b/sim/igen/misc.h index 163ffe498fca..0515c5a52793 100644 --- a/sim/igen/misc.h +++ b/sim/igen/misc.h @@ -36,11 +36,7 @@ enum #include #include -#if !defined (__attribute__) && (!defined(__GNUC__) || __GNUC__ < 2 || (__GNUC__ == 2 && __GNUC_MINOR__ < 7)) -#define __attribute__(arg) -#endif - - +#include "ansidecl.h" #include "filter_host.h" @@ -52,7 +48,8 @@ struct _line_ref }; /* Error appends a new line, warning and notify do not */ -typedef void error_func (const line_ref *line, const char *msg, ...); +typedef void error_func (const line_ref *line, const char *msg, ...) + ATTRIBUTE_PRINTF (2, 3); extern error_func error; extern error_func warning;