From patchwork Wed Nov 9 17:34:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 60287 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C47E83858D28 for ; Wed, 9 Nov 2022 17:35:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C47E83858D28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668015317; bh=/0FLJdYWjKruJ/4cCuhyov1xIXmijkLeJcc/B3cuqWU=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=c7+E48nS0fxgbC+OC5gPqvk4FqYQn+4BT8boKy1sTBBBoMUbrCBfHaEDee+CKYlUq Nzvefj4MDE1BBcnnlxWieZzL+s0x8CjGWQpNSyc20ViSEDF0Fz/3AfVXThCwTYq6os +zj1xPJPs5ddkEJz9dARgBzrnyWjeDTM2dU0klNw= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 91C743858D20 for ; Wed, 9 Nov 2022 17:34:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 91C743858D20 Received: by smtp.gentoo.org (Postfix, from userid 559) id 3DD5E340E12; Wed, 9 Nov 2022 17:34:52 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH] sim: igen: add missing newline to various error messages Date: Thu, 10 Nov 2022 00:34:49 +0700 Message-Id: <20221109173449.27434-1-vapier@gentoo.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Mike Frysinger via Gdb-patches From: Mike Frysinger Reply-To: Mike Frysinger Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" The error() function expects a trailing newline in its message. Most callers do this already, so adding it to the few that don't. --- sim/igen/gen-support.c | 2 +- sim/igen/gen.c | 2 +- sim/igen/ld-insn.c | 2 +- sim/igen/misc.c | 2 +- sim/igen/misc.h | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/sim/igen/gen-support.c b/sim/igen/gen-support.c index de5a507753a1..d9d0f7c09a65 100644 --- a/sim/igen/gen-support.c +++ b/sim/igen/gen-support.c @@ -180,7 +180,7 @@ support_c_function (lf *file, function_entry * function, void *data) lf_printf (file, "{\n"); lf_indent (file, +2); if (function->code == NULL) - error (function->line, "Function without body (or null statement)"); + error (function->line, "Function without body (or null statement)\n"); lf_print__line_ref (file, function->code->line); table_print_code (file, function->code); if (function->is_internal) diff --git a/sim/igen/gen.c b/sim/igen/gen.c index d2a40d194b03..3882b5bd34a2 100644 --- a/sim/igen/gen.c +++ b/sim/igen/gen.c @@ -987,7 +987,7 @@ gen_entry_expand_opcode (gen_entry *table, } if (bit == NULL && t == NULL) error (instruction->line, - "Conditional `%s' of field `%s' isn't expanded", + "Conditional `%s' of field `%s' isn't expanded\n", condition->string, field->val_string); switch (condition->test) { diff --git a/sim/igen/ld-insn.c b/sim/igen/ld-insn.c index 20c1f77b33fb..435bf483efd7 100644 --- a/sim/igen/ld-insn.c +++ b/sim/igen/ld-insn.c @@ -914,7 +914,7 @@ static table_entry * parse_macro_record (table *file, table_entry *record) { #if 1 - error (record->line, "Macros are not implemented"); + error (record->line, "Macros are not implemented\n"); #else /* parse the define record */ if (record->nr_fields < nr_define_fields) diff --git a/sim/igen/misc.c b/sim/igen/misc.c index 598f886d7ae0..c5c494bb6b5c 100644 --- a/sim/igen/misc.c +++ b/sim/igen/misc.c @@ -246,7 +246,7 @@ name2i (const char *names, const name_map * map) if (curr->i >= 0) return curr->i; else - error (NULL, "%s contains no valid names", names); + error (NULL, "%s contains no valid names\n", names); return 0; } diff --git a/sim/igen/misc.h b/sim/igen/misc.h index a1cae768179f..214505a761fb 100644 --- a/sim/igen/misc.h +++ b/sim/igen/misc.h @@ -64,7 +64,7 @@ do { \ line_ref line; \ line.file_name = filter_filename (__FILE__); \ line.line_nr = __LINE__; \ - error (&line, EXPRESSION); \ + error (&line, EXPRESSION "\n"); \ } while (0) #define ASSERT(EXPRESSION) \ @@ -73,7 +73,7 @@ do { \ line_ref line; \ line.file_name = filter_filename (__FILE__); \ line.line_nr = __LINE__; \ - error(&line, "assertion failed - %s\n", #EXPRESSION); \ + error (&line, "assertion failed - %s\n", #EXPRESSION); \ } \ } while (0)