From patchwork Tue Feb 18 12:02:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 38199 Received: (qmail 21365 invoked by alias); 18 Feb 2020 12:02:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 21356 invoked by uid 89); 18 Feb 2020 12:02:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, LIKELY_SPAM_BODY, SPF_PASS autolearn=ham version=3.3.1 spammy=po, p.o, start.S, startS X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Feb 2020 12:02:40 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 317ECAD8E for ; Tue, 18 Feb 2020 12:02:38 +0000 (UTC) Date: Tue, 18 Feb 2020 13:02:36 +0100 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH][gdb/testsuite] Be quiet about untested dtrace-prob.exp Message-ID: <20200218120235.GA9051@delia> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-IsSubscribed: yes Hi, When running gdb.base/dtrace-probe.exp, I get this on stdout/stderr: ... Running src/gdb/testsuite/gdb.base/dtrace-probe.exp ... gdb compile failed, ld: error in \ build/gdb/testsuite/outputs/gdb.base/dtrace-probe/dtrace-probe.o\ (.eh_frame); no .eh_frame_hdr table will be created ld: crt1.o: in function `_start': start.S:110: undefined reference to `main' ld: build/gdb/testsuite/outputs/gdb.base/dtrace-probe/dtrace-probe-p.o:\ (.SUNW_dof+0x88): undefined reference to `main' ld: build/gdb/testsuite/outputs/gdb.base/dtrace-probe/dtrace-probe-p.o:\ (.SUNW_dof+0xb8): undefined reference to `main' collect2: error: ld returned 1 exit status === gdb Summary === nr of untested testcases 1 ... There is no reason to be this verbose about the failure to compile. Fix this by using quiet as additional option to gdb_compile in dtrace_build_usdt_test_program. Note that the error message still occurs in gdb.log. Tested on x86_64-linux. OK for trunk? Thanks, - Tom [gdb/testsuite] Be quiet about untested dtrace-prob.exp gdb/testsuite/ChangeLog: 2020-02-18 Tom de Vries * lib/dtrace.exp (dtrace_build_usdt_test_program): Use quiet as gdb_compile option. --- gdb/testsuite/lib/dtrace.exp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/lib/dtrace.exp b/gdb/testsuite/lib/dtrace.exp index 9aed481f32..8f861c9de4 100644 --- a/gdb/testsuite/lib/dtrace.exp +++ b/gdb/testsuite/lib/dtrace.exp @@ -52,7 +52,8 @@ proc dtrace_build_usdt_test_program {} { } # 2. Compile testprogram.c. - set options [list debug additional_flags=-I[file dirname $out_header_file]] + set options [list debug quiet \ + additional_flags=-I[file dirname $out_header_file]] if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}.o" object ${options}] != ""} { return -1 } @@ -65,7 +66,8 @@ proc dtrace_build_usdt_test_program {} { } # 4. Link everything together to get the test program. - if {[gdb_compile "${binfile}.o ${binfile}-p.o" ${binfile} executable {debug}] != ""} { + if {[gdb_compile "${binfile}.o ${binfile}-p.o" ${binfile} executable \ + {debug quiet}] != ""} { return -1 } }