From patchwork Fri Jan 10 22:00:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 37294 Received: (qmail 72941 invoked by alias); 10 Jan 2020 22:00:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 72864 invoked by uid 89); 10 Jan 2020 22:00:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1664 X-HELO: mail.efficios.com Received: from mail.efficios.com (HELO mail.efficios.com) (167.114.142.138) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Jan 2020 22:00:44 +0000 Received: from localhost (ip6-localhost [IPv6:::1]) by mail.efficios.com (Postfix) with ESMTP id D2FFE69611A for ; Fri, 10 Jan 2020 17:00:40 -0500 (EST) Received: from mail.efficios.com ([IPv6:::1]) by localhost (mail02.efficios.com [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id JiFN5uFQVXmC; Fri, 10 Jan 2020 17:00:40 -0500 (EST) Received: from localhost (ip6-localhost [IPv6:::1]) by mail.efficios.com (Postfix) with ESMTP id 6600B6960E3; Fri, 10 Jan 2020 17:00:37 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 6600B6960E3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1578693637; bh=D5mOLOnA81GYqg0xAgoYXdwuKFVKgDRgsGw0h3bi1ME=; h=From:To:Date:Message-Id:MIME-Version; b=u2oKQZEuTuKqKInULLnUZ5U5klE5OCOFhuho4VUszOAotT+8tDPcKkVXDh9NRvMxY zKAmGNpupJXpCK+wDiMsqcZ3kYqRB50tO8ow+rAueEHnZtYhz4uz4Dw963dUrwuGBA 5xhDql6tdcYR1YkG+fJ2Ke6MJmzsx1WkxknYTBLLKNhmT1HE5hTDLU+8ZJJi3cRMXT qcSd5GIy2NRoxH8I4wmyvm2Xi99qeVZ2Nhkrffvprz2mFThbVcHQih3NY2EqaxV5Zb NGWovw4Xn9BX+FBh/LxkJc08rmq0VUj108cIuQUadgb4qCxHNocKgViALlUHmk8PrR BN2gU1L5KHQaQ== Received: from mail.efficios.com ([IPv6:::1]) by localhost (mail02.efficios.com [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id Uig5PBo3p361; Fri, 10 Jan 2020 17:00:37 -0500 (EST) Received: from smarchi-efficios.internal.efficios.com (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) by mail.efficios.com (Postfix) with ESMTPSA id 001D06960AE; Fri, 10 Jan 2020 17:00:35 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH v2 7/7] Enable -Wmissing-declarations diagnostic Date: Fri, 10 Jan 2020 17:00:27 -0500 Message-Id: <20200110220027.26450-8-simon.marchi@efficios.com> In-Reply-To: <20200110220027.26450-1-simon.marchi@efficios.com> References: <20200110220027.26450-1-simon.marchi@efficios.com> MIME-Version: 1.0 Now that most warnings of this kind are fixed, we can enable -Wmissing-declarations. I say "most", because it is likely that there are some more in some configurations I am not able to build, but they should be pretty easy to fix. gdb/ChangeLog: * warning.m4: Add -Wmissing-declarations to build_warnings. * configure: Re-generate. Change-Id: Iae9b59f22eb5dd1965d09f34c5c9e212cddf67ba --- gdb/configure | 3 ++- gdb/gdbserver/configure | 3 ++- gdb/warning.m4 | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/gdb/configure b/gdb/configure index b572d414ca51..aa53c097ca8f 100755 --- a/gdb/configure +++ b/gdb/configure @@ -16105,7 +16105,8 @@ build_warnings="-Wall -Wpointer-arith \ -Wshadow=local \ -Wdeprecated-copy \ -Wdeprecated-copy-dtor \ --Wredundant-move" +-Wredundant-move \ +-Wmissing-declarations" case "${host}" in *-*-mingw32*) diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure index 4de751b44915..f70b3d552156 100755 --- a/gdb/gdbserver/configure +++ b/gdb/gdbserver/configure @@ -8094,7 +8094,8 @@ build_warnings="-Wall -Wpointer-arith \ -Wshadow=local \ -Wdeprecated-copy \ -Wdeprecated-copy-dtor \ --Wredundant-move" +-Wredundant-move \ +-Wmissing-declarations" case "${host}" in *-*-mingw32*) diff --git a/gdb/warning.m4 b/gdb/warning.m4 index 00bcdfa7ea50..e2b8a43ddbd5 100644 --- a/gdb/warning.m4 +++ b/gdb/warning.m4 @@ -49,7 +49,8 @@ build_warnings="-Wall -Wpointer-arith \ -Wshadow=local \ -Wdeprecated-copy \ -Wdeprecated-copy-dtor \ --Wredundant-move" +-Wredundant-move \ +-Wmissing-declarations" case "${host}" in *-*-mingw32*)