From patchwork Fri Jan 10 22:00:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 37293 Received: (qmail 72400 invoked by alias); 10 Jan 2020 22:00:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 72349 invoked by uid 89); 10 Jan 2020 22:00:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1137 X-HELO: mail.efficios.com Received: from mail.efficios.com (HELO mail.efficios.com) (167.114.142.138) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Jan 2020 22:00:41 +0000 Received: from localhost (ip6-localhost [IPv6:::1]) by mail.efficios.com (Postfix) with ESMTP id BCC186960FA for ; Fri, 10 Jan 2020 17:00:39 -0500 (EST) Received: from mail.efficios.com ([IPv6:::1]) by localhost (mail02.efficios.com [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id RV4MCNC9E4_r; Fri, 10 Jan 2020 17:00:39 -0500 (EST) Received: from localhost (ip6-localhost [IPv6:::1]) by mail.efficios.com (Postfix) with ESMTP id 374386960B9; Fri, 10 Jan 2020 17:00:36 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 374386960B9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1578693636; bh=jWQDRi7152+RpjIxgQ1yQk65dQZqBzoqyzkoO0ovMTs=; h=From:To:Date:Message-Id:MIME-Version; b=ia2FwqC1BrGbK5AZg/kdGg9CI196cIfzS60+q0AQtlEF5WwsNp7eO/tq9BnwH5MuK 459cAvFE6JVG5bhcOp7rl8qJWv7e6uZ4mkhvAdmmSDq7Fjcv+0jIAMkSF2795S5tna pU4OOsUDfeVJO6mPlz53zlr2DisueJ0lCDuDD8JMT9p1Tp+j6aMxFEN+SX60tSbe+T /v8T3ldvBE+v+zyoU/SRw5iTlgBNjRYOAHlv80qdKs6UlGFcLdq85w8eWelHzMUn+L DHsC4H83TgnPYXGAW9IAfNGFWUyBvU83MsF/ucZ9TNsxXQMxDhrH1GWuC8NGJKU1/n F6SJFowKSIy1A== Received: from mail.efficios.com ([IPv6:::1]) by localhost (mail02.efficios.com [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id KXCSiyJ8LBSQ; Fri, 10 Jan 2020 17:00:36 -0500 (EST) Received: from smarchi-efficios.internal.efficios.com (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) by mail.efficios.com (Postfix) with ESMTPSA id 850B9696099; Fri, 10 Jan 2020 17:00:35 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH v2 2/7] gdb: add declaration to Python init function Date: Fri, 10 Jan 2020 17:00:22 -0500 Message-Id: <20200110220027.26450-3-simon.marchi@efficios.com> In-Reply-To: <20200110220027.26450-1-simon.marchi@efficios.com> References: <20200110220027.26450-1-simon.marchi@efficios.com> MIME-Version: 1.0 When I try to enable -Wmissing-declarations, I get this error: CXX python/python.o /home/smarchi/src/binutils-gdb/gdb/python/python.c: In function ‘PyObject* init__gdb_module()’: /home/smarchi/src/binutils-gdb/gdb/python/python.c:1582:1: error: no previous declaration for ‘PyObject* init__gdb_module()’ [-Werror=missing-declarations] init__gdb_module (void) ^~~~~~~~~~~~~~~~ Prevent it by providing a declaration just before the definition. gdb/ChangeLog: * python/python.c (init__gdb_module): Add declaration. Change-Id: I394bc691b7db624708cc4cb2cda28a56ab85a82b --- gdb/python/python.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdb/python/python.c b/gdb/python/python.c index f7aadb1633c8..e0c05f1d0689 100644 --- a/gdb/python/python.c +++ b/gdb/python/python.c @@ -1555,6 +1555,7 @@ finalize_python (void *ignore) /* This is called via the PyImport_AppendInittab mechanism called during initialization, to make the built-in _gdb module known to Python. */ +PyMODINIT_FUNC init__gdb_module (void); PyMODINIT_FUNC init__gdb_module (void) {